You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-07] Split - Self DM disappears after moving one split to workspace and deleting remaining one. #91913
Version Number: 9.3.84-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#84382 Email or phone of affected tester (no customers):ibellicotest+2723@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome App Component: Money Requests
Action Performed:
Prerequisite: Account has a workspace.
Prerequisite 2: Account has Self DM.
Open the staging.new.expensify.com website.
Navigate to Self DM.
Create a manual expense.
Open the just created expense.
Click on "More" > "Split" > Save splits.
Open one of the splits.
Click on "More" > "Move to Report" > "Create Report"
Return to Self DM.
Right click and delete the remaining split.
Note that after split is deleted, Self DM disappears from LHN.
Click on the search icon on the top right corner.
Note that Self DM is not visible on search list.
Expected Result:
Self DM should still be visible after deleting a split.
Actual Result:
Self DM disappears from LHN and "Search", after moving on split to workspace and deleting the remaining one.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #84382 - "Add splits for unreported expenses" by @ZhenjaHorbach (High confidence) Related Issues: #72125 (the fixed issue that PR 84382 addressed)
Recommendation: REVERT
PR #84382 introduced a large new feature (split expenses for unreported/Self DM expenses) and is the only PR in this staging cycle that touches the split expense deletion flow and Self DM report handling. Reverting it will restore the correct Self DM LHN visibility behavior.
PR Add splits for unreported expenses #84382 is listed as the regression test link in the issue body itself (https://github.com/Expensify/App/pull/84382).
The bug is staging-only ("N/A - new feature, doesn't exist in prod"), and PR Add splits for unreported expenses #84382 introduced the new split expense feature for Self DM / unreported expenses.
The reproduction steps involve the exact features introduced by this PR: splitting an expense from Self DM, using "Move to Report", then deleting the remaining split — all flows heavily modified by Add splits for unreported expenses #84382.
Verification
PR Add splits for unreported expenses #84382 modifies src/hooks/useDeleteTransactions.ts, src/libs/actions/IOU/SplitTransactionUpdate.ts, src/libs/actions/SplitExpenses.ts, and src/libs/actions/IOU/SplitExpenseItems.ts.
These files contain all the code paths exercised by the reproduction steps: splitting in Self DM, moving a split to a workspace report, and deleting the remaining split.
The useDeleteTransactions.ts hook introduces logic that resolves selfDMReportID for split transactions with UNREPORTED_REPORT_ID, and calls updateSplitTransactions when deleting the last sibling split — this is the code path triggered by steps 9 and 10 of the reproduction.
Root Cause
When one split is moved to a workspace report (step 7) and the remaining split in Self DM is deleted (step 9), the new deletion flow in useDeleteTransactions calls updateSplitTransactions (or falls through to deleteMoneyRequest) with the Self DM report as chatReport. The cleanup Onyx updates inside deleteMoneyRequest — specifically the shouldDeleteIOUReport branch which sets iouReportID: null and nullifies the IOU report — appear to be incorrectly applied to the Self DM report, causing it to lose the data that makes it visible in the LHN and search. Since Self DM should never be deleted or hidden as a side effect of deleting a split transaction, the fix requires correcting how the Self DM report is handled during the split deletion cleanup in PR #84382's new code.
When the last split child is being deleted (childTransactions.length === 0), it gets pushed to nonSplitTransactions (useDeleteTransactions.ts:189-190).
The delete path in MoneyRequestHeaderSecondaryActions.tsx:444 explicitly blocks splits from using deleteTrackExpense (isTrackExpenseAction(parentReportAction) && !isExpenseSplit).
So deleteMoneyRequest is called, but since IOUReportID is undefined, both iouReport and chatReport resolve to undefined (useDeleteTransactions.ts:276-278). This means the optimistic data cannot update the Self DM report or its report actions.
Additionally, when a split is moved to a workspace via changeTransactionsReport, the old IOU action in Self DM is cleared but lastMessageText on the Self DM report is never recalculated (Transaction.ts:1390-1413). After the move + delete, the Self DM has no visible actions, isEmptyReport() returns true, and it gets filtered out of the LHN.
What changes do you think we should make in order to solve the problem?
The fix should be in useDeleteTransactions.ts — when the last split child is deleted (childTransactions.length === 0) and the parent action is a TRACK expense in Self DM, the transaction should be routed through deleteTrackExpense instead of deleteMoneyRequest. This ensures the Self DM report and its report actions are properly updated optimistically (recalculating lastMessageText, etc.), preserving the Self DM's visibility in the LHN.
Specifically, in the childTransactions.length === 0 branch at line 189, before pushing to nonSplitTransactions, check if the original transaction's IOU action is a track expense. If so, call deleteTrackExpense with the Self DM as the chatReport instead of falling through to the deleteMoneyRequest path.
What alternative solutions did you explore? (Optional)
An alternative would be to fix changeTransactionsReport to update lastMessageText on the source report when moving a transaction out. However, this alone wouldn't fully solve the problem — the deleteMoneyRequest path would still fail to properly clean up the Self DM for TRACK-type split actions with no IOUReportID. The correct delete path (deleteTrackExpense) already handles Self DM cleanup properly, so routing to it is the more complete fix.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Split - Self DM disappears after moving one split to workspace and deleting remaining one.[/-][+][Due for payment 2026-08-07] Split - Self DM disappears after moving one split to workspace and deleting remaining one.[/+]on Jul 31, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.46-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
melvin-bot commentedon May 28, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #84382
melvin-bot commentedon May 28, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 28, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon May 28, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #84382 - "Add splits for unreported expenses" by @ZhenjaHorbach (High confidence)
Related Issues: #72125 (the fixed issue that PR 84382 addressed)
Recommendation: REVERT
PR #84382 introduced a large new feature (split expenses for unreported/Self DM expenses) and is the only PR in this staging cycle that touches the split expense deletion flow and Self DM report handling. Reverting it will restore the correct Self DM LHN visibility behavior.
Assigned: @ZhenjaHorbach (PR author), @dmkt9, @lakchote (approving reviewers)
Labels:
DeployBlockerCashkept (frontend/App bug). No label changes made.Detailed Analysis
Evidence
https://github.com/Expensify/App/pull/84382).Verification
src/hooks/useDeleteTransactions.ts,src/libs/actions/IOU/SplitTransactionUpdate.ts,src/libs/actions/SplitExpenses.ts, andsrc/libs/actions/IOU/SplitExpenseItems.ts.useDeleteTransactions.tshook introduces logic that resolvesselfDMReportIDfor split transactions withUNREPORTED_REPORT_ID, and callsupdateSplitTransactionswhen deleting the last sibling split — this is the code path triggered by steps 9 and 10 of the reproduction.Root Cause
When one split is moved to a workspace report (step 7) and the remaining split in Self DM is deleted (step 9), the new deletion flow in
useDeleteTransactionscallsupdateSplitTransactions(or falls through todeleteMoneyRequest) with the Self DM report aschatReport. The cleanup Onyx updates insidedeleteMoneyRequest— specifically theshouldDeleteIOUReportbranch which setsiouReportID: nulland nullifies the IOU report — appear to be incorrectly applied to the Self DM report, causing it to lose the data that makes it visible in the LHN and search. Since Self DM should never be deleted or hidden as a side effect of deleting a split transaction, the fix requires correcting how the Self DM report is handled during the split deletion cleanup in PR #84382's new code.MelvinBot commentedon May 28, 2026
Proposal
What is the root cause of that problem?
When the last remaining split child in Self DM is deleted, it flows through
deleteMoneyRequestinstead ofdeleteTrackExpense. This happens because:IOUReportID: undefined(MoneyRequestBuilder.ts:474-479).childTransactions.length === 0), it gets pushed tononSplitTransactions(useDeleteTransactions.ts:189-190).MoneyRequestHeaderSecondaryActions.tsx:444explicitly blocks splits from usingdeleteTrackExpense(isTrackExpenseAction(parentReportAction) && !isExpenseSplit).deleteMoneyRequestis called, but sinceIOUReportIDis undefined, bothiouReportandchatReportresolve toundefined(useDeleteTransactions.ts:276-278). This means the optimistic data cannot update the Self DM report or its report actions.Additionally, when a split is moved to a workspace via
changeTransactionsReport, the old IOU action in Self DM is cleared butlastMessageTexton the Self DM report is never recalculated (Transaction.ts:1390-1413). After the move + delete, the Self DM has no visible actions,isEmptyReport()returns true, and it gets filtered out of the LHN.What changes do you think we should make in order to solve the problem?
The fix should be in
useDeleteTransactions.ts— when the last split child is deleted (childTransactions.length === 0) and the parent action is a TRACK expense in Self DM, the transaction should be routed throughdeleteTrackExpenseinstead ofdeleteMoneyRequest. This ensures the Self DM report and its report actions are properly updated optimistically (recalculatinglastMessageText, etc.), preserving the Self DM's visibility in the LHN.Specifically, in the
childTransactions.length === 0branch at line 189, before pushing tononSplitTransactions, check if the original transaction's IOU action is a track expense. If so, calldeleteTrackExpensewith the Self DM as thechatReportinstead of falling through to thedeleteMoneyRequestpath.What alternative solutions did you explore? (Optional)
An alternative would be to fix
changeTransactionsReportto updatelastMessageTexton the source report when moving a transaction out. However, this alone wouldn't fully solve the problem — thedeleteMoneyRequestpath would still fail to properly clean up the Self DM for TRACK-type split actions with noIOUReportID. The correct delete path (deleteTrackExpense) already handles Self DM cleanup properly, so routing to it is the more complete fix.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.41 remaining items
mitarachim commentedon Jul 29, 2026
Deploy Blocker #97395 was identified to be related to the PR #92055 that attempted to fix this issue.
melvin-bot commentedon Jul 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
jponikarchuk commentedon Jul 30, 2026
Deploy Blocker #97424 was identified to be related to the PR #92055 that attempted to fix this issue.
melvin-bot commentedon Jul 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
lakchote commentedon Jul 30, 2026
Original issue is not reproducible by QA anymore, see https://expensify.slack.com/archives/C09V78U42D8/p1785396519081229?thread_ts=1785394378.160169&cid=C09V78U42D8
melvin-bot commentedon Jul 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mitarachim commentedon Jul 30, 2026
Deploy Blocker #97436 was identified to be related to the PR #92055 that attempted to fix this issue.
[-]Split - Self DM disappears after moving one split to workspace and deleting remaining one.[/-][+][Due for payment 2026-08-07] Split - Self DM disappears after moving one split to workspace and deleting remaining one.[/+]melvin-bot commentedon Jul 31, 2026
@ZhenjaHorbach / @dmkt9
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.46-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Aug 19, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.