You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-27] Expense - "Tracked $XX" remains on chat after moving remaining split to workspace. #97424
Version Number: 9.4.46-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#92055 Email or phone of affected tester (no customers):ibellicotest+2766@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome App Component: Money Requests
Action Performed:
Prerequisite: Account has Self DM.
Prerequisite 2: Account has at least one workspace.
Open the staging.new.expensify.com website.
Navigate to Self DM.
Create a manual expense.
Open the just created expense.
Click on "More" > "Split" > Save splits.
Right click and delete the split displayed at the bottom.
Open remaining split.
Click on report field > "Create Report"
Return to Self DM.
Note that "Tracked $XX" is displayed as a message in chat.
Delete the message.
Note that message remains but expense disappears from workspace chat.
Delete the message again.
Note that now, message disappears too.
Expected Result:
User should be able to move remaining split to workspace chat and no message should remain visible on Self DM.
Actual Result:
After deleting unreported split and moving remaining one to workspace, "Tracked $XX" appears as message in chat on Self DM. Deleting the message, makes the split disappears from workspace chat.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #92055 - "Fix bugs for selfDM splits feature" by @ZhenjaHorbach (High confidence) Related Issues: This PR bundles fixes for #91874, #91876, #91879, #91907, #91913, #91917, #91918, #91920 (all part of the new self-DM splits feature)
Recommendation: ROLL FORWARD (targeted fix)
The self-DM splits feature is new (not in production), and PR #92055 bundles fixes for 8 linked issues across 25 files — a straight revert would reintroduce those bugs and is riskier than a scoped follow-up. The regression is contained to one code path (reverse-split-then-move) and is cleanly fixable.
Assigned: @ZhenjaHorbach (PR author), @lakchote and @dmkt9 (approving reviewers) from the highest-confidence causing PR Labels: No change. DeployBlockerCash is kept (App PR caused it, App deploy is blocked). DeployBlocker was not present, so nothing to remove.
Bug is staging-only / N/A in prod because self-DM splits is a brand-new feature that only exists behind this work.
The PR touches every subsystem the repro exercises: self-DM split creation/reverse (src/libs/actions/IOU/SplitTransactionUpdate.ts), split-child deletion (src/hooks/useDeleteTransactions.ts), and the tracked-expense report action rendering (src/pages/inbox/report/ReportActionItem.tsx, ChatActionableButtons.tsx).
Verification
Bug symptom areas map directly to PR changes:
Leftover "Tracked $XX" message → the IOU report-action cleanup in SplitTransactionUpdate.ts.
Double-delete of the message → the moved-split-child deletion grouping in useDeleteTransactions.ts.
Confirmed the merged code is present at local HEAD ad07aea4514235edcacd5629583f7ab240bc53d6 (grep for iouActionsToCleanUp, isMovedExpenseSplitChild, and the reworked isReverseSplitOperation).
Root Cause
The repro is: create tracked expense in Self DM → split into 2 → delete one split → move the remaining split to a workspace via "Create Report".
PR Fix bugs for selfDM splits feature #92055 loosened the reverse-split predicate. It now fires whenever one editable split remains, dropping the previous allChildTransactions.length === originalChildTransactions.length guard: SplitTransactionUpdate.ts#L290
So "delete one split, then move the last one to a workspace" now takes the reverse-split path (revive original transaction, then move it), not the creation path.
The stale-IOU-report-action cleanup — the code that marks the old "Tracked $XX" action DELETE and tears down its transaction thread — is gated on both!isReverseSplitOperationandisCreationOfSplits: SplitTransactionUpdate.ts#L1576-L1600
Because the move is a reverse-split (and not a creation), this block is skipped entirely. The revived original transaction moves to the workspace, but a fresh "Tracked $XX" report action is left orphaned in the Self DM — exactly the "message remains on chat" symptom.
The double-delete comes from the new moved-split-child branch in deletion: useDeleteTransactions.ts#L225-L235
The orphaned Self DM action points to a transaction thread whose transaction now lives in the workspace. The first delete resolves the transaction (expense disappears from the workspace chat) but leaves the report action behind; a second delete is needed to remove the message itself — the report-action deletion and transaction-thread deletion are not applied atomically for this moved-child case.
Suggested targeted fix
Extend the leftover-IOU-action cleanup so it also runs on a reverse-split that moves the surviving split to a different report (i.e. when isReverseSplitOperation is true and the split does not stay in the original Self DM), deleting the stale Self DM "Tracked $XX" action instead of leaving it orphaned — mirror the existing iouActionsToCleanUp block at SplitTransactionUpdate.ts#L1610 into that path.
Ensure the report-action DELETE and the transaction-thread teardown are pushed together for the moved-split-child case in useDeleteTransactions.ts so a single delete removes both the message and the expense.
changed the title [-]Expense - "Tracked $XX" remains on chat after moving remaining split to workspace.[/-][+][Due for payment 2026-08-27] Expense - "Tracked $XX" remains on chat after moving remaining split to workspace.[/+]on Aug 20, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.56-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-27. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jul 30, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/fe02344967061e2086a3396d8a0961b6ff705bc9ab9738a100f6856bd9af3d2f
melvin-bot commentedon Jul 30, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #92055
melvin-bot commentedon Jul 30, 2026
@lakchote @dmkt9 you have been assigned to this deploy blocker because you reviewed the offending PR: #92055
melvin-bot commentedon Jul 30, 2026
@ZhenjaHorbach you have been assigned to this deploy blocker because you authored the offending PR: #92055
melvin-bot commentedon Jul 30, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 30, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 30, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #92055 - "Fix bugs for selfDM splits feature" by @ZhenjaHorbach (High confidence)
Related Issues: This PR bundles fixes for #91874, #91876, #91879, #91907, #91913, #91917, #91918, #91920 (all part of the new self-DM splits feature)
Recommendation: ROLL FORWARD (targeted fix)
The self-DM splits feature is new (not in production), and PR #92055 bundles fixes for 8 linked issues across 25 files — a straight revert would reintroduce those bugs and is riskier than a scoped follow-up. The regression is contained to one code path (reverse-split-then-move) and is cleanly fixable.
Assigned: @ZhenjaHorbach (PR author), @lakchote and @dmkt9 (approving reviewers) from the highest-confidence causing PR
Labels: No change.
DeployBlockerCashis kept (App PR caused it, App deploy is blocked).DeployBlockerwas not present, so nothing to remove.📋 Detailed Analysis
Evidence
2026-07-29T09:35:16Z, and is item The mobile app opens up with the keyboard showing #76 on the current StagingDeployCash checklist (Deploy Checklist: New Expensify 2026-07-29 #97375,Deploy Checklist: New Expensify 2026-07-29) — the exact 9.4.46 release the blocker is filed against.src/libs/actions/IOU/SplitTransactionUpdate.ts), split-child deletion (src/hooks/useDeleteTransactions.ts), and the tracked-expense report action rendering (src/pages/inbox/report/ReportActionItem.tsx,ChatActionableButtons.tsx).Verification
SplitTransactionUpdate.ts.useDeleteTransactions.ts.ad07aea4514235edcacd5629583f7ab240bc53d6(grepforiouActionsToCleanUp,isMovedExpenseSplitChild, and the reworkedisReverseSplitOperation).Root Cause
The repro is: create tracked expense in Self DM → split into 2 → delete one split → move the remaining split to a workspace via "Create Report".
PR Fix bugs for selfDM splits feature #92055 loosened the reverse-split predicate. It now fires whenever one editable split remains, dropping the previous
allChildTransactions.length === originalChildTransactions.lengthguard:SplitTransactionUpdate.ts#L290So "delete one split, then move the last one to a workspace" now takes the reverse-split path (revive original transaction, then move it), not the creation path.
The stale-IOU-report-action cleanup — the code that marks the old "Tracked $XX" action
DELETEand tears down its transaction thread — is gated on both!isReverseSplitOperationandisCreationOfSplits:SplitTransactionUpdate.ts#L1576-L1600Because the move is a reverse-split (and not a creation), this block is skipped entirely. The revived original transaction moves to the workspace, but a fresh "Tracked $XX" report action is left orphaned in the Self DM — exactly the "message remains on chat" symptom.
The double-delete comes from the new moved-split-child branch in deletion:
useDeleteTransactions.ts#L225-L235The orphaned Self DM action points to a transaction thread whose transaction now lives in the workspace. The first delete resolves the transaction (expense disappears from the workspace chat) but leaves the report action behind; a second delete is needed to remove the message itself — the report-action deletion and transaction-thread deletion are not applied atomically for this moved-child case.
Suggested targeted fix
isReverseSplitOperationis true and the split does not stay in the original Self DM), deleting the stale Self DM "Tracked $XX" action instead of leaving it orphaned — mirror the existingiouActionsToCleanUpblock atSplitTransactionUpdate.ts#L1610into that path.DELETEand the transaction-thread teardown are pushed together for the moved-split-child case inuseDeleteTransactions.tsso a single delete removes both the message and the expense.5 remaining items
melvin-bot commentedon Aug 19, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Aug 19, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]Expense - "Tracked $XX" remains on chat after moving remaining split to workspace.[/-][+][Due for payment 2026-08-27] Expense - "Tracked $XX" remains on chat after moving remaining split to workspace.[/+]melvin-bot commentedon Aug 20, 2026
@ZhenjaHorbach / @dmkt9
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.56-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-27. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]