Repository navigation
Description
Objective
Eliminate the parallel double-merge in the Search screen that causes visible jank on row-tap (16–45ms in SPAN_OPEN_REPORT) and multi-select (8–15 row re-renders per checkbox press).
The root cause: getSections pulls the snapshot plus ~18 live Onyx inputs while each row already self-hydrates the same collections via its own subscriptions. The screen-level merge is pure waste and the cascade source.
Milestones
M1 — Eliminate the parallel live merge
Remove the 18 live-Onyx merge inputs from getSections, one cluster per PR. After M1, useMemo deps drop from ~28 to ~7; the cascade is gone.
Suggested PR order:
-
reportActions/exportReportActions/allReportMetadata/reportAttributesDerivedValue+ capability booleans +useRowSelection— perf(Search): row-tap cascade kill via row-level live recompute + compiler-stable refs #91438 -
policies(highest fan-out) -
allTransactionViolations -
cardFeeds+customCardNames -
onyxPersonalDetailsList -
policyForMovingExpenses - Remaining small inputs (
bankAccountList,archivedReportsIDList,isActionLoadingSet,isOffline, etc.)
M2 — Shell decomposition
Extract primitives, build five view files (ChatSearchView, TaskSearchView, ExpenseFlatSearchView, ExpenseGroupedSearchView, ExpenseReportSearchView), delete SearchList and BaseSearchList.
M3 — Selection consumer API + action relocation
Add useRowSelection, useSelectionCounts, useRowSelectionActions hooks over existing SearchContext. Relocate toggleTransaction into SearchActionsContext.
Sub-issues
- [Due for payment 2026-06-16] [Search Decomp M1-A] Drop screen-level live merge: reportActions/allReportMetadata + row capabilities #92080 — [M1-A] Drop screen-level live merge: reportActions/allReportMetadata + row capabilities
Related code
src/components/Search/index.tsx— main screen, parallel merge lives heresrc/hooks/useSearchSections.ts—getSections28-dep useMemosrc/components/Search/SearchList/— row components, self-hydration layersrc/libs/SearchUIUtils.ts—getSectionsimplementation
Issue Owner
Current Issue Owner: @adhorodyskiMetadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
adhorodyski commentedon Jun 11, 2026
@BartekObudzinski will take over this to help me deliver PRs starting with #92809 I opened recently.
12 remaining items
melvin-bot commentedon Jul 17, 2026
This issue has not been updated in over 15 days. @mountiny, @adhorodyski eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
melvin-bot commentedon Sep 14, 2026
@mountiny, @adhorodyski, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.