Skip to content

[Tracking] Search screen decomposition — eliminate parallel double-merge (perf) #92079

Closed
11 of 11 issues completed

Description

@mountiny

Objective

Eliminate the parallel double-merge in the Search screen that causes visible jank on row-tap (16–45ms in SPAN_OPEN_REPORT) and multi-select (8–15 row re-renders per checkbox press).

The root cause: getSections pulls the snapshot plus ~18 live Onyx inputs while each row already self-hydrates the same collections via its own subscriptions. The screen-level merge is pure waste and the cascade source.

Milestones

M1 — Eliminate the parallel live merge

Remove the 18 live-Onyx merge inputs from getSections, one cluster per PR. After M1, useMemo deps drop from ~28 to ~7; the cascade is gone.

Suggested PR order:

M2 — Shell decomposition

Extract primitives, build five view files (ChatSearchView, TaskSearchView, ExpenseFlatSearchView, ExpenseGroupedSearchView, ExpenseReportSearchView), delete SearchList and BaseSearchList.

M3 — Selection consumer API + action relocation

Add useRowSelection, useSelectionCounts, useRowSelectionActions hooks over existing SearchContext. Relocate toggleTransaction into SearchActionsContext.

Sub-issues

Related code

Issue OwnerCurrent Issue Owner: @adhorodyski

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on May 29, 2026
  2. added and removed on May 29, 2026
  3. adhorodyski commented on Jun 11, 2026

    @adhorodyski
    Contributor

    @BartekObudzinski will take over this to help me deliver PRs starting with #92809 I opened recently.

  4. 12 remaining items

  5. melvin-bot commented on Jul 17, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @mountiny, @adhorodyski eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  6. melvin-bot commented on Sep 14, 2026

    @melvin-bot

    @mountiny, @adhorodyski, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions