You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-13] [$125] refactor: add dedicated ExpenseReportSearchView #95033
Expense-report search results (the Reports type, no group-by) still render through the legacy SearchList shell, which combines routing, layout, and type-specific rendering in one component. That makes the report view harder to maintain and blocks the search refactor from giving each search type its own dedicated view with focused responsibilities.
Solution
Add a dedicated ExpenseReportSearchView that composes the shared useSearchListViewState hook and SearchListViewLayout over BaseSearchList, matching the pattern used by ExpenseFlatSearchView. The router now dispatches the expense-report type to this view, which renders ExpenseReportListItem rows and tracks selection at the child-transaction level (flattening each report's transactions for counts, including empty reports). Report rows skip exit animation, consistent with the prior behavior for non-grouped expense types.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: N/A refactor
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Open the Search tab and run a search that returns expense reports (the Reports type, no group-by).
Verify the report rows render the same as before.
Click a row and verify it opens the report as before.
Select a few transactions across different reports and verify the selected count and the select-all state are correct (the count reflects transactions, not report rows).
Long press a report row and verify it behaves the same as before.
Switch to another search type (expenses, chats) and back, and verify each list still renders correctly.
Activity
[-]refactor: add dedicated ExpenseReportSearchView[/-][+][$125] refactor: add dedicated ExpenseReportSearchView[/+]melvin-bot commentedon Jul 1, 2026
5 remaining items
melvin-bot commentedon Jul 6, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)daledah commentedon Jul 9, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: N/A refactor
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/659152
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-b507-afee-fc85-6a4c0c9b2644melvin-bot commentedon Jul 9, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jul 12, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Jul 13, 2026
Payment Summary
Contributor+: @daledah due $125 via NewDot
^ Test case created. Thx
quinthar commentedon Aug 19, 2026
Approved $125 to @daledah