Skip to content

[Due for payment 2026-07-13] [$125] refactor: add dedicated ExpenseReportSearchView #95033

Closed

Description

@mountiny

Problem

Expense-report search results (the Reports type, no group-by) still render through the legacy SearchList shell, which combines routing, layout, and type-specific rendering in one component. That makes the report view harder to maintain and blocks the search refactor from giving each search type its own dedicated view with focused responsibilities.

Solution

Add a dedicated ExpenseReportSearchView that composes the shared useSearchListViewState hook and SearchListViewLayout over BaseSearchList, matching the pattern used by ExpenseFlatSearchView. The router now dispatches the expense-report type to this view, which renders ExpenseReportListItem rows and tracks selection at the child-transaction level (flattening each report's transactions for counts, including empty reports). Report rows skip exit animation, consistent with the prior behavior for non-grouped expense types.

PR

#94822

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. changed the title [-]refactor: add dedicated ExpenseReportSearchView[/-] [+][$125] refactor: add dedicated ExpenseReportSearchView[/+] on Jul 1, 2026
  2. melvin-bot commented on Jul 1, 2026

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  3. 5 remaining items

  4. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Jul 6, 2026
  5. melvin-bot commented on Jul 6, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  6. daledah commented on Jul 9, 2026

    @daledah
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: N/A refactor

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/659152

    Regression Test Proposal

    Test:

    1. Open the Search tab and run a search that returns expense reports (the Reports type, no group-by).
    2. Verify the report rows render the same as before.
    3. Click a row and verify it opens the report as before.
    4. Select a few transactions across different reports and verify the selected count and the select-all state are correct (the count reflects transactions, not report rows).
    5. Long press a report row and verify it behaves the same as before.
    6. Switch to another search type (expenses, chats) and back, and verify each list still renders correctly.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-b507-afee-fc85-6a4c0c9b2644
  7. melvin-bot commented on Jul 9, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  8. melvin-bot commented on Jul 12, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  9. mallenexpensify commented on Jul 13, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @daledah due $125 via NewDot

    ^ Test case created. Thx

  10. quinthar commented on Aug 19, 2026

    @quinthar
    Contributor

    Approved $125 to @daledah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions