Skip to content

[Due for payment 2026-07-16] [CFI] [$250] Add the global search bar to the spend page #92924

Closed

Description

@JS00001

Coming from https://github.com/Expensify/Expensify/issues/636268, lets make the following changes in this issue:

  1. Add the 🔍 icon to the top right of the Spend page (like the rest of the pages in the app). This will make it consistent across screens. This will act as the router for the search page.
  2. We need to make the following changes to the search bar on the 'spend' page:
  3. Turn the search bar into a keyword search only. This should maintain the current filters, and search type that are currently applied, but update the keyword: filter
  4. Clicking the X in the keyword search input re-executes the search minus the keywords, but leaves the rest of the filters of the current search in place. (That way, it doesn’t “jump” back to Spend > Expenses every time as the default, but does clear whatever keyword filtering on the table you did).
Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @Ollyws

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 8, 2026
  2. melvin-bot commented on Jun 8, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  3. melvin-bot commented on Jun 8, 2026

    @melvin-bot
  4. changed the title [-]Add the global search bar to the spend page[/-] [+][$250] Add the global search bar to the spend page[/+] on Jun 8, 2026
  5. godzillaxbox19982014-lgtm commented on Jun 8, 2026

    @godzillaxbox19982014-lgtm
  6. trasnake87 commented on Jun 8, 2026

    @trasnake87
  7. innolope-dev commented on Jun 8, 2026

    @innolope-dev
  8. KJ21-ENG commented on Jun 8, 2026

    @KJ21-ENG
  9. github-actions commented on Jun 8, 2026

    @github-actions
  10. 49 remaining items

  11. melvin-bot commented on Jul 2, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. melvin-bot commented on Jul 2, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/2063968232784055750/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. bernhardoj commented on Jul 3, 2026

    @bernhardoj
    Contributor

    Oh, I think the checklist should be handled by @aimane-chnaif as the C+ of the PR.

  14. aimane-chnaif commented on Jul 3, 2026

    @aimane-chnaif
    Contributor
  15. mallenexpensify commented on Jul 6, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @bernhardoj due $250 via NewDot
    Contributor+: @aimane-chnaif due $250 via NewDot

    @aimane-chnaif plz complete the BZ checklist and tag me in a post once you have. Thx

  16. aimane-chnaif commented on Jul 7, 2026

    @aimane-chnaif
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: new feature

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/657035

    Regression Test Proposal

    Test:

    1. Go to Spend
    2. Press the search input and search for anything
    3. Verify it applies a keyword filter
    4. Press the Filters button > Keyword
    5. Verify that the keyword on the search input is shown in the Keyword filter
    6. Enter anything in the Keyword filter
    7. Verify the new value is reflected in the search input
    8. Press "X" button on the search input
    9. Verify the input is cleared, and the keyword filter is removed

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-d6e3-a024-d04f-d1ba95f0f914
  17. flaviadefaria commented on Jul 7, 2026

    @flaviadefaria
    Contributor

    Approved: @bernhardoj due $250 via NewDot

  18. changed the title [-][Due for payment 2026-07-03] [CFI] [$250] Add the global search bar to the spend page[/-] [+][Due for payment 2026-07-16] [CFI] [$250] Add the global search bar to the spend page[/+] on Jul 9, 2026
  19. melvin-bot commented on Jul 9, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  20. melvin-bot commented on Jul 9, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.31-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-16. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Ollyws requires payment through NewDot Manual Requests
    • @bernhardoj requires payment through NewDot Manual Requests
  21. garrettmknight commented on Jul 19, 2026

    @garrettmknight
    Contributor

    $250 apprvoed for @aimane-chnaif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions