Skip to content

Spend - Search suggestions do not appear in Spend #94649

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.4.20-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/62116517/folder/13176922/41237514/1519051255?sort=%2Bidentifier
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Mac 15.4.1 Safari, Chrome
App Component: Search

Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Navigate to to Spend
  3. Click on the search row
  4. Start typing type:

Expected Result:

Search suggestions should appear

Actual Result:

Search suggestions do not appear in Spend

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7191491_1782430329841.Recording__2462.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7191491

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 26, 2026
  2. applause-bot commented on Jun 26, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/48479bd90ff1a6a29b1aa4b655074d65d35de79140474e9741484b96923437e1

  3. melvin-bot commented on Jun 26, 2026

    @melvin-bot

    Triggered auto assignment to @JS00001 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jun 26, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 26, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 26, 2026

    @MelvinBot
    Contributor

    Issue Analysis

    Root Cause: This is an intended behavior change, not a code bug. Expensify/App#93543 — "Rework search input to be a keyword search only" (by bernhardoj, merged 2026-06-25, first shipped in v9.4.20-0) — deliberately replaced the Spend page's old autocomplete-capable search input with a plain keyword-only TextInput. Typing type: (or any filter) in the Spend search bar no longer surfaces inline autocomplete suggestions by design. That matches the symptom: reproducible in staging (where #93543 is live) but not production (where it isn't yet).

    The PR deleted the inputs that rendered the suggestion list (SearchPageInputWide.tsx, SearchPageInputNarrow.tsx, useSearchPageInput.tsx) and replaced them with SearchPageInput.tsx, a bare TextInput whose only actions are onChangeText (local state) and onSubmitEditing → navigate to SEARCH_ROOT. There is no SearchAutocompleteList mounted. The PR's own QA steps confirm the intent: "Press the search input and search for anything → Verify it applies a keyword filter" — no mention of suggestions. Autocomplete moved to the global search router (🔍 / Cmd+K), per the parent issue Expensify/App#92924.

    This is a product decision, not a code fix. The regression TC (BrowserStack run) expects the old inline-suggestion behavior, which #93543 intentionally removed. Two paths forward:

    1. Accept as designed (likely correct): the Spend bar is now keyword-only and autocomplete lives behind the 🔍 search router. Update/retire the regression TC and clear the deploy blocker.
    2. Treat as a regression: if inline type: suggestions on the Spend bar were meant to be preserved, restore the autocomplete input or revert Rework search input to be a keyword search only #93543.

    The author bernhardoj and the #92924 / #92923 stakeholders should make this call. Given it's a deliberate, reviewed design change shipped intentionally, option 1 is most likely — this looks like a TC that needs updating to the new design rather than a true bug.

    Investigation details

    Regressing PR: Expensify/App#93543, merge commit 93f7d05a346, confirmed an ancestor of the v9.4.20-0 build HEAD (ee1091df).

    Diff (93f7d05a346^1..93f7d05a346 --stat):

    • SearchPageInput.tsx +89 (new bare keyword input)
    • SearchPageInputNarrow.tsx −94 (deleted — rendered autocomplete)
    • SearchPageInputWide.tsx −115 (deleted — imported SearchAutocompleteList, kept isAutocompleteListVisible, showed list on focus)
    • useSearchPageInput.tsx −234 (deleted — autocomplete query state)

    Where the search row renders the new input: SearchActionsBarWide.tsx:36 and SearchPageNarrow/index.tsx:36.

    Autocomplete still works elsewhere — it's mounted only in the SearchRouter (SearchRouter.tsx:488-498), opened via the 🔍 SearchButton in the top bar (TopBar.tsx:80). The suggestion engine (useAutocompleteSuggestions.ts) is unchanged — the Spend keyword input simply never mounts it.

    Alternative considered & ruled out: PR #92938 (native-only autocomplete perf change) — no effect on web/desktop, where this was reproduced (Mac Chrome/Safari). #93543 directly and fully explains the symptom.

    Confidence: High on the cause and regressing PR. The only open question is the product decision (accept keyword-only vs. restore suggestions), which is not a code ambiguity.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94649) to create a draft PR (only if you decide inline suggestions should be restored).
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's analysis (e.g. confirm this is working-as-designed and the TC should be updated).

  7. bernhardoj commented on Jun 26, 2026

    @bernhardoj
    Contributor

    This is expected because the search input is a keyword-only filter. Anything you type is a keyword.

  8. JS00001 commented on Jun 26, 2026

    @JS00001
    Contributor

    agreed!

  9. trjExpensify commented on Jun 26, 2026

    @trjExpensify
    Contributor

    Yeah, @gleitebr @m-natarajan we'll need to update applicable test cases here once this gets to prod. The parent issue for this is here, so we can discuss there if needs be: #92924

  10. m-natarajan commented on Jun 26, 2026

    @m-natarajan

    @trjExpensify Will work on updating the test case. Could you please create a test case update issue for reference?

  11. trjExpensify commented on Jun 29, 2026

    @trjExpensify
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions