Skip to content

[Due for payment 2026-06-24] [Due for payment 2026-06-23] Workflow - Different level of opacity seen on workflows fields after inviting member offline #93637

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.8-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #80449
Email or phone of affected tester (no customers): ibellicotest+2766@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11 / Chrome
App Component: Workspace Settings

Action Performed:

Prerequisite: User is owner of "Control" workspace.
Prerequisite 2: Approvals enabled.

  1. Open the staging.new.expensify.com website.
  2. Navigate to "Workspaces" > Workspace > "Workflows"
  3. Turn off internet connection.
  4. Scroll down to "Approvals" and click on "Add Approval workflow"
  5. On expenses from, enter Email of an existing user that is not member of workspace > "Next" > "Invite"
  6. Select the same member as approver > "Skip" > "Add Workflow"
  7. Once redirected to "Workflows" again, note that "Expenses From" and "Approver" fields, display different levels of reduced opacity.

Expected Result:

After inviting a new member while offline, during "Add approval workflow" process and selecting it as "Approver", the "Expenses From" and "Approver" fields, should display the same level of reduced opacity.

Actual Result:

After inviting a new member while offline during "Add approval workflow" process, and selecting it as "Approver", the "Expenses From" and "Approver" fields, display different levels of reduced opacity.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7181579_1781551135587.Invite_Workflow_5.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7181579

Activity

  1. applause-bot commented on Jun 15, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/90cd437c6812eaf7b48f6ba745646a492e787af6748172da213a2073e1c44202

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 15, 2026
  3. melvin-bot commented on Jun 15, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #80449

  4. melvin-bot commented on Jun 15, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 15, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 15, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    After inviting a new member while offline during the Add approval workflow flow and selecting that member as the Approver, the Expenses from and Approver fields render at different opacity levels. They should be dimmed consistently since both reference the same pending (offline-invited) member.

    What is the root cause of that problem?

    The two fields are wrapped asymmetrically in ApprovalWorkflowEditor.tsx:

    • Each Approver row is individually wrapped in OfflineWithFeedback with pendingAction={getApprovalPendingAction(approverIndex)}, so it dims when the underlying member is pending.
    • The Expenses from MenuItemWithTopDescription is not wrapped in OfflineWithFeedback at all, so it stays at full opacity.

    When a member is invited offline and added to the workflow, the optimistic update sets pendingFields.submitsTo on that member. The first approver row picks this up via getApprovalPendingAction (index 0 returns member.pendingFields?.submitsTo) and dims. The Expenses from field references the same member but has no wrapper, so only the Approver dims → the visible opacity mismatch.

    This asymmetry pre-dates PR #80449, but that PR is what newly allows inviting a member during this flow, so it first becomes reproducible now (hence "doesn't exist in prod").

    Supporting evidence
    • Members carry only pendingFields (no top-level pendingAction): ApprovalWorkflow.ts:101 and WorkflowUtils.ts buildMemberFromEmployee.
    • UserPills / UserPill apply no per-member pending opacity (UserPills.tsx), confirming the Expenses from field has no dimming source of its own.
    • Alternative considered: that the pills dim independently — ruled out by the above; the only dimming source is the OfflineWithFeedback wrapper, which Expenses from lacks.

    What changes do you think we should make in order to solve the problem?

    Wrap the Expenses from MenuItemWithTopDescription (lines 166-181) in an OfflineWithFeedback, passing a pendingAction derived from the workflow members' pending state — i.e. the first non-null member.pendingFields?.submitsTo, the same value getApprovalPendingAction(0) already computes for the members branch (lines 70-76).

    To keep it DRY, factor that members-pending lookup into a small helper (or useMemo) and reuse it both in the new Expenses from wrapper and inside getApprovalPendingAction. Both fields will then dim together whenever the shared member is pending.

    Confidence: Medium-High — root cause is directly visible in code (asymmetric wrapping); the exact pending value was reasoned from the optimistic-update path rather than confirmed against a live repro.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/93637) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  8. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. 3 remaining items

  11. IuliiaHerets commented on Jun 16, 2026

    @IuliiaHerets

    Chrome / v9.4.8-2
    Passed

    REC-20260616190531.mp4
  12. puneetlath commented on Jun 16, 2026

    @puneetlath
    Contributor

    Great!

  13. changed the title [-]Workflow - Different level of opacity seen on workflows fields after inviting member offline[/-] [+][Due for payment 2026-06-23] Workflow - Different level of opacity seen on workflows fields after inviting member offline[/+] on Jun 16, 2026
  14. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.8-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-23. 🎊

  16. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    @youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  17. changed the title [-][Due for payment 2026-06-23] Workflow - Different level of opacity seen on workflows fields after inviting member offline[/-] [+][Due for payment 2026-06-24] [Due for payment 2026-06-23] Workflow - Different level of opacity seen on workflows fields after inviting member offline[/+] on Jun 17, 2026
  18. melvin-bot commented on Jun 17, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.9-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-24. 🎊

  19. melvin-bot commented on Jun 17, 2026

    @melvin-bot

    @youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions