You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-24] [Due for payment 2026-06-23] Workflow - Different level of opacity seen on workflows fields after inviting member offline #93637
Version Number: 9.4.8-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#80449 Email or phone of affected tester (no customers):ibellicotest+2766@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Windows 11 / Chrome App Component: Workspace Settings
Action Performed:
Prerequisite: User is owner of "Control" workspace.
Prerequisite 2: Approvals enabled.
Open the staging.new.expensify.com website.
Navigate to "Workspaces" > Workspace > "Workflows"
Turn off internet connection.
Scroll down to "Approvals" and click on "Add Approval workflow"
On expenses from, enter Email of an existing user that is not member of workspace > "Next" > "Invite"
Select the same member as approver > "Skip" > "Add Workflow"
Once redirected to "Workflows" again, note that "Expenses From" and "Approver" fields, display different levels of reduced opacity.
Expected Result:
After inviting a new member while offline, during "Add approval workflow" process and selecting it as "Approver", the "Expenses From" and "Approver" fields, should display the same level of reduced opacity.
Actual Result:
After inviting a new member while offline during "Add approval workflow" process, and selecting it as "Approver", the "Expenses From" and "Approver" fields, display different levels of reduced opacity.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
After inviting a new member while offline during the Add approval workflow flow and selecting that member as the Approver, the Expenses from and Approver fields render at different opacity levels. They should be dimmed consistently since both reference the same pending (offline-invited) member.
Each Approver row is individually wrapped in OfflineWithFeedback with pendingAction={getApprovalPendingAction(approverIndex)}, so it dims when the underlying member is pending.
The Expenses fromMenuItemWithTopDescription is not wrapped in OfflineWithFeedback at all, so it stays at full opacity.
When a member is invited offline and added to the workflow, the optimistic update sets pendingFields.submitsTo on that member. The first approver row picks this up via getApprovalPendingAction (index 0 returns member.pendingFields?.submitsTo) and dims. The Expenses from field references the same member but has no wrapper, so only the Approver dims → the visible opacity mismatch.
This asymmetry pre-dates PR #80449, but that PR is what newly allows inviting a member during this flow, so it first becomes reproducible now (hence "doesn't exist in prod").
UserPills / UserPill apply no per-member pending opacity (UserPills.tsx), confirming the Expenses from field has no dimming source of its own.
Alternative considered: that the pills dim independently — ruled out by the above; the only dimming source is the OfflineWithFeedback wrapper, which Expenses from lacks.
What changes do you think we should make in order to solve the problem?
Wrap the Expenses fromMenuItemWithTopDescription (lines 166-181) in an OfflineWithFeedback, passing a pendingAction derived from the workflow members' pending state — i.e. the first non-null member.pendingFields?.submitsTo, the same value getApprovalPendingAction(0) already computes for the members branch (lines 70-76).
To keep it DRY, factor that members-pending lookup into a small helper (or useMemo) and reuse it both in the new Expenses from wrapper and inside getApprovalPendingAction. Both fields will then dim together whenever the shared member is pending.
Confidence: Medium-High — root cause is directly visible in code (asymmetric wrapping); the exact pending value was reasoned from the optimistic-update path rather than confirmed against a live repro.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/93637) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Workflow - Different level of opacity seen on workflows fields after inviting member offline[/-][+][Due for payment 2026-06-23] Workflow - Different level of opacity seen on workflows fields after inviting member offline[/+]on Jun 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.8-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
changed the title [-][Due for payment 2026-06-23] Workflow - Different level of opacity seen on workflows fields after inviting member offline[/-][+][Due for payment 2026-06-24] [Due for payment 2026-06-23] Workflow - Different level of opacity seen on workflows fields after inviting member offline[/+]on Jun 17, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.9-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 15, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/90cd437c6812eaf7b48f6ba745646a492e787af6748172da213a2073e1c44202
melvin-bot commentedon Jun 15, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #80449
melvin-bot commentedon Jun 15, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 15, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 15, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
After inviting a new member while offline during the Add approval workflow flow and selecting that member as the Approver, the Expenses from and Approver fields render at different opacity levels. They should be dimmed consistently since both reference the same pending (offline-invited) member.
What is the root cause of that problem?
The two fields are wrapped asymmetrically in
ApprovalWorkflowEditor.tsx:OfflineWithFeedbackwithpendingAction={getApprovalPendingAction(approverIndex)}, so it dims when the underlying member is pending.MenuItemWithTopDescriptionis not wrapped inOfflineWithFeedbackat all, so it stays at full opacity.When a member is invited offline and added to the workflow, the optimistic update sets
pendingFields.submitsToon that member. The first approver row picks this up viagetApprovalPendingAction(index 0 returnsmember.pendingFields?.submitsTo) and dims. The Expenses from field references the same member but has no wrapper, so only the Approver dims → the visible opacity mismatch.This asymmetry pre-dates PR #80449, but that PR is what newly allows inviting a member during this flow, so it first becomes reproducible now (hence "doesn't exist in prod").
Supporting evidence
pendingFields(no top-levelpendingAction):ApprovalWorkflow.ts:101andWorkflowUtils.ts buildMemberFromEmployee.UserPills/UserPillapply no per-member pending opacity (UserPills.tsx), confirming the Expenses from field has no dimming source of its own.OfflineWithFeedbackwrapper, which Expenses from lacks.What changes do you think we should make in order to solve the problem?
Wrap the Expenses from
MenuItemWithTopDescription(lines 166-181) in anOfflineWithFeedback, passing apendingActionderived from the workflow members' pending state — i.e. the first non-nullmember.pendingFields?.submitsTo, the same valuegetApprovalPendingAction(0)already computes for the members branch (lines 70-76).To keep it DRY, factor that members-pending lookup into a small helper (or
useMemo) and reuse it both in the new Expenses from wrapper and insidegetApprovalPendingAction. Both fields will then dim together whenever the shared member is pending.Confidence: Medium-High — root cause is directly visible in code (asymmetric wrapping); the exact pending value was reasoned from the optimistic-update path rather than confirmed against a live repro.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/93637)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
melvin-bot commentedon Jun 16, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Jun 16, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Jun 16, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
3 remaining items
IuliiaHerets commentedon Jun 16, 2026
Chrome / v9.4.8-2
Passed
REC-20260616190531.mp4
puneetlath commentedon Jun 16, 2026
Great!
[-]Workflow - Different level of opacity seen on workflows fields after inviting member offline[/-][+][Due for payment 2026-06-23] Workflow - Different level of opacity seen on workflows fields after inviting member offline[/+]melvin-bot commentedon Jun 16, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.8-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-23. 🎊
melvin-bot commentedon Jun 16, 2026
@youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[-][Due for payment 2026-06-23] Workflow - Different level of opacity seen on workflows fields after inviting member offline[/-][+][Due for payment 2026-06-24] [Due for payment 2026-06-23] Workflow - Different level of opacity seen on workflows fields after inviting member offline[/+]melvin-bot commentedon Jun 17, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.9-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-24. 🎊
melvin-bot commentedon Jun 17, 2026
@youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]