Skip to content

Add support for dynamic routes that host an onyx tab navigator #94476

Closed

Description

@MelvinBot

Part of the Replacing backTo / forwardTo with Dynamic URL Navigation - Release 2 project.

Problem

Dynamic route resolution does not currently handle routes that host a tab navigator. When a URL ends with a trailing tab segment (e.g. /some-dynamic-route/tabName), the dynamic suffix matching fails to account for the tab segment, so the route can't be resolved correctly. Additionally, getPathFromState does not serialize screens that contain a nested Onyx tab navigator, so the generated URL omits the active tab segment.

Solution

Extend dynamic route resolution to support routes that host an Onyx tab navigator:

  • findAllMatchingDynamicSuffixes strips the trailing tab segment and retries matching, returning pathUsedForMatching so getMatchingFullScreenRoute strips the suffix from the correct path.
  • collectScreensWithTabNavigator is refactored to also build a dynamicTabPatternToTabPaths map used for this lookup.
  • getPathFromState is updated to correctly serialize screens that contain a nested Onyx tab navigator, so the generated URL includes the active tab segment.

Linked PR

Implemented in #94172.

Issue OwnerCurrent Issue Owner: @collectioneur

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Jun 24, 2026
  2. changed the title [-][Dynamic URL Navigation] Add support for dynamic routes that host an onyx tab navigator[/-] [+][Due for payment 2026-07-13] [Dynamic URL Navigation] Add support for dynamic routes that host an onyx tab navigator[/+] on Jul 6, 2026
  3. melvin-bot commented on Jul 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.27-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-13. 🎊

    For reference, here are some details about the assignees on this issue:

  4. melvin-bot commented on Jul 9, 2026

    @melvin-bot

    @collectioneur Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. melvin-bot commented on Jul 13, 2026

    @melvin-bot

    @collectioneur 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  6. changed the title [-][Due for payment 2026-07-13] [Dynamic URL Navigation] Add support for dynamic routes that host an onyx tab navigator[/-] [+]Add support for dynamic routes that host an onyx tab navigator[/+] on Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions