Repository navigation
[No QA] Add support for dynamic routes that host an onyx tab navigator - #94172
Conversation
|
LGTM! |
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@MelvinBot create an issue for this, add it as a sub-issue to #83358 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8292d87047
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
|
@MelvinBot please assign me to this PR as a reviewer. |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-06-29.at.15.21.35.mov |
|
@mjasikowski all yours 😄 |
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.27-1 🚀
|
|
🤖 I reviewed the changes in this PR against Expensify's help site files under No help site changes are required. This PR is purely internal navigation infrastructure — it extends dynamic route resolution to handle URLs that host an Onyx tab navigator ( There is no user-facing behavior, UI, copy, feature name, tab, setting, or button introduced or renamed here — nothing that the public help site documents. Help site articles cover product workflows and user-facing behavior, not internal deeplink/route-resolution plumbing, so there is nothing to add or update. No draft PR was created. @huult, please confirm you agree that no help site updates are needed for this change. If you believe a user-facing behavior did change and should be documented, let me know the specifics and I'll create the draft PR. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Extends dynamic route resolution to handle routes that host a tab navigator. When a URL ends with a trailing tab segment (e.g.
/some-dynamic-route/tabName),findAllMatchingDynamicSuffixesnow strips the tab segment and retries matching, returningpathUsedForMatchingsogetMatchingFullScreenRoutestrips the suffix from the correct path.collectScreensWithTabNavigatoris refactored to also build adynamicTabPatternToTabPathsmap used for this lookup.getPathFromStateis also updated to correctly serialize screens that contain a nested Onyx tab navigator, so the generated URL includes the active tab segment.Fixed Issues
$ #94476
Tests
No QA
Offline tests
N/A
QA Steps
No QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari