Skip to content

[Due for payment 2026-07-08] Members - Members are not sorted alphabetically by Role #94645

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.20-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #91746
Email or phone of affected tester (no customers): applausetester+khcategory19@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Workspace has members of all types of roles (card admin, auditor, etc).
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Members.
  3. Click Role on the table header.

Expected Result:

Members will be sorted alphabetically by Role.

Actual Result:

Members are not sorted alphabetically by Role.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7191468_1782427493428.4.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7191468

Activity

  1. applause-bot commented on Jun 25, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/a544db9328fabcd9a5351074df307d267e82d926fdcc845d58b4afca7a1ac719

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 25, 2026
  3. melvin-bot commented on Jun 25, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #91746

  4. melvin-bot commented on Jun 25, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 25, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 25, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Clicking the Role column header in Workspace Settings > Members does not sort members alphabetically by the role shown in the table.

    What is the root cause of that problem?

    The Role column's sort compares the raw role enum (item.role — e.g. admin, auditor, user, cardAdmin), but each row displays a localized label (Workspace Admin, Auditor, Member, Card Admin) produced by translate('workspace.common.roleName', item.role). The enum strings sort in a different order than their display labels, so the visible rows look unsorted.

    For example, ascending: enum sorts admin first, but its label Workspace Admin should sort last; enum sorts user last, but its label Member should sort in the middle.

    This was introduced by #91746 (deploy blocker).

    Evidence

    What changes do you think we should make in order to solve the problem?

    In the 'role' branch of compareTableItems (index.tsx:119-127), compare the translated label instead of the raw enum, mirroring what the row renders:

    if (activeSorting.columnKey === 'role') {
        if (!item1.role) {
            return 1;
        }
        if (!item2.role) {
            return -1;
        }
        return localeCompare(
            translate('workspace.common.roleName', item1.role),
            translate('workspace.common.roleName', item2.role),
        ) * orderMultiplier;
    }

    translate is already in scope via useLocalize() at index.tsx:69. This makes the sort key match the visible text, so the Role header sorts alphabetically by the displayed role label.

    Note: If the product intent is a semantic role hierarchy (Owner > Admin > …) rather than pure alphabetical, the fix would instead map each role to an explicit rank. But the issue's Expected Result is "sorted alphabetically by Role", which the change above delivers.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94645) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. JS00001 commented on Jun 26, 2026

    @JS00001
    Contributor

    Going to demote, this is not really a blocker

  8. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 26, 2026
  9. 1 remaining item

  10. changed the title [-]Members - Members are not sorted alphabetically by Role[/-] [+][Due for payment 2026-07-08] Members - Members are not sorted alphabetically by Role[/+] on Jul 1, 2026
  11. melvin-bot commented on Jul 1, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jul 1, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.25-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-08. 🎊

  13. melvin-bot commented on Jul 1, 2026

    @melvin-bot

    @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  14. JS00001 commented on Jul 2, 2026

    @JS00001
    Contributor

    PR is merged, was reviewed by the same c+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions