You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-08] Members - Members are not sorted alphabetically by Role #94645
Version Number: 9.4.20-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#91746 Email or phone of affected tester (no customers):applausetester+khcategory19@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Workspace has members of all types of roles (card admin, auditor, etc).
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
Clicking the Role column header in Workspace Settings > Members does not sort members alphabetically by the role shown in the table.
What is the root cause of that problem?
The Role column's sort compares the raw role enum (item.role — e.g. admin, auditor, user, cardAdmin), but each row displays a localized label (Workspace Admin, Auditor, Member, Card Admin) produced by translate('workspace.common.roleName', item.role). The enum strings sort in a different order than their display labels, so the visible rows look unsorted.
For example, ascending: enum sorts admin first, but its label Workspace Admin should sort last; enum sorts user last, but its label Member should sort in the middle.
translate is already in scope via useLocalize() at index.tsx:69. This makes the sort key match the visible text, so the Role header sorts alphabetically by the displayed role label.
Note: If the product intent is a semantic role hierarchy (Owner > Admin > …) rather than pure alphabetical, the fix would instead map each role to an explicit rank. But the issue's Expected Result is "sorted alphabetically by Role", which the change above delivers.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/94645) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Members - Members are not sorted alphabetically by Role[/-][+][Due for payment 2026-07-08] Members - Members are not sorted alphabetically by Role[/+]on Jul 1, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.25-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 25, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/a544db9328fabcd9a5351074df307d267e82d926fdcc845d58b4afca7a1ac719
melvin-bot commentedon Jun 25, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #91746
melvin-bot commentedon Jun 25, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 25, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 25, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Clicking the Role column header in Workspace Settings > Members does not sort members alphabetically by the role shown in the table.
What is the root cause of that problem?
The Role column's sort compares the raw role enum (
item.role— e.g.admin,auditor,user,cardAdmin), but each row displays a localized label (Workspace Admin,Auditor,Member,Card Admin) produced bytranslate('workspace.common.roleName', item.role). The enum strings sort in a different order than their display labels, so the visible rows look unsorted.For example, ascending: enum sorts
adminfirst, but its labelWorkspace Adminshould sort last; enum sortsuserlast, but its labelMembershould sort in the middle.This was introduced by #91746 (deploy blocker).
Evidence
WorkspaceMembersTable/index.tsx:119-127→localeCompare(item1.role, item2.role)WorkspaceMembersTableRow.tsx:42→const roleLabel = translate('workspace.common.roleName', item.role)item.name, the exact value displayed —index.tsx:115-117What changes do you think we should make in order to solve the problem?
In the
'role'branch ofcompareTableItems(index.tsx:119-127), compare the translated label instead of the raw enum, mirroring what the row renders:translateis already in scope viauseLocalize()atindex.tsx:69. This makes the sort key match the visible text, so the Role header sorts alphabetically by the displayed role label.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/94645)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
JS00001 commentedon Jun 26, 2026
Going to demote, this is not really a blocker
1 remaining item
[-]Members - Members are not sorted alphabetically by Role[/-][+][Due for payment 2026-07-08] Members - Members are not sorted alphabetically by Role[/+]melvin-bot commentedon Jul 1, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 1, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.25-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-08. 🎊
melvin-bot commentedon Jul 1, 2026
@JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
JS00001 commentedon Jul 2, 2026
PR is merged, was reviewed by the same c+