Repository navigation
Update the workspace members table to the new style - #91746
Conversation
… into jsenyitko-more-table-updates
… into jsenyitko-more-table-updates
… into jsenyitko-more-table-updates
… into jsenyitko-more-table-updates
… into jsenyitko-more-table-updates
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@luacmartins back to you |
|
@JS00001 we got a bunch of conflicts now |
|
@JS00001 TS and jest are failing |
|
Updated! |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.20-0 🚀
|
|
🤖 I reviewed this PR against Expensify's help site files under Why: This PR is a UI-only refactor that migrates the workspace members table to the new
There's no new feature, setting, or workflow change. The help articles that cover workspace member management (inviting members, roles, permissions, etc.) describe behavior that is unchanged by this PR, so none of them need to be updated. @JS00001, if you believe a documented behavior did change here and warrants a help site update, let me know and I'll create the draft PR. |
|
Deploy Blocker #94645 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.20-1 🚀
Bundle Size Analysis (Sentry): |
| ref={ref} | ||
| innerStyles={[isExpanded && styles.buttonHoveredBG, {maxWidth: 256}, innerStyles, shouldShowCloseButton && styles.pr2]} | ||
| style={styles.flexShrink1} | ||
| innerStyles={[isExpanded && styles.buttonHoveredBG, {maxWidth: 256}, styles.mw100, styles.flexShrink1, innerStyles, shouldShowCloseButton && styles.pr2]} |
Explanation of Change
Update the workspace members table to use the new Table component
Fixed Issues
$ #86205
Tests
Test the typical flows of the members table. This is just a UI update, so all features should still work the same
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Screen.Recording.2026-06-12.at.12.48.29.PM.mov