Skip to content

feat: Make the Domain member group filter list multi-select - #94122

Merged
youssef-lr merged 22 commits into
Expensify:mainfrom
samranahm:90637/members-filter-multi-select-v2
Jul 31, 2026
Merged

youssef-lr merged 22 commits into
Expensify:mainfrom
samranahm:90637/members-filter-multi-select-v2

Conversation

@samranahm

@samranahm samranahm commented Jun 20, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Add multi-select filters Domain members (group), tp replace single-select dropdowns so users can filter by multiple groups at once.

Fixed Issues

$ #90637
PROPOSAL: #90637 (comment)

Tests

Precondition:

  • Admin create a workspace and invite some members, admins and auditors and make some members approvers.
  • Set up a private domain in Expensify and invite members using email addresses associated with that domain.

Test 01

  1. Open the Workspaces tab and switch to “Domains” tab and select verified domain.
  2. Open the “Domain Members” page and verify that all members associated with the domain are listed along with their groups (for example: Employees, Managers).
  3. Verify that the "Filters" button is displayed.
  4. Open the filter and verify that all available groups are displayed, and that there is no “Members” or “All members” option.
  5. Select multiple group filters, click “Apply”, and verify that only members matching the selected groups are displayed.
  6. Select a single group filter (e.g., Managers), click “Apply”, and verify that only members belonging to that group are displayed and that the button text changes to Group: Managers.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android.native.mp4
Android: mWeb Chrome
Android.mWeb.Chrome.mp4
iOS: Native
IOS.Native.mp4
iOS: mWeb Safari
IOS.mWeb.Safari.mp4
MacOS: Chrome / Safari
macOS.Chrome.mp4

@samranahm
samranahm requested review from a team as code owners June 20, 2026 19:48
@melvin-bot
melvin-bot Bot requested review from eh2077 and heyjennahay June 20, 2026 19:48
@melvin-bot

melvin-bot Bot commented Jun 20, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@melvin-bot
melvin-bot Bot removed request for a team June 20, 2026 19:48
@melvin-bot

melvin-bot Bot commented Jun 20, 2026

Copy link
Copy Markdown

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@samranahm samranahm changed the title 90637/members filter multi select v2 feat: Make the Workspace and Domain member filter list multi-select, and update All members to Members (V2) Jun 20, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e59f3778be

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@codecov

codecov Bot commented Jun 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/hooks/useDomainGroupFilter.ts 100.00% <100.00%> (ø)
src/components/Tables/DomainMembersTable/index.tsx 0.00% <0.00%> (ø)
... and 79 files with indirect coverage changes

@samranahm

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a0bb1f045

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@samranahm

Copy link
Copy Markdown
Contributor Author

@eh2077 PR is ready for review. Please take a look when you have a moment.

@samranahm

Copy link
Copy Markdown
Contributor Author

@eh2077 Gentle bump.

@eh2077

eh2077 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@samranahm #91746 was merged, can you resolve conflicts? Search filter moved to left and role filter moved to right.

@samranahm

Copy link
Copy Markdown
Contributor Author

Found a bug & reported it in slack channel here

@samranahm

Copy link
Copy Markdown
Contributor Author

Retesting

@samranahm

Copy link
Copy Markdown
Contributor Author

@eh2077 PR ready for another review, I also updated the video to show latest design.

@samranahm

Copy link
Copy Markdown
Contributor Author

@eh2077 Gentle bump.

@eh2077

eh2077 commented Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

NA, check #94122 (comment)

Android: mWeb Chrome

NA, check #94122 (comment)

iOS: HybridApp
Screen.Recording.2026-07-27.at.9.52.14.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-07-27.at.9.52.42.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-27.at.9.53.54.PM.mov

@eh2077

eh2077 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@samranahm could you invite me ericwdev001+d3@gmail.com to your WS? so I can test domain filter, thx!

@samranahm

samranahm commented Jul 24, 2026 •

Copy link
Copy Markdown
Contributor Author

@eh2077 workspace invite wouldn't work for testing domain members page, you can use this account eric@tempnest.me, let me know when you request OTP while login.

@eh2077 eh2077 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain member filter works well, @samranahm thanks for your help!

WS member filter already supported by the other PR, so I think we should update QA step for testing domain member filter only, wdyt?

@samranahm

Copy link
Copy Markdown
Contributor Author

Yup! sounds good, updating the title and test steps.

@samranahm samranahm changed the title feat: Make the Workspace and Domain member filter list multi-select, and update All members to Members (V2) feat: Make the Domain member filter list multi-select Jul 27, 2026
@samranahm samranahm changed the title feat: Make the Domain member filter list multi-select feat: Make the Domain member group filter list multi-select Jul 27, 2026
@samranahm

Copy link
Copy Markdown
Contributor Author

Merging main to fix flaky test.

@eh2077 eh2077 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well!

@melvin-bot
melvin-bot Bot requested a review from youssef-lr July 27, 2026 15:43
@youssef-lr

Copy link
Copy Markdown
Contributor

Let's address the AI comments

@samranahm

Copy link
Copy Markdown
Contributor Author

@youssef-lr Done! I've addressed the AI comments.

@eh2077

eh2077 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

works well with latest changes

Screen.Recording.2026-07-28.at.4.11.08.PM.mov

@eh2077

eh2077 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@youssef-lr gentle bump, could you help merge it?

@youssef-lr
youssef-lr merged commit bc348fd into Expensify:main Jul 31, 2026
33 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 youssef-lr has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94122.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-bc348fd9584-f4bc660-5d09b2b412e4adeab7970f489bde808e478f11bc/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-bc348fd-f4bc660-6bed3d5f8f5c0077ac53a2d927eae7c0fab3487c/index.html
Android iOS
Web 🕸️
❌ FAILED ❌
The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Aug 1, 2026
60 tasks done
@OSBotify

OSBotify commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.4.48-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review — no docs changes required

I reviewed this PR against the help site under App/docs/articles and no help-site updates are required.

What this PR changes: The Domain Members group filter goes from single-select to multi-select (users can now filter the member list by multiple groups at once), plus the filter options are now sorted alphabetically.

Why no docs change is needed:

  • The Domain Members group filter isn't documented anywhere in the help site today. I searched both the New Expensify and Classic domain articles — Manage-Domain-Members.md and Domain-Members.md — and neither mentions filtering the members list by group.
  • The existing article covers member-management workflows (inviting, closing/deactivating, promoting to Domain Admin, and moving members between groups). This PR doesn't change any of those documented workflows — it only refines an undocumented list-filtering control.

Since this is a UI refinement to a feature the help site doesn't describe, there's nothing to add or correct, so I did not open a draft docs PR.

@samranahm — if you'd like the group-filter behavior documented as a new addition to the Domain Members article (rather than just reflecting this single→multi change), let me know and I can draft that. Otherwise, no help-site action is needed here.

@OSBotify

OSBotify commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.48-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants