Repository navigation
feat: Make the Domain member group filter list multi-select - #94122
Conversation
… for role filtering
…rsFilterButton for group filtering
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e59f3778be
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…eSelectedGroups and effectiveSelectedRoleFilters
…n useDomainGroupFilter
…ed components for group and role filtering in domain and workspace member pages.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a0bb1f045
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@eh2077 PR is ready for review. Please take a look when you have a moment. |
|
@eh2077 Gentle bump. |
|
@samranahm #91746 was merged, can you resolve conflicts? Search filter moved to left and role filter moved to right. |
|
Found a bug & reported it in slack channel here |
|
Retesting |
|
@eh2077 PR ready for another review, I also updated the video to show latest design. |
|
@eh2077 Gentle bump. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppNA, check #94122 (comment) Android: mWeb ChromeNA, check #94122 (comment) iOS: HybridAppScreen.Recording.2026-07-27.at.9.52.14.PM.moviOS: mWeb SafariScreen.Recording.2026-07-27.at.9.52.42.PM.movMacOS: Chrome / SafariScreen.Recording.2026-07-27.at.9.53.54.PM.mov |
|
@samranahm could you invite me |
|
@eh2077 workspace invite wouldn't work for testing domain members page, you can use this account |
eh2077
left a comment
There was a problem hiding this comment.
domain member filter works well, @samranahm thanks for your help!
WS member filter already supported by the other PR, so I think we should update QA step for testing domain member filter only, wdyt?
|
Yup! sounds good, updating the title and test steps. |
|
Merging main to fix flaky test. |
|
Let's address the AI comments |
|
@youssef-lr Done! I've addressed the AI comments. |
|
works well with latest changes Screen.Recording.2026-07-28.at.4.11.08.PM.mov |
|
@youssef-lr gentle bump, could you help merge it? |
|
🚧 youssef-lr has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.4.48-0 🚀
|
Help site review — no docs changes requiredI reviewed this PR against the help site under What this PR changes: The Domain Members group filter goes from single-select to multi-select (users can now filter the member list by multiple groups at once), plus the filter options are now sorted alphabetically. Why no docs change is needed:
Since this is a UI refinement to a feature the help site doesn't describe, there's nothing to add or correct, so I did not open a draft docs PR. @samranahm — if you'd like the group-filter behavior documented as a new addition to the Domain Members article (rather than just reflecting this single→multi change), let me know and I can draft that. Otherwise, no help-site action is needed here. |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.48-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Add multi-select filters Domain members (group), tp replace single-select dropdowns so users can filter by multiple groups at once.
Fixed Issues
$ #90637
PROPOSAL: #90637 (comment)
Tests
Precondition:
Test 01
Group: Managers.Offline tests
QA Steps
Same as tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.native.mp4
Android: mWeb Chrome
Android.mWeb.Chrome.mp4
iOS: Native
IOS.Native.mp4
iOS: mWeb Safari
IOS.mWeb.Safari.mp4
MacOS: Chrome / Safari
macOS.Chrome.mp4