Skip to content

Missing Concierge AI promo modal animation after resizing screen and navigating to next page #95856

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.33-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #94012
Email or phone of affected tester (no customers): jsodinjsodjdsiodjsonj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with new account.
  3. Refresh the page.
  4. When Concierge AI promo modal shows up, resize screen to small.
  5. Click Next button.

Expected Result:

Promo modal animation will be shown after resizing screen and navigating to next page.

Actual Result:

Promo modal animation is missing after resizing screen and navigating to next page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7204915_1783703705820.4.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7204915

Issue OwnerCurrent Issue Owner: @gijoe0295

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 10, 2026
  2. applause-bot commented on Jul 10, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/e9794fe2ed8317edd52e69e150a07b7a98c18c1dfdf2146605ee2346f95a9c7c

  3. melvin-bot commented on Jul 10, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #94012

  4. melvin-bot commented on Jul 10, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jul 10, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jul 10, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    Regression from #94012. That PR changed Lottie from always autoplaying to a gated autoPlay={props.autoPlay && !isReduceMotionEnabled} (Lottie/index.tsx:139). In the carousel, non‑focused pages pass autoPlay={isMobile() || isFocused} = false on web, so those animations do not autoplay — they rely entirely on an imperative .play() call from an effect in the illustration component.

    That effect's dependency array is stale:

    useEffect(() => {
        if (isMobile() || !isCarousel || !animationRef.current || isReduceMotionEnabled) return;
        if (isFocused) { animationRef.current.play(); }
        else { animationRef.current.pause(); }
    }, [isFocused, isCarousel, isReduceMotionEnabled]);

    FeatureTrainingContentIllustration.tsx:86-95

    When you resize the window, the carousel recomputes carouselViewportWidth and re‑renders every page (FeatureTrainingCarousel.tsx:168-242). This remounts the underlying LottieView (new width + its internal key), swapping animationRef.current to a fresh, paused instance (autoPlay=false for the still‑unfocused next page). The play/pause effect does not re‑run because isFocused/isCarousel/isReduceMotionEnabled didn't change — so the newly mounted LottieView is never told to play. When you click Next, that page shows a blank/static frame.

    What changes do you think we should make in order to solve the problem?

    Make the imperative start resilient to remounts instead of relying on the stale effect. Replace the plain ref={animationRef} on the Lottie at FeatureTrainingContentIllustration.tsx:155 with a callback ref that stores the instance and, if the page is currently focused (isFocused && !isMobile() && isCarousel && !isReduceMotionEnabled), calls .play() immediately. That guarantees a freshly‑remounted LottieView (after a resize) starts playing regardless of whether the effect re‑fires.

    Do not simply revert the autoPlay gate at Lottie/index.tsx:139 back to always‑true — that reintroduces the resource issue #94012 was solving (all off‑screen carousel Lotties autoplaying at once). Keep the gate; just reliably (re)start the visible page.

    What alternative solutions did you explore? (Optional)

    Add carouselViewportWidth (or another remount signal) to the effect's dependency array so it re‑runs after a resize. This works but is more fragile than a callback ref, since it still depends on animationRef.current being populated at the moment the effect runs.

    Investigation details & confidence

    Confidence: High — code evidence traces the full chain (resize → width state change → LottieView remount → new paused ref → stale effect never calls .play()).

    One edge case worth a quick browser check: Lottie renders an empty View fallback while hasNavigatedAway/splash‑screen gating is active (Lottie/index.tsx:108-122). If that fallback is showing at the moment of the Next‑click, animationRef.current is null and the effect early‑returns, which would make the blank persist — the callback‑ref fix also covers this case.

    Files involved:


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/95856) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. ShridharGoel commented on Jul 10, 2026

    @ShridharGoel
    Contributor

    Shouldn't be a blocker I think

  8. jponikarchuk commented on Jul 10, 2026

    @jponikarchuk

    Deploy Blocker #95869 was identified to be related to the PR #94012 that attempted to fix this issue.

  9. 9 remaining items

  10. melvin-bot commented on Jul 24, 2026

    @melvin-bot

    @tgolen @gijoe0295 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  11. melvin-bot commented on Jul 24, 2026

    @melvin-bot

    @gijoe0295 10 days overdue. Is anyone even seeing these? Hello?

  12. melvin-bot commented on Jul 29, 2026

    @melvin-bot

    This issue has not been updated in over 14 days. @tgolen, @gijoe0295 eroding to Weekly issue.

  13. melvin-bot commented on Sep 4, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @tgolen, @gijoe0295 eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  14. gijoe0295 commented on Sep 5, 2026

    @gijoe0295
    Contributor

    This is done. Please close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringMonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions