Skip to content

Second and third Concierge AI promo modal navigate to first modal when refresh page #95869

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.33-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #94012
Email or phone of affected tester (no customers): gocemate+buzz1851@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: windows 10/chrome
App Component: Other

Action Performed:

    1. Go to staging.new.expensify.com
  1. Log in with new account.
  2. Refresh the page.
  3. When Concierge AI promo modal shows up click Next to navigate to second modal
  4. Refresh the page

Expected Result:

Second modal should be displayed after refreshing the page, just like onboarding modal

Actual Result:

First modal is displayed after refresh

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7205000_1783709372864.Recording__1104.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7205000

Issue OwnerCurrent Issue Owner: @ShridharGoel

Activity

  1. applause-bot commented on Jul 10, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/6dd508d9c759bbf2100bda5556abf378d3b93b43e428e91ad63af4b955965d34

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 10, 2026
  3. melvin-bot commented on Jul 10, 2026

    @melvin-bot

    Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jul 10, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jul 10, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jul 10, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The Concierge AI promo modal is a multi-page carousel. After clicking Next to advance to page 2 (or 3) and then refreshing the browser, the modal reopens on page 1 instead of the page the user was on.

    What is the root cause of that problem?

    The carousel's current page is held only in ephemeral React local state — const [currentPage, setCurrentPage] = useState(0) in FeatureTrainingCarousel. Clicking Next just scrolls the internal FlatList and updates that state; the step is never written to the route or to Onyx.

    The whole modal is a single route/screen — AIFeaturesPromoModalNavigator renders the entire carousel behind one DYNAMIC_ROOT screen — so the URL is identical on every page.

    On refresh, AIFeaturesPromoModal remounts, currentPage re-initializes to 0, and the modal is re-shown from the top (the re-open path in useAIFeaturesPromoModal navigates to the same single route, which always starts at page 0). The onboarding modal the tester compares against survives refresh because its steps are backed by persisted state, not transient carousel state.

    What changes do you think we should make in order to solve the problem?

    Persist the active carousel step so it can be restored on remount. Concretely:

    1. Add an initialPage prop to FeatureTrainingCarousel and use it to seed useState and the initial scrollToIndex.
    2. Persist the step when it changes via the existing onPageChange callback (already wired at FeatureTrainingCarousel.tsx:113) into a store that survives refresh — either an Onyx key or a route param on the dynamic route — and feed it back in as initialPage.
    3. Clear the persisted step when the modal is dismissed so a fresh open starts at page 1.
    Alternatives considered
    • Accept as working-as-designed and simply not treat it as a blocker — the modal is a low-stakes one-time promo, and a refresh mid-promo is an edge case. Worth a product call given it's a DeployBlockerCash.
    • Fastest unblock: revert #94012 "Concierge AI Feature Promo Modal v2" (merged 2026-07-10, the version this reproduces on), which introduced this feature, then re-land with step persistence.
    • Split each page into its own route (like onboarding). Cleaner conceptually but a much larger change than the promo warrants.

    Related issues (same feature/carousel)

    Both share the same carousel component; a fix here should be verified against them.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/95869) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. Gonals commented on Jul 13, 2026

    @Gonals
    Contributor

    Assigning dev and reviewers from the causing PR.
    I don't think we nee d to clock on this, but I'll leave it to you

  8. removed their assignment
    on Jul 13, 2026
  9. gijoe0295 commented on Jul 13, 2026

    @gijoe0295
    Contributor

    Yeah I don't think this is an issue. This is a simple promo modal so we don't save user's progress.

  10. tgolen commented on Jul 13, 2026

    @tgolen
    Contributor

    Closing as "works as intended"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions