You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-28] Home - Empty For You section is only hidden after creating a workspace #95865
Version Number: 9.4.33-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#94698 Email or phone of affected tester (no customers):oijnsodjosjdojoijsid@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Other
Action Performed:
Go to staging.new.expensify.com
Create a new Gmail account.
Complete onboarding with Something else intent.
Go to Home.
→ For You section is shown when it is empty.
Create a workspace.
Go to Home.
→ Empty For You section is only hidden after creating a workspace.
Expected Result:
In Step 4, Empty For You section will be hidden when there is no workspace.
Actual Result:
In Step 4, For You section is shown when it is empty when there is no workspace.
In Stpe 6, Empty For You section is only hidden after creating a workspace.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug (App repo) Causing PR: #94698 - "[Home Page] Getting Started - Hide empty for you" by @adamgrzybowski (High confidence) Related Issues: N/A
Recommendation: ROLL FORWARD
The bug is an isolated logic error in the brand-new shouldHideForYouSection decision function introduced by #94698; a small targeted fix (correctly handling a completed-onboarding new user who has no free-trial NVP yet) is simpler and lower risk than reverting the whole feature. REVERT is a clean fallback since the feature is self-contained in the ForYouSection module.
Assigned: @adamgrzybowski (PR author), @ZhenjaHorbach and @grgia (approving reviewers) from #94698 Labels: No changes. Kept DeployBlockerCash (App deploy is correctly blocked for a frontend bug). No DeployBlocker label was present. Note: DeployBlockerCash must stay because there is an App PR that caused this.
The issue states this is a new feature that doesn't exist in production — the "hide empty For You section" feature was introduced entirely by [Home Page] Getting Started - Hide empty for you #94698, so the bug can only originate there.
[Home Page] Getting Started - Hide empty for you #94698 created the file that owns the exact buggy behavior: src/pages/home/ForYouSection/shouldHideForYouSection.ts, and merged 2026-07-09, immediately before the bug was reported on staging 9.4.33.
Verification
Affected file: src/pages/home/ForYouSection/shouldHideForYouSection.ts (decision logic) and its consumer src/pages/home/ForYouSection/index.tsx.
Confirmed [Home Page] Getting Started - Hide empty for you #94698's changed-files list includes both shouldHideForYouSection.ts and ForYouSection/index.tsx, plus the accompanying test tests/unit/pages/home/ForYouSection/shouldHideForYouSectionTest.ts.
The test file explicitly encodes the faulty assumption — it('keeps the section when the trial start date is missing') asserts firstDayFreeTrial: undefined → returns false (show).
Root Cause
Tracing shouldHideForYouSection for the exact repro (new Gmail user, onboarding completed with "Something else", no workspace, no to-dos, not initial load):
hasAnyTodos || hasSeenTodo → false (empty), skip
isOnboardingCompleted === false → false (onboarding is complete), skip
isInitialLoad → false, skip
!firstDayFreeTrial → true, so it return false → section is shown even though empty ← BUG
nvp_private_firstDayFreeTrial is the workspace owner's free-trial start date. A brand-new user with no workspace has no free trial, so the NVP is undefined. The code treats a missing trial date as "old user, keep the section visible," but a completed-onboarding new user with no workspace should be treated as a new user and have the empty section hidden.
This also explains the second half of the report: after the user creates a workspace, the backend sets nvp_private_firstDayFreeTrial to the current date (on/after the 2026-06-26 cutoff), so the function reaches the final branch trialStartMs >= cutoffMs → returns true → the empty section is correctly hidden.
Suggested roll-forward fix: in the "no trial date" branch, do not unconditionally show the section for users who have completed onboarding but have no free-trial NVP yet (i.e., new users without a workspace) — treat them as new users so the empty section stays hidden until they have an actionable to-do.
Please re-state the problem that we are trying to solve in this issue.
A newly onboarded user (e.g. "Something else" intent, no workspace yet) sees the empty "For You" section on Home. It should stay hidden for new users until they have a real to-do. Oddly, it only becomes hidden after the user creates a workspace.
What is the root cause of that problem?
shouldHideForYouSection uses the free-trial start date (nvp_private_firstDayFreeTrial) as its "new vs. old user" discriminator, but that NVP is only set when a workspace is created, not at account creation or onboarding.
For a user who just finished onboarding with no workspace:
This exactly explains the "hidden only after creating a workspace" symptom: creating a workspace sets firstDayFreeTrial to the current date (Policy.ts:5941-5945), which is >= FOR_YOU_NEW_USER_CUTOFF_DATE (2026-06-26), so the final date check returns true and hides it.
The function's own doc comment names only two "new user" cases — "still onboarding, or free-trial start on/after the cutoff" — and misses the gap: onboarding complete but no workspace/free-trial yet. The !firstDayFreeTrial fallback assumes "no trial ⇒ old user", which is wrong for a brand-new account.
What changes do you think we should make in order to solve the problem?
The !firstDayFreeTrial branch needs a way to tell a genuinely new NewDot account (no trial yet) apart from an old/migrated account. The natural signal is the onboarding record itself: old/migrated accounts have an empty onboarding NVP (selector treats empty as "old"), whereas a NewDot-onboarded user has a non-empty record.
Pass a new-user signal (e.g. isNewDotOnboardedUser = onboarding NVP is a non-empty object) into shouldHideForYouSection, and change the fallback so that when firstDayFreeTrial is undefined it hides for new NewDot accounts and keeps showing for old/migrated accounts:
if(!firstDayFreeTrial){returnisNewDotOnboardedUser;// hide for new users, show for old/migrated}
Set firstDayFreeTrial at account creation — too broad; that NVP drives billing/free-trial logic across SubscriptionUtils and shouldn't be repurposed.
Use account creation date if a reliable NVP exists — viable, but the onboarding-record signal is already loaded here and directly matches the existing new/old split.
Confidence & verification
High confidence. Code trace is complete and accounts for every step of the reproduction, including why the section flips to hidden after workspace creation. Root cause is fully within Expensify/App (frontend logic in shouldHideForYouSection.ts), introduced by #94698.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/95865) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.40-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
melvin-bot commentedon Jul 10, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #94698
melvin-bot commentedon Jul 10, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 10, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jul 10, 2026
🔍 Investigation Summary
Classification: Frontend bug (App repo)
Causing PR: #94698 - "[Home Page] Getting Started - Hide empty for you" by @adamgrzybowski (High confidence)
Related Issues: N/A
Recommendation: ROLL FORWARD
The bug is an isolated logic error in the brand-new
shouldHideForYouSectiondecision function introduced by #94698; a small targeted fix (correctly handling a completed-onboarding new user who has no free-trial NVP yet) is simpler and lower risk than reverting the whole feature. REVERT is a clean fallback since the feature is self-contained in theForYouSectionmodule.Assigned: @adamgrzybowski (PR author), @ZhenjaHorbach and @grgia (approving reviewers) from #94698
Labels: No changes. Kept
DeployBlockerCash(App deploy is correctly blocked for a frontend bug). NoDeployBlockerlabel was present. Note:DeployBlockerCashmust stay because there is an App PR that caused this.📋 Detailed Analysis
Evidence
src/pages/home/ForYouSection/shouldHideForYouSection.ts, and merged 2026-07-09, immediately before the bug was reported on staging 9.4.33.Verification
src/pages/home/ForYouSection/shouldHideForYouSection.ts(decision logic) and its consumersrc/pages/home/ForYouSection/index.tsx.shouldHideForYouSection.tsandForYouSection/index.tsx, plus the accompanying testtests/unit/pages/home/ForYouSection/shouldHideForYouSectionTest.ts.it('keeps the section when the trial start date is missing')assertsfirstDayFreeTrial: undefined→ returnsfalse(show).Root Cause
Tracing
shouldHideForYouSectionfor the exact repro (new Gmail user, onboarding completed with "Something else", no workspace, no to-dos, not initial load):hasAnyTodos || hasSeenTodo→ false (empty), skipisOnboardingCompleted === false→ false (onboarding is complete), skipisInitialLoad→ false, skip!firstDayFreeTrial→ true, so itreturn false→ section is shown even though empty ← BUGnvp_private_firstDayFreeTrialis the workspace owner's free-trial start date. A brand-new user with no workspace has no free trial, so the NVP isundefined. The code treats a missing trial date as "old user, keep the section visible," but a completed-onboarding new user with no workspace should be treated as a new user and have the empty section hidden.This also explains the second half of the report: after the user creates a workspace, the backend sets
nvp_private_firstDayFreeTrialto the current date (on/after the2026-06-26cutoff), so the function reaches the final branchtrialStartMs >= cutoffMs→ returnstrue→ the empty section is correctly hidden.Suggested roll-forward fix: in the "no trial date" branch, do not unconditionally show the section for users who have completed onboarding but have no free-trial NVP yet (i.e., new users without a workspace) — treat them as new users so the empty section stays hidden until they have an actionable to-do.
MelvinBot commentedon Jul 10, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
A newly onboarded user (e.g. "Something else" intent, no workspace yet) sees the empty "For You" section on Home. It should stay hidden for new users until they have a real to-do. Oddly, it only becomes hidden after the user creates a workspace.
What is the root cause of that problem?
shouldHideForYouSectionuses the free-trial start date (nvp_private_firstDayFreeTrial) as its "new vs. old user" discriminator, but that NVP is only set when a workspace is created, not at account creation or onboarding.For a user who just finished onboarding with no workspace:
hasAnyTodos/hasSeenTodo→false(skip)isOnboardingCompleted === false→false, they completed onboarding, so this new-user branch is skipped (selector returnstrueoncehasCompletedGuidedSetupFlowis set)isInitialLoad→false(skip)firstDayFreeTrialis undefined → hitsif (!firstDayFreeTrial) return false;→ section is shown. ❌This exactly explains the "hidden only after creating a workspace" symptom: creating a workspace sets
firstDayFreeTrialto the current date (Policy.ts:5941-5945), which is>= FOR_YOU_NEW_USER_CUTOFF_DATE(2026-06-26), so the final date check returnstrueand hides it.The function's own doc comment names only two "new user" cases — "still onboarding, or free-trial start on/after the cutoff" — and misses the gap: onboarding complete but no workspace/free-trial yet. The
!firstDayFreeTrialfallback assumes "no trial ⇒ old user", which is wrong for a brand-new account.What changes do you think we should make in order to solve the problem?
The
!firstDayFreeTrialbranch needs a way to tell a genuinely new NewDot account (no trial yet) apart from an old/migrated account. The natural signal is the onboarding record itself: old/migrated accounts have an empty onboarding NVP (selector treats empty as "old"), whereas a NewDot-onboarded user has a non-empty record.Pass a new-user signal (e.g.
isNewDotOnboardedUser= onboarding NVP is a non-empty object) intoshouldHideForYouSection, and change the fallback so that whenfirstDayFreeTrialis undefined it hides for new NewDot accounts and keeps showing for old/migrated accounts:The signal is available in
ForYouSection/index.tsx(already readsNVP_ONBOARDING). Add unit coverage inshouldHideForYouSectionTest.tsfor the "onboarding complete, no free trial" case.What alternative solutions did you explore?
firstDayFreeTrialat account creation — too broad; that NVP drives billing/free-trial logic acrossSubscriptionUtilsand shouldn't be repurposed.Confidence & verification
High confidence. Code trace is complete and accounts for every step of the reproduction, including why the section flips to hidden after workspace creation. Root cause is fully within
Expensify/App(frontend logic inshouldHideForYouSection.ts), introduced by #94698.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/95865)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
flaviadefaria commentedon Jul 13, 2026
I don't think this needs to be a deploy blocker, but @adamgrzybowski @ZhenjaHorbach, let's fix it as soon as we can.
12 remaining items
melvin-bot commentedon Jul 21, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 21, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.40-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 21, 2026
@ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Jul 24, 2026
@ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
ZhenjaHorbach commentedon Jul 27, 2026
@grgia
Let's close this!
melvin-bot commentedon Jul 27, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Jul 27, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)