Repository navigation
[Home Page] Empty For You section is only hidden after creating a workspace - #95969
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-07-14.14.42.47.movAndroid: mWeb Chrome2026-07-14.14.37.36.moviOS: HybridApp2026-07-14.14.42.47.moviOS: mWeb Safari2026-07-14.14.37.36.movMacOS: Chrome / Safari2026-07-14.14.35.24.mov |
|
@grgia Let's merge this |
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.4.36-0 🚀
|
|
🤖 I reviewed this change against the help site articles under Conclusion: no help site changes are required — no draft PR created. This PR is an internal visibility-logic bug fix (the deploy blocker in #95865). It changes when an empty For you section is hidden — NewDot-onboarded accounts with no workspace now have the empty section hidden, while old/migrated accounts keep it — but it does not change any documented, user-facing capability of the feature. The one article that covers this feature, @adamgrzybowski, please confirm you agree no help site update is needed here. If you'd like the "For you" article to explicitly call out that a brand-new account won't see the section until it has a to-do, let me know and I'll open a draft PR for that copy. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.4.38-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site files under Conclusion: No help site changes are required. I did not create a draft PR. WhyThis PR is a client-side deploy-blocker fix for the internal logic that decides whether the empty For you section on Home is hidden vs. shown empty. It falls back to the onboarding NVP so newly onboarded users with no workspace (and therefore no free-trial date) are correctly treated as new and the empty section is hidden. It does not add, rename, or remove any user-facing feature, section, button, or workflow. I checked the two articles that cover this area:
Both describe the For you section conceptually — it surfaces items needing your attention and "may appear empty" when you're caught up. That description remains accurate. The new-vs-old-user detail this PR corrects is a transitional, onboarding-era implementation detail that the help articles were never meant to document, and surfacing it would only confuse readers. If you'd like the articles to explicitly explain when the empty section is hidden vs. shown for new users, let me know and I'll draft the doc updates. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.4.40-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site files under No help site changes are required. This PR is an internal bug fix that changes when the empty For you section is hidden on Home — falling back to the onboarding NVP so newly onboarded users with no workspace don't see an empty section, while old/migrated accounts keep it. This is a nuanced client-side detection change (free-trial date vs. onboarding origin); it doesn't rename a feature, tab, setting, or button, and the new-vs-migrated distinction isn't user-facing terminology. The two existing articles that cover this section already describe the behavior accurately:
The "may appear empty" phrasing already covers both outcomes (shown-but-empty for old/migrated accounts, hidden for new accounts), so no wording is contradicted by this change. Documenting the underlying account-type signal would add internal detail that isn't meaningful to end users. Because no help site changes are needed, I haven't opened a docs draft PR. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.40-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #95865
PROPOSAL:
Tests
Offline tests
Same as Tests.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-13.at.16.55.07.mov