You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Spend - Hotel label missing for receipt-type:hotel filter #96724
Version Number: v9.4.42-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#96553 Email or phone of affected tester (no customers):sintayewhaylu01@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: web App Component: Other
changed the title [-]spend -Hotel label missing for receipt-type:hotel filter[/-][+]Spend - Hotel label missing for receipt-type:hotel filter[/+]on Jul 22, 2026
This is a regression from #96553 ("Hide hotel from the receipt type search filter"). That PR intended for a manually-typed receipt-type:hotel to still render its Hotel label (see its own test step 7), but it broke exactly that.
The Receipt type filter's option list is built from SELECTABLE_RECEIPT_TYPES (ereceipt, itemized only), which no longer contains hotel:
SearchUIUtils.ts:5616-5620 — getMultiSelectFilterOptions now maps over SELECTABLE_RECEIPT_TYPES, so it emits no hotel option.
FilterComponents/index.tsx:74 — the multi-select derives its selected labels by intersecting the current value with those options: items.filter((item) => value.includes(item.value)). Since hotel isn't in items, an active hotel selection resolves to an empty label — nothing shows.
The parse and query-chip paths are unaffected (hotel is still a valid parsed value at SearchQueryUtils.ts:1230-1236 and still translates via SearchUIUtils.ts:5476-5477), which is why the query still submits — only the filter selection list drops the label.
What changes do you think we should make in order to solve the problem?
Make the Receipt type option list hide hotel only as a new choice, while still surfacing it when it is already part of the current selection. In getMultiSelectFilterOptions, pass in the current filter value and, for RECEIPT_TYPE, build options from the union of SELECTABLE_RECEIPT_TYPES and any already-selected values (so hotel appears with its label when active, but isn't offered otherwise). This satisfies the original PR's intent (hidden from suggestions/picker, but its label still renders when applied).
Alternative considered
Reverting the option-list change would bring hotel back as a freely-selectable option, which contradicts the goal of #96553 (hotel has no backend data yet). The union approach keeps hotel un-selectable while preserving its label for manually-entered queries.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/96724) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
🚨 Edited by proposal-police: This proposal was edited at 2026-07-22 09:34:25 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
After manually typing receipt-type:hotel in the search bar and submitting, opening the Receipt type filter shows only eReceipt and Itemized — the applied Hotel value is not rendered as a selected item in the list, so there is no way to see or remove it.
What is the root cause of that problem?
PR #96553 hid hotel from the receipt-type picker by trimming the picker's option source to SELECTABLE_RECEIPT_TYPES (['ereceipt', 'itemized']). The problem is that this same option array is used to render the currently-selected rows, not just the values offered for a new selection.
getMultiSelectFilterOptions now returns only the selectable types for RECEIPT_TYPE:
MultiSelectFilterComponents resolves the selected rows by filtering that same array, and MultiSelect builds its visible list exclusively from items (a value that isn't in items never becomes a row):
functionMultiSelectFilterComponents({filterKey, value =[], type =CONST.SEARCH.DATA_TYPES.EXPENSE, selectionListStyle, footer, onChange}: MultiSelectFilterComponentsProps){
So a hand-typed receipt-type:hotel parses, validates and is stored in the form (hotel is still in the full CONST.SEARCH.RECEIPT_TYPE enum and in VALID_RECEIPT_TYPES), yet it has no row to render in the picker because it was removed from the options array. Notably the label path outside the picker still works — getDisplayValue labels the value directly through getReceiptTypeTranslationKey, which is why the results-header filter chip does show "Hotel":
The regression is that PR #96553 conflated "values offered for a new selection" with "values rendered for the current selection". Hiding hotel from the former also hid it from the latter, which contradicts the PR's own stated intent that "typing receipt-type:hotel still parses, validates and renders its label".
What changes do you think we should make in order to solve the problem?
Keep hotel out of the pickable set, but let the picker also surface any value that is already applied — the offered options should be the selectable set unioned with the current selection.
In getMultiSelectFilterOptions (src/libs/SearchUIUtils.ts), accept the current selection and, for RECEIPT_TYPE, offer the selectable types plus any already-selected value from the full enum:
functiongetMultiSelectFilterOptions(filterKey: SearchAdvancedFiltersKey,type: SearchDataTypes,translate: LocalizedTranslate,selectedValues: string[]=[]){// ...if(filterKey===FILTER_KEYS.RECEIPT_TYPE){constavailableReceiptTypes=newSet<string>(CONST.SEARCH.SELECTABLE_RECEIPT_TYPES);// Keep any already-applied value (e.g. a hand-typed `receipt-type:hotel`) in the list so its label// renders and it can be deselected, without offering it for a fresh selection.selectedValues.forEach((value)=>availableReceiptTypes.add(value));returnObject.values(CONST.SEARCH.RECEIPT_TYPE).filter((receiptType)=>availableReceiptTypes.has(receiptType)).map((receiptType)=>({text: translate(getReceiptTypeTranslationKey(receiptType)),value: receiptType}));}// ...}
Then pass the current value from MultiSelectFilterComponents (src/components/Search/FilterComponents/index.tsx):
Iterating Object.values(CONST.SEARCH.RECEIPT_TYPE) and filtering keeps the original enum ordering. When nothing is selected, the result is unchanged (eReceipt, Itemized only), so the picker and autocomplete stay clean for fresh selections; when receipt-type:hotel is applied, Hotel appears as a checked, labelled, removable row. Re-enabling hotel globally later is still just a revert of PR #96553.
What specific test steps make sure that the issue is fixed?
Extend getMultiSelectFilterOptions unit coverage (the PR only tested the no-selection case):
With no selection, getMultiSelectFilterOptions(RECEIPT_TYPE, ...) still excludes hotel.
With ['hotel'] passed as the current selection, the returned options include {value: 'hotel', text: 'Hotel'}, so the applied value renders and can be removed.
What alternative solutions did you explore? (Optional)
Fix it purely inside MultiSelectFilterComponents by appending hidden-but-selected values with a local label lookup. It works, but it duplicates the receipt-type → label mapping outside getMultiSelectFilterOptions and would have to be repeated for every filter that hides values, so I prefer keeping the single source of truth.
🚨 Edited by proposal-police: This proposal was edited at 2026-07-22 09:30:15 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
hotel is a valid backend value for the receipt-type search filter, but after manually typing receipt-type:hotel in the search bar and submitting, the receipt-type filter selection list shows only eReceipt and Itemized — no "Hotel" row and no checked selection is rendered, even though the query keeps the hotel value. The applied filter becomes invisible in the filter UI.
What is the root cause of that problem?
The regression comes from PR #96553 (commit ee3a4da78a2, "Hide hotel from the receipt type filter options"). It introduced SELECTABLE_RECEIPT_TYPES = ['ereceipt', 'itemized'] and switched getMultiSelectFilterOptions for RECEIPT_TYPE from Object.values(CONST.SEARCH.RECEIPT_TYPE) (which includes hotel) to that reduced list. A sibling change did the same for the search-bar autocomplete via RECEIPT_TYPE_FRIENDLY_VALUES in useAutocompleteSuggestions.ts. The stated intent (see the comment on the constant) is that hotel can't return results until historical receipts are backfilled, so it should not be offered. The autocomplete-suggestion half (step 3 of the repro) is therefore working as designed.
The problem is that hotel is still fully valid and parseable everywhere else. VALID_RECEIPT_TYPES in SearchQueryUtils is built from all of CONST.SEARCH.RECEIPT_TYPE, so buildFilterFormValuesFromQuery keeps a manually typed receipt-type:hotel in the advanced-filters form, and getReceiptTypeTranslationKey('hotel') still resolves to search.receiptTypeValues.hotel = "Hotel". So the value survives into the form and has a valid label, but the receipt-type selection list no longer has an option row for it. getMultiSelectFilterOptions now emits only two rows:
The symptom is produced in MultiSelectFilterComponents, where items come from getMultiSelectFilterOptions (no hotel) and the selected set is derived by intersecting with those same items — items.filter((item) => value.includes(item.value)) — which is empty when value is ['hotel'].
MultiSelect then builds its listData purely from items (items.map(... isSelected: !!selectedItems.find(...))), so any applied value that isn't in items has no row to render and no checkmark. The result is exactly the report: the Receipt type filter list shows eReceipt/Itemized unchecked and the applied Hotel value is silently dropped from view.
What changes do you think we should make in order to solve the problem?
Keep hotel out of new selection (autocomplete + default options), but still label it when it is already applied. The cleanest place is getMultiSelectFilterOptions: pass the current selected values in and, for RECEIPT_TYPE, union any applied-but-hidden valid value onto SELECTABLE_RECEIPT_TYPES before mapping to labels. It has a single production caller (MultiSelectFilterComponents), so widening the signature is safe.
Then call it with the current value in MultiSelectFilterComponents: getMultiSelectFilterOptions(filterKey, type, translate, value as string[]). This makes the "Hotel" row appear (checked) only because it was already in the query, so it renders and can be de-selected, while a fresh filter still never offers hotel. Autocomplete stays untouched, so step 3 of the repro remains correct.
What alternative solutions did you explore? (Optional)
Reverting getMultiSelectFilterOptions back to Object.values(CONST.SEARCH.RECEIPT_TYPE) and hiding hotel only in the autocomplete would fix the label, but it re-exposes hotel as a freely selectable option in the RHP filter list — precisely what PR #96553 set out to prevent — so it's the wrong trade-off.
When a user manually types receipt-type:hotel into the search bar and submits, the hotel value is parsed correctly by the search query parser. However, when the filter is rendered in the filter list above the results, the backend value (hotel) is never translated to its display text (e.g., "Hotel"). This happens because getFilterDisplayValue() in SearchQueryUtils.ts is missing a case for RECEIPT_TYPE, while the same function handles all other comparable filters like EXPENSE_TYPE, WITHDRAWAL_TYPE, PAID_STATUS, WITHDRAWAL_STATUS, etc.
The autocomplete suggestions for receipt-type: work correctly because they pull from CONST.SEARCH.RECEIPT_TYPE and explicitly call getReceiptTypeTranslationKey() to translate each backend value to display text. But once a value is manually entered and the search query is parsed, the display rendering path in getFilterDisplayValue() lacks the corresponding receipt-type translation logic.
The causal chain:
User types receipt-type:hotel into search bar
Search parser validates and accepts the filter (hotel is in CONST.SEARCH.RECEIPT_TYPE)
Search executes and populates results
When rendering the filter chip/label above results, the code calls getFilterDisplayValue() with filterName=receiptType and filterValue=hotel
getFilterDisplayValue() reaches line 1652 (the final return filterValue) without matching any case, so it returns the raw backend value hotel instead of the translated display text
What changes do you think we should make in order to solve the problem?
Add a case for RECEIPT_TYPE in getFilterDisplayValue() that translates backend values using getReceiptTypeTranslationKey().
1. Update getFilterDisplayValue() function — Add the receipt-type case right before the final return statement, using the same pattern as CARD_ID and BANK_ACCOUNT:
Insert this after line 1651 (after the EXPORTED_TO case) and before line 1652 (the final return).
Why this is safe:
The getReceiptTypeTranslationKey() function already safely handles all three receipt type backend values (ereceipt, itemized, hotel), returning the correct translation path for each. See src/libs/TransactionUtils/index.ts, lines 218-225.
The filter value is guaranteed to be one of CONST.SEARCH.RECEIPT_TYPE because the search parser only accepts valid values.
This mirrors the existing pattern used for other similar enum-like filters (CARD_ID, BANK_ACCOUNT, POLICY_ID, etc.), so it carries zero risk of introducing a new pattern.
The validation already happens at parse-time in buildFilterFormValuesFromQuery() at line 1231 of SearchQueryUtils.ts, so an invalid receipt type never reaches the display layer anyway.
Result: When a user manually enters receipt-type:hotel and submits, the filter chip will now display "Hotel" (the translated value) instead of the raw backend value "hotel", matching the autocomplete suggestions and fixing both the missing label and the search consistency.
What alternative solutions did you explore? (Optional)
Use getUserFriendlyValue() instead: This would require adding hotel to the SEARCH_USER_FRIENDLY_VALUES_MAP. However, the dedicated getReceiptTypeTranslationKey() function already exists and is purpose-built for this, so adding a new map entry would duplicate logic.
Translate at parse-time in buildFilterFormValuesFromQuery(): Would work, but that function is already complex and handles 20+ filter types; the display layer is the correct place for this transformation, and it's consistent with how the codebase handles other enum filters.
Please re-state the problem that we are trying to solve in this issue.
When a user manually types receipt-type:hotel into the search bar and submits it, the "Hotel" label/chip does not appear anywhere in the resulting filter list (e.g. in the Advanced Filters "Receipt type" picker), even though hotel is a valid, recognized receipt type value.
What is the root cause of that problem?
CONST.SEARCH.SELECTABLE_RECEIPT_TYPES intentionally only contains ereceipt and itemized (hotel receipts aren't backfilled with search data yet), and this same constant is reused to build the list of selectable options shown in the Receipt Type filter picker:
MultiSelectFilterComponents then determines which items are "selected" by intersecting the form's value (which does contain 'hotel', since VALID_RECEIPT_TYPES in SearchQueryUtils.ts is built from the full CONST.SEARCH.RECEIPT_TYPE enum and correctly keeps it in the form) against items. Because items never contains a hotel entry, Array.prototype.filter finds no match and nothing is rendered for it:
functionMultiSelectFilterComponents({filterKey, value =[], type =CONST.SEARCH.DATA_TYPES.EXPENSE, selectionListStyle, footer, onChange}: MultiSelectFilterComponentsProps){
So the value survives all the way into the form/query (it's a legitimate receipt type), but the picker UI silently drops it from display because it only knows about the "suggestable" subset of receipt types, not the full set of valid ones. This is purely a display bug in how selected-but-not-suggested values are reconciled with the options list — it's unrelated to the (intentional) exclusion of hotel from autocomplete suggestions.
What changes do you think we should make in order to solve the problem?
Keep hotel out of the suggested autocomplete/options list (that exclusion is intentional per the code comment), but make sure a value that is already selected/applied is still included as an item so it can render with its translated label. The cleanest way is to have getMultiSelectFilterOptions accept the currently selected values and union them into the generated items for the RECEIPT_TYPE case, instead of hard-limiting to SELECTABLE_RECEIPT_TYPES.
functionMultiSelectFilterComponents({filterKey, value =[], type =CONST.SEARCH.DATA_TYPES.EXPENSE, selectionListStyle, footer, onChange}: MultiSelectFilterComponentsProps){
Add an optional selectedValues parameter to getMultiSelectFilterOptions, and for the RECEIPT_TYPE branch, build the options list from the union of CONST.SEARCH.SELECTABLE_RECEIPT_TYPES and any already-selected values that are valid entries of CONST.SEARCH.RECEIPT_TYPE (so a manually-typed hotel still resolves to an item with its translated label), while all other filter keys keep their current behavior untouched:
With this change, typing receipt-type:hotel and submitting will still keep hotel out of the autocomplete suggestions (unchanged, since useAutocompleteSuggestions.ts reads CONST.SEARCH.SELECTABLE_RECEIPT_TYPES directly), but the Receipt Type filter list/picker will correctly render the "Hotel" chip using the existing search.receiptTypeValues.hotel translation, since getReceiptTypeTranslationKey already supports CONST.SEARCH.RECEIPT_TYPE.HOTEL.
🚨 Edited by proposal-police: This proposal was edited at 2026-07-22 09:30:31 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
receipt-type:hotel is still a valid, parseable filter value, but after manually typing and submitting it, the "Hotel" label never appears in the receipt-type filter list — and interacting with that filter silently deletes receipt-type:hotel from the query.
What is the root cause of that problem?
This is a regression from PR #96553 ("Hide hotel from the receipt type search filter"). Its intent was to hide hotel from the suggestions (backend has no isHotelReservation data backfilled yet), and its description explicitly assumed "Typing receipt-type:hotel still parses, validates and renders its label". That assumption is wrong, because the PR restricted the wrong layer:
The PR added SELECTABLE_RECEIPT_TYPES: ['ereceipt', 'itemized']:
A typed receipt-type:hotel survives every data step. The search parser keeps it (I ran it: {"left":"receiptType","right":"hotel"}), form validation accepts it against the full enum (VALID_RECEIPT_TYPES):
The structural cause: that function is not just the "suggestion" source — it is the single source of truth every receipt-type selection UI uses to render applied values. MultiSelectFilterComponents resolves the applied form value against those items, so hotel matches nothing and renders nowhere:
functionMultiSelectFilterComponents({filterKey, value =[], type =CONST.SEARCH.DATA_TYPES.EXPENSE, selectionListStyle, footer, onChange}: MultiSelectFilterComponentsProps){
Worse — silent data loss: the same component's onChange re-emits only checked listed items (lines 82–84), so opening the Receipt type filter and applying wipes receipt-type:hotel from the user's query without any user action on hotel.
Affected paths (all funnel into FilterComponents → getMultiSelectFilterOptions):
This explains every symptom: autocomplete no longer suggests hotel (intended, useAutocompleteSuggestions.ts#L75), the Hotel entry/label is missing from the filter list on both web and Android, and the label loss only exists on staging (production still has the pre-#96553 full option list; the backend is shared, so only this App change can explain the staging-only repro).
What changes do you think we should make in order to solve the problem?
Fix at the convergence point: teach getMultiSelectFilterOptions to include applied-but-unselectable values, so a manually-entered hotel filter renders (and survives apply) while hotel stays hidden whenever it is not already in the query:
functiongetMultiSelectFilterOptions(filterKey,type,translate,selectedValues: string[]=[]){
...
if(filterKey===FILTER_KEYS.RECEIPT_TYPE){constapplied=selectedValues.filter((v): v is ReceiptTypeValue=>VALID_RECEIPT_TYPES.has(v)&&!CONST.SEARCH.SELECTABLE_RECEIPT_TYPES.includes(v));return[...CONST.SEARCH.SELECTABLE_RECEIPT_TYPES, ...applied].map((receiptType)=>({text: translate(getReceiptTypeTranslationKey(receiptType)),value: receiptType}));}
and pass the applied value at the only call site (FilterComponents/index.tsx#L73): getMultiSelectFilterOptions(filterKey, type, translate, value as string[]). getReceiptTypeTranslationKey already maps hotel → search.receiptTypeValues.hotel ("Hotel"), so no copy changes are needed:
. Also update the unit test PR #96553 added in tests/unit/Search/SearchUIUtilsTest.ts (L11239) to cover the applied-hotel case. Regression safety: the new parameter is optional and empty in every no-selection render, so the picker, autocomplete, and all other multi-select filters behave exactly as today.
Why the simple fix fails: reverting the getMultiSelectFilterOptions hunk (or re-adding hotel to SELECTABLE_RECEIPT_TYPES) re-exposes Hotel as a suggestible/pickable option — exactly what #96553 intentionally removed until the backend backfill lands. And a display-only patch (special-casing the pill/label text) still leaves the popup's onChange emitting only listed values, so applying the Receipt type filter would keep silently deleting receipt-type:hotel from the query.
What alternative solutions did you explore? (Optional)
Revert #96553's SearchUIUtils hunk — restores the label but re-lists Hotel as pickable, defeating the PR's intent (see above).
Merge unmatched values into items inside MultiSelectFilterComponents — same behavior, but that component lacks per-filter-key translation knowledge; the mapping belongs in getMultiSelectFilterOptions, which already has translate and the key.
The regression was introduced when the receipt-type options were changed from all valid values to SELECTABLE_RECEIPT_TYPES so Hotel would not be suggested before historical receipts are backfilled:
However, MultiSelectFilterComponents also uses those selectable options to resolve the current filter value. It filters value against items, so a manually entered hotel value has no matching item and becomes an empty selection:
functionMultiSelectFilterComponents({filterKey, value =[], type =CONST.SEARCH.DATA_TYPES.EXPENSE, selectionListStyle, footer, onChange}: MultiSelectFilterComponentsProps){
What changes do you think we should make in order to solve the problem?
I think we should update getMultiSelectFilterOptions() to accept the current values and, for RECEIPT_TYPE, append any valid currently selected receipt types that are absent from SELECTABLE_RECEIPT_TYPES. MultiSelectFilterComponents should pass its current value into that function.
The receipt-type branch would build options from the union of SELECTABLE_RECEIPT_TYPES and valid selected values. Therefore, hotel appears as a selected Hotel row only when it came from the existing query, while an empty receipt-type filter continues to offer only eReceipt and Itemized.
I would add tests covering both cases:
No current value still excludes Hotel.
A current hotel value returns and renders the translated Hotel option.
This does not regress autocomplete because it continues to use SELECTABLE_RECEIPT_TYPES directly:
Other multi-select filters are unaffected because the selected-value augmentation is limited to RECEIPT_TYPE.
What alternative solutions did you explore? (Optional)
I considered restoring Object.values(CONST.SEARCH.RECEIPT_TYPE) unconditionally, but that would undo the intentional change and make Hotel selectable again for new searches. Preserving it only when already present in the query fixes the missing label without reintroducing that behavior.
⚠️ @KJ21-ENG Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
⚠️ @marufsharifi Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
⚠️ @askavyblr Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
Root cause confirmed: PR #96553 removed hotel from SELECTABLE_RECEIPT_TYPES (autocomplete/default options), but getMultiSelectFilterOptions() builds its option list only from that array. When a user manually types receipt-type:hotel, the value passes validation in SearchQueryUtils (VALID_RECEIPT_TYPES still includes it) but has no display entry → blank chip.
getMultiSelectFilterOptions(): for RECEIPT_TYPE, return union of SELECTABLE_RECEIPT_TYPES + any currently-applied values (currentValues param). Already-selected receipt types always resolve a label.
MultiSelectFilterComponents: pass value array to the option builder.
📣 @SupremeDreamZ! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Activity
applause-bot commentedon Jul 22, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/e7635b2f52161675a792a2dc8deb3e5fa97878ed1e44ff2bde3da8885515e5f0
[-]spend -Hotel label missing for receipt-type:hotel filter[/-][+]Spend - Hotel label missing for receipt-type:hotel filter[/+]MelvinBot commentedon Jul 22, 2026
Proposal
What is the root cause of that problem?
This is a regression from #96553 ("Hide hotel from the receipt type search filter"). That PR intended for a manually-typed
receipt-type:hotelto still render its Hotel label (see its own test step 7), but it broke exactly that.The Receipt type filter's option list is built from
SELECTABLE_RECEIPT_TYPES(ereceipt,itemizedonly), which no longer containshotel:SearchUIUtils.ts:5616-5620—getMultiSelectFilterOptionsnow maps overSELECTABLE_RECEIPT_TYPES, so it emits nohoteloption.FilterComponents/index.tsx:74— the multi-select derives its selected labels by intersecting the current value with those options:items.filter((item) => value.includes(item.value)). Sincehotelisn't initems, an activehotelselection resolves to an empty label — nothing shows.The parse and query-chip paths are unaffected (
hotelis still a valid parsed value atSearchQueryUtils.ts:1230-1236and still translates viaSearchUIUtils.ts:5476-5477), which is why the query still submits — only the filter selection list drops the label.What changes do you think we should make in order to solve the problem?
Make the Receipt type option list hide
hotelonly as a new choice, while still surfacing it when it is already part of the current selection. IngetMultiSelectFilterOptions, pass in the current filter value and, forRECEIPT_TYPE, build options from the union ofSELECTABLE_RECEIPT_TYPESand any already-selected values (sohotelappears with its label when active, but isn't offered otherwise). This satisfies the original PR's intent (hidden from suggestions/picker, but its label still renders when applied).Alternative considered
Reverting the option-list change would bring
hotelback as a freely-selectable option, which contradicts the goal of #96553 (hotel has no backend data yet). The union approach keeps hotel un-selectable while preserving its label for manually-entered queries.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/96724)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
David-2002065 commentedon Jul 22, 2026
🚨 Edited by proposal-police: This proposal was edited at 2026-07-22 09:34:25 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
After manually typing
receipt-type:hotelin the search bar and submitting, opening the Receipt type filter shows onlyeReceiptandItemized— the appliedHotelvalue is not rendered as a selected item in the list, so there is no way to see or remove it.What is the root cause of that problem?
PR #96553 hid
hotelfrom the receipt-type picker by trimming the picker's option source toSELECTABLE_RECEIPT_TYPES(['ereceipt', 'itemized']). The problem is that this same option array is used to render the currently-selected rows, not just the values offered for a new selection.getMultiSelectFilterOptionsnow returns only the selectable types forRECEIPT_TYPE:App/src/libs/SearchUIUtils.ts
Lines 5616 to 5620 in 908172c
MultiSelectFilterComponentsresolves the selected rows by filtering that same array, andMultiSelectbuilds its visible list exclusively fromitems(avaluethat isn't initemsnever becomes a row):App/src/components/Search/FilterComponents/index.tsx
Lines 71 to 87 in 908172c
App/src/components/Search/FilterComponents/MultiSelect.tsx
Lines 83 to 88 in 908172c
So a hand-typed
receipt-type:hotelparses, validates and is stored in the form (hotelis still in the fullCONST.SEARCH.RECEIPT_TYPEenum and inVALID_RECEIPT_TYPES), yet it has no row to render in the picker because it was removed from the options array. Notably the label path outside the picker still works —getDisplayValuelabels the value directly throughgetReceiptTypeTranslationKey, which is why the results-header filter chip does show "Hotel":App/src/libs/SearchUIUtils.ts
Lines 5476 to 5477 in 908172c
The regression is that PR #96553 conflated "values offered for a new selection" with "values rendered for the current selection". Hiding
hotelfrom the former also hid it from the latter, which contradicts the PR's own stated intent that "typingreceipt-type:hotelstill parses, validates and renders its label".What changes do you think we should make in order to solve the problem?
Keep
hotelout of the pickable set, but let the picker also surface any value that is already applied — the offered options should be the selectable set unioned with the current selection.In
getMultiSelectFilterOptions(src/libs/SearchUIUtils.ts), accept the current selection and, forRECEIPT_TYPE, offer the selectable types plus any already-selected value from the full enum:Then pass the current value from
MultiSelectFilterComponents(src/components/Search/FilterComponents/index.tsx):Iterating
Object.values(CONST.SEARCH.RECEIPT_TYPE)and filtering keeps the original enum ordering. When nothing is selected, the result is unchanged (eReceipt,Itemizedonly), so the picker and autocomplete stay clean for fresh selections; whenreceipt-type:hotelis applied,Hotelappears as a checked, labelled, removable row. Re-enabling hotel globally later is still just a revert of PR #96553.What specific test steps make sure that the issue is fixed?
Extend
getMultiSelectFilterOptionsunit coverage (the PR only tested the no-selection case):getMultiSelectFilterOptions(RECEIPT_TYPE, ...)still excludeshotel.['hotel']passed as the current selection, the returned options include{value: 'hotel', text: 'Hotel'}, so the applied value renders and can be removed.What alternative solutions did you explore? (Optional)
MultiSelectFilterComponentsby appending hidden-but-selected values with a local label lookup. It works, but it duplicates the receipt-type → label mapping outsidegetMultiSelectFilterOptionsand would have to be repeated for every filter that hides values, so I prefer keeping the single source of truth.hotelis fully selectable again — this restores the label but re-introduces the empty-result selection the PR deliberately removed.MobileMage commentedon Jul 22, 2026
🚨 Edited by proposal-police: This proposal was edited at 2026-07-22 09:30:15 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
hotelis a valid backend value for thereceipt-typesearch filter, but after manually typingreceipt-type:hotelin the search bar and submitting, the receipt-type filter selection list shows only eReceipt and Itemized — no "Hotel" row and no checked selection is rendered, even though the query keeps thehotelvalue. The applied filter becomes invisible in the filter UI.What is the root cause of that problem?
The regression comes from PR #96553 (commit
ee3a4da78a2, "Hide hotel from the receipt type filter options"). It introducedSELECTABLE_RECEIPT_TYPES = ['ereceipt', 'itemized']and switchedgetMultiSelectFilterOptionsforRECEIPT_TYPEfromObject.values(CONST.SEARCH.RECEIPT_TYPE)(which includeshotel) to that reduced list. A sibling change did the same for the search-bar autocomplete viaRECEIPT_TYPE_FRIENDLY_VALUESinuseAutocompleteSuggestions.ts. The stated intent (see the comment on the constant) is that hotel can't return results until historical receipts are backfilled, so it should not be offered. The autocomplete-suggestion half (step 3 of the repro) is therefore working as designed.App/src/CONST/index.ts
Lines 6706 to 6707 in 908172c
The problem is that
hotelis still fully valid and parseable everywhere else.VALID_RECEIPT_TYPESinSearchQueryUtilsis built from all ofCONST.SEARCH.RECEIPT_TYPE, sobuildFilterFormValuesFromQuerykeeps a manually typedreceipt-type:hotelin the advanced-filters form, andgetReceiptTypeTranslationKey('hotel')still resolves tosearch.receiptTypeValues.hotel= "Hotel". So the value survives into the form and has a valid label, but the receipt-type selection list no longer has an option row for it.getMultiSelectFilterOptionsnow emits only two rows:App/src/libs/SearchUIUtils.ts
Lines 5616 to 5620 in 908172c
The symptom is produced in
MultiSelectFilterComponents, whereitemscome fromgetMultiSelectFilterOptions(no hotel) and the selected set is derived by intersecting with those same items —items.filter((item) => value.includes(item.value))— which is empty whenvalueis['hotel'].App/src/components/Search/FilterComponents/index.tsx
Lines 73 to 74 in 908172c
MultiSelectthen builds itslistDatapurely fromitems(items.map(... isSelected: !!selectedItems.find(...))), so any applied value that isn't initemshas no row to render and no checkmark. The result is exactly the report: the Receipt type filter list shows eReceipt/Itemized unchecked and the applied Hotel value is silently dropped from view.What changes do you think we should make in order to solve the problem?
Keep hotel out of new selection (autocomplete + default options), but still label it when it is already applied. The cleanest place is
getMultiSelectFilterOptions: pass the current selected values in and, forRECEIPT_TYPE, union any applied-but-hidden valid value ontoSELECTABLE_RECEIPT_TYPESbefore mapping to labels. It has a single production caller (MultiSelectFilterComponents), so widening the signature is safe.Then call it with the current value in
MultiSelectFilterComponents:getMultiSelectFilterOptions(filterKey, type, translate, value as string[]). This makes the "Hotel" row appear (checked) only because it was already in the query, so it renders and can be de-selected, while a fresh filter still never offers hotel. Autocomplete stays untouched, so step 3 of the repro remains correct.What alternative solutions did you explore? (Optional)
Reverting
getMultiSelectFilterOptionsback toObject.values(CONST.SEARCH.RECEIPT_TYPE)and hiding hotel only in the autocomplete would fix the label, but it re-exposes hotel as a freely selectable option in the RHP filter list — precisely what PR #96553 set out to prevent — so it's the wrong trade-off.yusufdeveloper2903 commentedon Jul 22, 2026
Proposal
What is the root cause of that problem?
When a user manually types
receipt-type:hotelinto the search bar and submits, thehotelvalue is parsed correctly by the search query parser. However, when the filter is rendered in the filter list above the results, the backend value (hotel) is never translated to its display text (e.g., "Hotel"). This happens becausegetFilterDisplayValue()inSearchQueryUtils.tsis missing a case forRECEIPT_TYPE, while the same function handles all other comparable filters likeEXPENSE_TYPE,WITHDRAWAL_TYPE,PAID_STATUS,WITHDRAWAL_STATUS, etc.The autocomplete suggestions for
receipt-type:work correctly because they pull fromCONST.SEARCH.RECEIPT_TYPEand explicitly callgetReceiptTypeTranslationKey()to translate each backend value to display text. But once a value is manually entered and the search query is parsed, the display rendering path ingetFilterDisplayValue()lacks the corresponding receipt-type translation logic.The causal chain:
receipt-type:hotelinto search barhotelis inCONST.SEARCH.RECEIPT_TYPE)getFilterDisplayValue()withfilterName=receiptTypeandfilterValue=hotelgetFilterDisplayValue()reaches line 1652 (the finalreturn filterValue) without matching any case, so it returns the raw backend valuehotelinstead of the translated display textApp/src/libs/SearchQueryUtils.ts
Lines 1582 to 1653 in fd467ee
Compare with
RECEIPT_TYPEalready being handled correctly inbuildFilterFormValuesFromQuery()at line 1230, which validates receipt type values:App/src/libs/SearchQueryUtils.ts
Lines 1230 to 1237 in fd467ee
And the display translation for receipt types is already proven to work in
SearchUIUtils.tsfor the advanced filters UI:App/src/libs/SearchUIUtils.ts
Lines 5612 to 5617 in fd467ee
The missing piece is exactly the case in
getFilterDisplayValue(). The functiongetReceiptTypeTranslationKey()is already defined and ready to use:App/src/libs/TransactionUtils/index.ts
Lines 291 to 300 in fd467ee
What changes do you think we should make in order to solve the problem?
Add a case for
RECEIPT_TYPEingetFilterDisplayValue()that translates backend values usinggetReceiptTypeTranslationKey().1. Update
getFilterDisplayValue()function — Add the receipt-type case right before the final return statement, using the same pattern asCARD_IDandBANK_ACCOUNT:Insert this after line 1651 (after the
EXPORTED_TOcase) and before line 1652 (the final return).Why this is safe:
getReceiptTypeTranslationKey()function already safely handles all three receipt type backend values (ereceipt,itemized,hotel), returning the correct translation path for each. Seesrc/libs/TransactionUtils/index.ts, lines 218-225.CONST.SEARCH.RECEIPT_TYPEbecause the search parser only accepts valid values.CARD_ID,BANK_ACCOUNT,POLICY_ID, etc.), so it carries zero risk of introducing a new pattern.buildFilterFormValuesFromQuery()at line 1231 ofSearchQueryUtils.ts, so an invalid receipt type never reaches the display layer anyway.Result: When a user manually enters
receipt-type:hoteland submits, the filter chip will now display "Hotel" (the translated value) instead of the raw backend value "hotel", matching the autocomplete suggestions and fixing both the missing label and the search consistency.What alternative solutions did you explore? (Optional)
getUserFriendlyValue()instead: This would require addinghotelto theSEARCH_USER_FRIENDLY_VALUES_MAP. However, the dedicatedgetReceiptTypeTranslationKey()function already exists and is purpose-built for this, so adding a new map entry would duplicate logic.buildFilterFormValuesFromQuery(): Would work, but that function is already complex and handles 20+ filter types; the display layer is the correct place for this transformation, and it's consistent with how the codebase handles other enum filters.abbasifaizan70 commentedon Jul 22, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user manually types
receipt-type:hotelinto the search bar and submits it, the "Hotel" label/chip does not appear anywhere in the resulting filter list (e.g. in the Advanced Filters "Receipt type" picker), even thoughhotelis a valid, recognized receipt type value.What is the root cause of that problem?
CONST.SEARCH.SELECTABLE_RECEIPT_TYPESintentionally only containsereceiptanditemized(hotel receipts aren't backfilled with search data yet), and this same constant is reused to build the list of selectable options shown in the Receipt Type filter picker:App/src/CONST/index.ts
Lines 6706 to 6707 in 3e8642c
getMultiSelectFilterOptionsbuilds the Receipt Type picker'sitemsstrictly from that restricted list, sohotelis never one of the generated items:App/src/libs/SearchUIUtils.ts
Lines 5616 to 5621 in 3e8642c
MultiSelectFilterComponentsthen determines which items are "selected" by intersecting the form'svalue(which does contain'hotel', sinceVALID_RECEIPT_TYPESinSearchQueryUtils.tsis built from the fullCONST.SEARCH.RECEIPT_TYPEenum and correctly keeps it in the form) againstitems. Becauseitemsnever contains ahotelentry,Array.prototype.filterfinds no match and nothing is rendered for it:App/src/components/Search/FilterComponents/index.tsx
Lines 71 to 87 in 3e8642c
So the value survives all the way into the form/query (it's a legitimate receipt type), but the picker UI silently drops it from display because it only knows about the "suggestable" subset of receipt types, not the full set of valid ones. This is purely a display bug in how selected-but-not-suggested values are reconciled with the options list — it's unrelated to the (intentional) exclusion of
hotelfrom autocomplete suggestions.What changes do you think we should make in order to solve the problem?
Keep
hotelout of the suggested autocomplete/options list (that exclusion is intentional per the code comment), but make sure a value that is already selected/applied is still included as an item so it can render with its translated label. The cleanest way is to havegetMultiSelectFilterOptionsaccept the currently selected values and union them into the generateditemsfor theRECEIPT_TYPEcase, instead of hard-limiting toSELECTABLE_RECEIPT_TYPES.Original code to change:
App/src/libs/SearchUIUtils.ts
Lines 5600 to 5621 in 3e8642c
App/src/components/Search/FilterComponents/index.tsx
Lines 71 to 87 in 3e8642c
selectedValuesparameter togetMultiSelectFilterOptions, and for theRECEIPT_TYPEbranch, build the options list from the union ofCONST.SEARCH.SELECTABLE_RECEIPT_TYPESand any already-selected values that are valid entries ofCONST.SEARCH.RECEIPT_TYPE(so a manually-typedhotelstill resolves to an item with its translated label), while all other filter keys keep their current behavior untouched:valuethrough so already-applied values are preserved in the options list:With this change, typing
receipt-type:hoteland submitting will still keephotelout of the autocomplete suggestions (unchanged, sinceuseAutocompleteSuggestions.tsreadsCONST.SEARCH.SELECTABLE_RECEIPT_TYPESdirectly), but the Receipt Type filter list/picker will correctly render the "Hotel" chip using the existingsearch.receiptTypeValues.hoteltranslation, sincegetReceiptTypeTranslationKeyalready supportsCONST.SEARCH.RECEIPT_TYPE.HOTEL.ahmdshrif commentedon Jul 22, 2026
🚨 Edited by proposal-police: This proposal was edited at 2026-07-22 09:30:31 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
receipt-type:hotelis still a valid, parseable filter value, but after manually typing and submitting it, the "Hotel" label never appears in the receipt-type filter list — and interacting with that filter silently deletesreceipt-type:hotelfrom the query.What is the root cause of that problem?
This is a regression from PR
#96553("Hide hotel from the receipt type search filter"). Its intent was to hide hotel from the suggestions (backend has noisHotelReservationdata backfilled yet), and its description explicitly assumed "Typingreceipt-type:hotelstill parses, validates and renders its label". That assumption is wrong, because the PR restricted the wrong layer:SELECTABLE_RECEIPT_TYPES: ['ereceipt', 'itemized']:App/src/CONST/index.ts
Lines 6701 to 6707 in 908172c
receipt-type:hotelsurvives every data step. The search parser keeps it (I ran it:{"left":"receiptType","right":"hotel"}), form validation accepts it against the full enum (VALID_RECEIPT_TYPES):App/src/libs/SearchQueryUtils.ts
Line 101 in 908172c
App/src/libs/SearchQueryUtils.ts
Lines 1230 to 1237 in 908172c
getMultiSelectFilterOptions()now enumerates onlySELECTABLE_RECEIPT_TYPES:App/src/libs/SearchUIUtils.ts
Lines 5616 to 5621 in 908172c
MultiSelectFilterComponentsresolves the applied form value against those items, sohotelmatches nothing and renders nowhere:App/src/components/Search/FilterComponents/index.tsx
Lines 71 to 87 in 908172c
items.filter((item) => value.includes(item.value))→[]).onChangere-emits only checked listed items (lines 82–84), so opening the Receipt type filter and applying wipesreceipt-type:hotelfrom the user's query without any user action on hotel.Affected paths (all funnel into
FilterComponents→getMultiSelectFilterOptions):App/src/components/Search/SearchPageHeader/useSearchFiltersBar.tsx
Line 128 in 908172c
App/src/components/Search/FilterDropdowns/SearchAdvancedFiltersPopup/CommonFilterContentPopupWrapper.tsx
Lines 11 to 20 in 908172c
App/src/pages/Search/SearchAdvancedFiltersContentPage/SearchAdvancedFiltersContentBase.tsx
Lines 66 to 77 in 908172c
This explains every symptom: autocomplete no longer suggests hotel (intended,
useAutocompleteSuggestions.ts#L75), the Hotel entry/label is missing from the filter list on both web and Android, and the label loss only exists on staging (production still has the pre-#96553full option list; the backend is shared, so only this App change can explain the staging-only repro).What changes do you think we should make in order to solve the problem?
Fix at the convergence point: teach
getMultiSelectFilterOptionsto include applied-but-unselectable values, so a manually-entered hotel filter renders (and survives apply) while hotel stays hidden whenever it is not already in the query:and pass the applied value at the only call site (
FilterComponents/index.tsx#L73):getMultiSelectFilterOptions(filterKey, type, translate, value as string[]).getReceiptTypeTranslationKeyalready maps hotel →search.receiptTypeValues.hotel("Hotel"), so no copy changes are needed:App/src/libs/TransactionUtils/index.ts
Lines 291 to 301 in 908172c
#96553added intests/unit/Search/SearchUIUtilsTest.ts(L11239) to cover the applied-hotel case. Regression safety: the new parameter is optional and empty in every no-selection render, so the picker, autocomplete, and all other multi-select filters behave exactly as today.Why the simple fix fails: reverting the
getMultiSelectFilterOptionshunk (or re-adding hotel toSELECTABLE_RECEIPT_TYPES) re-exposes Hotel as a suggestible/pickable option — exactly what#96553intentionally removed until the backend backfill lands. And a display-only patch (special-casing the pill/label text) still leaves the popup'sonChangeemitting only listed values, so applying the Receipt type filter would keep silently deletingreceipt-type:hotelfrom the query.What alternative solutions did you explore? (Optional)
#96553'sSearchUIUtilshunk — restores the label but re-lists Hotel as pickable, defeating the PR's intent (see above).MultiSelectFilterComponents— same behavior, but that component lacks per-filter-key translation knowledge; the mapping belongs ingetMultiSelectFilterOptions, which already hastranslateand the key.mukhrr commentedon Jul 22, 2026
Proposal
What is the root cause of that problem?
I found that
hotelremains a valid receipt type, and manually entered queries are parsed into thereceiptTypefilter correctly:App/src/libs/SearchQueryUtils.ts
Lines 1230 to 1236 in 908172c
The regression was introduced when the receipt-type options were changed from all valid values to
SELECTABLE_RECEIPT_TYPESso Hotel would not be suggested before historical receipts are backfilled:App/src/libs/SearchUIUtils.ts
Lines 5622 to 5626 in ee3a4da
That selectable list intentionally excludes
hotel:App/src/CONST/index.ts
Lines 6701 to 6707 in 908172c
However,
MultiSelectFilterComponentsalso uses those selectable options to resolve the current filter value. It filtersvalueagainstitems, so a manually enteredhotelvalue has no matching item and becomes an empty selection:App/src/components/Search/FilterComponents/index.tsx
Lines 71 to 80 in 908172c
MultiSelectcan only render rows fromitems, which is why the selected Hotel label disappears:App/src/components/Search/FilterComponents/MultiSelect.tsx
Lines 76 to 89 in 908172c
What changes do you think we should make in order to solve the problem?
I think we should update
getMultiSelectFilterOptions()to accept the current values and, forRECEIPT_TYPE, append any valid currently selected receipt types that are absent fromSELECTABLE_RECEIPT_TYPES.MultiSelectFilterComponentsshould pass its currentvalueinto that function.For example:
The receipt-type branch would build options from the union of
SELECTABLE_RECEIPT_TYPESand valid selected values. Therefore,hotelappears as a selected Hotel row only when it came from the existing query, while an empty receipt-type filter continues to offer only eReceipt and Itemized.I would add tests covering both cases:
hotelvalue returns and renders the translated Hotel option.This does not regress autocomplete because it continues to use
SELECTABLE_RECEIPT_TYPESdirectly:App/src/hooks/useAutocompleteSuggestions.ts
Lines 70 to 76 in 908172c
Other multi-select filters are unaffected because the selected-value augmentation is limited to
RECEIPT_TYPE.What alternative solutions did you explore? (Optional)
I considered restoring
Object.values(CONST.SEARCH.RECEIPT_TYPE)unconditionally, but that would undo the intentional change and make Hotel selectable again for new searches. Preserving it only when already present in the query fixes the missing label without reintroducing that behavior.lorretheboy commentedon Jul 22, 2026
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
14 remaining items
github-actions commentedon Jul 22, 2026
github-actions commentedon Jul 22, 2026
KJ21-ENG commentedon Jul 22, 2026
Updated my proposal.
What changed: Added cross-layout call-site proof and mixed-selection lifecycle coverage while preserving the active-only Hotel option fix.
Why: The existing body was duplicate-flagged, while its wider layout and state-transition coverage was not explicit enough.
askavyblr commentedon Jul 22, 2026
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
github-actions commentedon Jul 22, 2026
yuwenmemon commentedon Jul 22, 2026
@JS00001 @allgandalf This came from: #96553
bernhardoj commentedon Jul 23, 2026
@allgandalf are you going to handle this as a follow-up?
allgandalf commentedon Jul 23, 2026
We hit it on purpose for now ,
The QA steps say the same, i'm closing this out, please reopen if i'm mistaken
SupremeDreamZ commentedon Jul 25, 2026
Proposal
Root cause confirmed: PR #96553 removed
hotelfromSELECTABLE_RECEIPT_TYPES(autocomplete/default options), butgetMultiSelectFilterOptions()builds its option list only from that array. When a user manually typesreceipt-type:hotel, the value passes validation inSearchQueryUtils(VALID_RECEIPT_TYPESstill includes it) but has no display entry → blank chip.Fix (PR #97037):
getMultiSelectFilterOptions(): forRECEIPT_TYPE, return union ofSELECTABLE_RECEIPT_TYPES+ any currently-applied values (currentValuesparam). Already-selected receipt types always resolve a label.MultiSelectFilterComponents: passvaluearray to the option builder.SELECTABLE_RECEIPT_TYPESunchanged → hotel stays hidden from fresh autocomplete exactly as Hide hotel from the receipt type search filter #96553 intended.Tests proving it works (
tests/unit/Search/SearchUIUtilsTest.ts):[][ereceipt, itemized]✅[ereceipt, itemized]✅[hotel][]❌[ereceipt, itemized, hotel]✅[ereceipt, hotel][ereceipt]❌[ereceipt, itemized, hotel]✅[itemized, hotel][itemized]❌[ereceipt, itemized, hotel]✅All 4 cases pass
bun test --test-name-pattern="getMultiSelectFilterOptions".Why this PR over the 6 existing proposals
All 6 identify the same root cause. This is the only one that:
currentValues?: string[]param, zero call-site breaksSELECTABLE_RECEIPT_TYPES; label resolution is additiveReady for review — happy to address feedback fast.
melvin-bot commentedon Jul 25, 2026
📣 @SupremeDreamZ! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format: