Repository navigation
fix(Search): show hotel receipt type label when manually filtered (fixes #96724) - #97037
Closed
SupremeDreamZ wants to merge 1 commit into
Closed
SupremeDreamZ wants to merge 1 commit into
SupremeDreamZ wants to merge 1 commit into
Conversation
Fixes Expensify#96724 — PR Expensify#96553 removed 'hotel' from SELECTABLE_RECEIPT_TYPES so it no longer appears in autocomplete or new filter selections. However, a manually typed 'receipt-type:hotel' filter must still resolve its 'Hotel' label in the active filter list. - getMultiSelectFilterOptions: union SELECTABLE_RECEIPT_TYPES with any currently-selected values so already-applied receipt types render. - MultiSelectFilterComponents: pass current value array to the option builder. - Add regression tests covering: hotel label present when current value includes hotel; no duplicate when overlap; hotel still excluded from fresh autocomplete. No behavior change for fresh selections — hotel remains hidden by default.
melvin-bot
Bot
requested review from
joekaufmanexpensify
and removed request for
a team
July 25, 2026 18:34
2 of 7 tasks
|
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
👋 Hi @SupremeDreamZ, thanks for your interest in contributing to Expensify! This PR has been automatically closed because it doesn't appear to meet our contribution requirements:
If you'd like to contribute, please make sure to:
Please review our contributing guidelines for more details. If you believe this was closed in error, please reach out in the #expensify-open-source Slack channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$ #96724 — filter typed manually shows blank label instead of "Hotel".
Root cause
PR #96553 removed from to hide it from autocomplete and new selections. However, builds the option list only from . When a user manually types , the value is valid (passes in ) but has no display entry — so the filter chip renders with an empty label.
Fix
Test evidence
Added regression tests in :
Tests pass locally (see bun test v1.3.14 (0d9b296a)).
Why this PR over the 6 existing proposals
All 6 proposals identify the same root cause. This PR is the only one that:
Ready for review.