You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-30] Category - GL code for subcategory does not have left indentation #96799
Version Number: 9.4.43-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#94596 Email or phone of affected tester (no customers):sdsjodijnsdojsosjio@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Create a Control workspace.
Enable Show GL codes when categorizing expenses in workspace settings > Categories > More > Settings.
Create this category - Lunch: Sushi and add GL code to this category.
Go to staging.new.expensify.com
Go to workspace chat.
Click + > Create expense > Manual.
Enter amount > Next.
Click Category.
Scroll down to Sushi subcategory.
Expected Result:
GL code for subcategory will be shown with left indentation.
Actual Result:
GL code for subcategory does not have left indentation.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The category name is indented by prepending whitespace (CONST.INDENTS = 4 spaces) directly to the text string, but the GL code is added as alternateTextwithout that same indentation prefix.
The subcategory name (Sushi) gets indents prepended so it renders indented under its parent (Lunch), but alternateText (the GL code) is set to the bare option.glCode, so it renders flush-left instead of aligned beneath the indented name. This was introduced in #94596.
What changes do you think we should make in order to solve the problem?
Apply the same indents prefix to the GL code alternateText so it aligns with the indented subcategory name:
indents is built as times(index, () => CONST.INDENTS).join('') at CategoryOptionListUtils.ts:48, and CONST.INDENTS is ' ' (4 spaces).
Indentation of nested categories is purely string-based leading whitespace on text; nothing indents alternateText, which renders on its own line under the title.
glCode is only attached for child options via withGLCode, matching the report that the problem is specific to subcategories.
What alternative solutions did you explore? (Optional)
None needed — the fix mirrors the existing indentation mechanism already used for the category name.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/96799) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Category - GL code for subcategory does not have left indentation[/-][+][Due for payment 2026-07-30] Category - GL code for subcategory does not have left indentation[/+]on Jul 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.43-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-30. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jul 22, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/5b6bf666514cef661c3c22d7491835c2b06372d38608511af0587918191c6e20
melvin-bot commentedon Jul 22, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #94596
melvin-bot commentedon Jul 22, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 22, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 22, 2026
Proposal
What is the root cause of that problem?
The category name is indented by prepending whitespace (
CONST.INDENTS= 4 spaces) directly to thetextstring, but the GL code is added asalternateTextwithout that same indentation prefix.In
CategoryOptionListUtils.ts:70-71:The subcategory name (
Sushi) getsindentsprepended so it renders indented under its parent (Lunch), butalternateText(the GL code) is set to the bareoption.glCode, so it renders flush-left instead of aligned beneath the indented name. This was introduced in #94596.What changes do you think we should make in order to solve the problem?
Apply the same
indentsprefix to the GL codealternateTextso it aligns with the indented subcategory name:Supporting evidence
indentsis built astimes(index, () => CONST.INDENTS).join('')atCategoryOptionListUtils.ts:48, andCONST.INDENTSis' '(4 spaces).text; nothing indentsalternateText, which renders on its own line under the title.glCodeis only attached for child options viawithGLCode, matching the report that the problem is specific to subcategories.What alternative solutions did you explore? (Optional)
None needed — the fix mirrors the existing indentation mechanism already used for the category name.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/96799)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
mollfpr commentedon Jul 23, 2026
The offending PR has been reverted in #96852. This should be resolved once the revert is deployed to staging.
melvin-bot commentedon Jul 23, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Jul 23, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Jul 23, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
yuwenmemon commentedon Jul 23, 2026
Offending PR reverted in: #96852
@yusufdeveloper2903 and @mollfpr please have a look when you get a chance.
[-]Category - GL code for subcategory does not have left indentation[/-][+][Due for payment 2026-07-30] Category - GL code for subcategory does not have left indentation[/+]melvin-bot commentedon Jul 23, 2026
@mollfpr
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.43-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-30. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]