Repository navigation
[CP Staging] Revert "Show GL code when selecting a category" - #96852
Conversation
|
@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…-gl-code-category [CP Staging] Revert "Show GL code when selecting a category" (cherry picked from commit ea227cf) (cherry-picked to staging by mountiny)
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.43-1 🚀
|
No help site changes required ✅This PR reverts #94596 ("Show GL code when selecting a category"), removing the Show GL codes when categorizing expenses toggle and the display of GL codes in the category picker. I reviewed
Because no help article contradicts the current (reverted) behavior, no draft docs PR is needed. @mollfpr — since no docs changes are required, no help site PR was created. Please confirm you agree the existing help site content already reflects the current (reverted) behavior. If you'd like a docs PR anyway, let me know and I'll open one. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.43-1 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.44-0 🚀
|
Help site review: no changes requiredI reviewed this revert against the help-site articles under Why:
Since the help site already reflects the current behavior, no draft PR, @mollfpr, please confirm you agree no help-site changes are needed for this revert. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.44-6 🚀
Bundle Size Analysis (Sentry): |
This reverts #94596.
Explanation of Change
Reverts #94596 ("Show GL code when selecting a category"). That PR added the "Show GL codes when categorizing expenses" toggle and surfaced GL codes in the category picker, and it caused several deploy blockers on staging. Reverting it restores the previous behavior while the issues are addressed.
Fixed Issues
$ #96799
$ #96808
$ #96810
$ #96816
Tests
Precondition: Use an account that does NOT have the
rulesRevampbeta enabled. WithrulesRevampon (as on Applause accounts with all betas enabled), the Categories Settings option is hidden and the GL codes toggle can't be reached.Offline tests
Same as above.
QA Steps
Precondition: Use an account that does NOT have the
rulesRevampbeta enabled. WithrulesRevampon (as on Applause accounts with all betas enabled), the Categories Settings option is hidden and the GL codes toggle can't be reached.Author Checklist
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick).Avatar, I verified the components usingAvatarhave been tested & I retested again)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari