Skip to content

[CP Staging] Revert "Show GL code when selecting a category" - #96852

Merged
mollfpr merged 1 commit into
mainfrom
revert-94596-feat/93155-show-gl-code-category
Jul 23, 2026
Merged

mollfpr merged 1 commit into
mainfrom
revert-94596-feat/93155-show-gl-code-category

Conversation

@mollfpr

@mollfpr mollfpr commented Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

This reverts #94596.

Explanation of Change

Reverts #94596 ("Show GL code when selecting a category"). That PR added the "Show GL codes when categorizing expenses" toggle and surfaced GL codes in the category picker, and it caused several deploy blockers on staging. Reverting it restores the previous behavior while the issues are addressed.

Fixed Issues

$ #96799
$ #96808
$ #96810
$ #96816

Tests

Precondition: Use an account that does NOT have the rulesRevamp beta enabled. With rulesRevamp on (as on Applause accounts with all betas enabled), the Categories Settings option is hidden and the GL codes toggle can't be reached.

  1. Open a Control workspace that has GL codes enabled
  2. Go to Workspace > Categories > Settings
  3. Verify the "Show GL codes when categorizing expenses" toggle is no longer present
  4. Create/edit an expense and open the category picker
  5. Verify GL codes are no longer shown in the category picker and the regression from [Due for payment 2026-07-30] Categories - No "Show GL codes when categorizing expenses" toggle for Expensifail account #96816 no longer reproduces
  • Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Precondition: Use an account that does NOT have the rulesRevamp beta enabled. With rulesRevamp on (as on Applause accounts with all betas enabled), the Categories Settings option is hidden and the GL codes toggle can't be reached.

  1. Open a Control workspace that has GL codes enabled
  2. Go to Workspace > Categories > Settings
  3. Verify the "Show GL codes when categorizing expenses" toggle is no longer present
  4. Create/edit an expense and open the category picker
  5. Verify GL codes are no longer shown in the category picker and the regression from [Due for payment 2026-07-30] Categories - No "Show GL codes when categorizing expenses" toggle for Expensifail account #96816 no longer reproduces
  • Verify that no errors appear in the JS console

Author Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@mollfpr
mollfpr requested review from a team as code owners July 23, 2026 07:34
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and cristipaval and removed request for a team July 23, 2026 07:34
@melvin-bot

melvin-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov

codecov Bot commented Jul 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/CategoryPicker/index.tsx 2.94% <ø> (+0.16%) ⬆️
src/libs/API/types.ts 100.00% <ø> (ø)
src/libs/actions/Policy/Category.ts 50.71% <ø> (+0.85%) ⬆️
...egories/DynamicWorkspaceCategoriesSettingsPage.tsx 0.00% <ø> (ø)
src/libs/CategoryOptionListUtils.ts 95.23% <92.85%> (+0.64%) ⬆️
... and 11 files with indirect coverage changes

@mollfpr mollfpr changed the title Revert "Show GL code when selecting a category" [CP Staging] Revert "Show GL code when selecting a category" Jul 23, 2026
@mollfpr
mollfpr merged commit ea227cf into main Jul 23, 2026
49 checks passed
@mollfpr
mollfpr deleted the revert-94596-feat/93155-show-gl-code-category branch July 23, 2026 08:03
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.43-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes required ✅

This PR reverts #94596 ("Show GL code when selecting a category"), removing the Show GL codes when categorizing expenses toggle and the display of GL codes in the category picker.

I reviewed App/docs/articles and found no help site updates are needed:

  • The original feature was never documented. PR Show GL code when selecting a category #94596 only touched source code (src/…) and language files — it added no help site articles. So there's nothing to revert in the docs.

  • The existing docs already reflect the reverted behavior. Create-expense-categories.md already states, under "How can members see GL codes?":

    GL codes are not visible to members by default. If visibility is required, consider including the GL code in the category name itself.

    This matches the state this PR restores — GL codes hidden from members in the category picker.

Because no help article contradicts the current (reverted) behavior, no draft docs PR is needed.


@mollfpr — since no docs changes are required, no help site PR was created. Please confirm you agree the existing help site content already reflects the current (reverted) behavior. If you'd like a docs PR anyway, let me know and I'll open one.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.43-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.44-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review: no changes required

I reviewed this revert against the help-site articles under docs/articles and no documentation updates are needed, so I have not opened a draft PR.

Why:

  • This PR reverts the "Show GL codes when categorizing expenses" toggle and the surfacing of GL codes in the category picker (a revert of Show GL code when selecting a category #94596).

  • The original feature PR (Show GL code when selecting a category #94596) did not include any docs/articles changes — the toggle was never documented on the help site.

  • The current help-site content already describes the reverted (now-restored) behavior. Create-expense-categories.md states under "How can members see GL codes?":

    GL codes are not visible to members by default. If visibility is required, consider including the GL code in the category name itself.

    That matches post-revert behavior — GL codes are not shown to members in the category picker, and the documented workaround (include the code in the category name) is the correct guidance again.

  • The phrase "Show GL codes when categorizing expenses" (and any equivalent toggle description) does not appear anywhere in docs/articles, so there is nothing to remove.

Since the help site already reflects the current behavior, no draft PR, HelpDot label, or assignment is being created.

@mollfpr, please confirm you agree no help-site changes are needed for this revert.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.44-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants