Skip to content

Deploy Checklist: New Expensify 2022-07-12 #9847

New issue
New issue
Closed
Closed
Deploy Checklist: New Expensify 2022-07-12#9847
Assignees
applausebot
Labels
MonthlyKSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Description

@OSBotify
OSBotify
opened on Jul 12, 2022

Release Version: 1.1.84-13
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

Activity

  1. OSBotify
    added
    StagingDeployCash
    on Jul 12, 2022
  2. OSBotify
    assigned
    applausebot
    on Jul 12, 2022

  3. roryabraham commented on Jul 12, 2022

    @roryabraham
    roryabraham
    on Jul 12, 2022
    Contributor

    @Expensify/applauseleads Please keep this unlocked while I break some more stuff 🙇

  4. mvtglobally
    added
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    and removed
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    on Jul 12, 2022

  5. mvtglobally commented on Jul 12, 2022

    @mvtglobally
    mvtglobally
    on Jul 12, 2022

    @roryabraham :) tag us whenever we are ready to rock n roll

  6. OSBotify commented on Jul 12, 2022

    @OSBotify
    OSBotify
    on Jul 12, 2022
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.84-1 🚀

  7. mvtglobally commented on Jul 13, 2022

    @mvtglobally
    mvtglobally
    on Jul 13, 2022

    @roryabraham are we ok to start QA or you still checking build

  8. roryabraham commented on Jul 13, 2022

    @roryabraham
    roryabraham
    on Jul 13, 2022
    Contributor

    As promised, I broke stuff while making deploy code changes. Things are still broken unfortunately, but I'm actively working on a fix.

  9. roryabraham commented on Jul 13, 2022

    @roryabraham
    roryabraham
    on Jul 13, 2022
    Contributor

    Apologies. I'm breaking stuff now to (hopefully) make things faster / simpler / stabler in the future. This checklist is going to be BLASTED with [No QA] PRs in a bit though 😅

  10. roryabraham
    added
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    and removed
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    on Jul 14, 2022

  11. roryabraham commented on Jul 14, 2022

    @roryabraham
    roryabraham
    on Jul 14, 2022
    Contributor

    Okay, I think everything is working again. Will hold off on any further GitHub Actions changes until we get another production release out. @Expensify/applauseleads feel free to lock this whenever you are ready (presumably tomorrow at this point), and thanks for your patience. 🙇

  12. mvtglobally
    added
    🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging
    on Jul 14, 2022

  13. OSBotify commented on Jul 14, 2022

    @OSBotify
    OSBotify
    on Jul 14, 2022
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.84-11 🚀

  14. 1 remaining item

  15. mvtglobally commented on Jul 16, 2022

    @mvtglobally
    mvtglobally
    on Jul 16, 2022

    Regression is completed

    PR #9768 is failing due to #9923 repro in PROD, checking off
    PR #9798 is failing due to #9918 repro in PROD, checking off
    PR #9801 is blocked by #9922. Can someone validate as well?
    PR #9804 is a PROD QA. Are we ok to check it off?

    Issues logged
    #9938
    #9939
    #9917
    #9918
    #9921
    #9922
    #9923
    #9926
    #9928
    #9929
    #9930
    #9933

  16. mountiny commented on Jul 16, 2022

    @mountiny
    mountiny
    on Jul 16, 2022
    Contributor

    Not sure if related to your breaking changes @roryabraham 😄 but this PR #9865 which is in the list has been merged after the deploy and haven't have CP staging label added and does not have Deployed to Staging Botify comment so it should not be in the list most likely unless I missed something :D

  17. OSBotify commented on Jul 18, 2022

    @OSBotify
    OSBotify
    on Jul 18, 2022
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.84-12 🚀

  18. OSBotify commented on Jul 18, 2022

    @OSBotify
    OSBotify
    on Jul 18, 2022
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.84-12 has been deployed to staging 🎉

  19. mvtglobally commented on Jul 18, 2022

    @mvtglobally
    mvtglobally
    on Jul 18, 2022

    @chiragsalian we are validating new CP. Let us know if anything else required to close this checklist

  20. mvtglobally commented on Jul 18, 2022

    @mvtglobally
    mvtglobally
    on Jul 18, 2022

    Both CPs pass. Checked off

  21. marcaaron commented on Jul 18, 2022

    @marcaaron
    marcaaron
    on Jul 18, 2022
    Contributor

    Heads up, #9659 was a fail for me when testing reauthentication - found an issue and created a CP PR to fix it here.

  22. chiragsalian commented on Jul 18, 2022

    @chiragsalian
    chiragsalian
    on Jul 18, 2022
    Contributor

    @mvtglobally, You've mentioned,

    PR #9801 is blocked by #9922.

    but i see 9922 as checked off. Will you be able to test 9801?

    PR #9804 is a PROD QA. Are we ok to check it off?

    Yes, feel free to always check off any prod QA issues. I'll check this one this time.

  23. mvtglobally commented on Jul 18, 2022

    @mvtglobally
    mvtglobally
    on Jul 18, 2022

    @chiragsalian we re-validated and PR is pass #9801. Checking off

  24. chiragsalian commented on Jul 18, 2022

    @chiragsalian
    chiragsalian
    on Jul 18, 2022
    Contributor

    The only thing pending is #9659. We've just CP'd a fix. Waiting for it to get deployed to staging to test before we can ship this to production.

  25. OSBotify commented on Jul 18, 2022

    @OSBotify
    OSBotify
    on Jul 18, 2022
    ContributorAuthor

    👏 Heads up @Expensify/applauseleads 👏
    A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.84-13 🚀

  26. OSBotify commented on Jul 18, 2022

    @OSBotify
    OSBotify
    on Jul 18, 2022
    ContributorAuthor

    🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.84-13 has been deployed to staging 🎉

  27. chiragsalian commented on Jul 18, 2022

    @chiragsalian
    chiragsalian
    on Jul 18, 2022
    Contributor

    Me and CarlosM tested #9961 and checked it off. Time to ship.

  28. chiragsalian commented on Jul 18, 2022

    @chiragsalian
    chiragsalian
    on Jul 18, 2022
    Contributor

    :shipit:

  29. chiragsalian
    closed this as completedon Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

MonthlyKSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to staging

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions