You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-02] Android - Odometer - Blank screen/error after adding odometer photo from gallery/camera #99137
Version Number: 9.4.58-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#98528 Email or phone of affected tester (no customers):sdsiodjnosdjiodsj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Money Requests
Action Performed:
Scenario 1:
Launch Expensify app.
Open FAB > Track distance > Odometer.
Tap add odometer photo button.
Add a photo from gallery.
Scenario 2:
Launch Expensify app.
Open FAB > Track distance > Odometer.
Tap add odometer photo button.
Take a photo.
Expected Result:
Scenario 1: Odometer page will not become blank.
Scenario 2: No error will show up.
Actual Result:
Scenario 1: Odometer page becomes blank after adding photo.
Scenario 2: Error shows up after taking a photo.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The auto-assigned PR #98528 is a false positive. The actual offending PR is #98654 — "Fix landscape mode on Odometer photo screen" (GCyganek, merged 2026-08-20, merge commit df900357fd04193a99eb90ef6f773b9e2af2848d). It's the only PR in this release that rewrote the odometer photo screen and both broken code paths.
Recommended resolution:Revert #98654. It cleanly restores the previously-working capture screen; the only thing lost is a landscape-mode cosmetic fix, which is far less severe than the odometer photo flow being entirely broken on Android.
#98528 changed exactly one file — useAttachmentPicker.ts — whose only consumers are the chat composer (ComposerActionMenu, ComposerInput, ComposerDropZone, ReportAddAttachmentModalContent). The odometer photo screen does not use that hook at all — it uses the AttachmentPicker component (via ScannerControlsBar) and useFilesValidation directly. #98528 got auto-assigned only because the reporter pasted its link into the issue's "regression testing" field.
Scenario 2 (camera → error): the capture call was changed from cropImageToAspectRatio(imageObject, width, height, undefined, photo.orientation) to dropping the orientation argument at index.native.tsx:212, and the Android orientation-aware sizing was reworked at getDeviceOrientationAwareImageSize/index.android.ts:7-16. When the resulting crop pipeline rejects, the screen's .catch fires showCameraAlert() at index.native.tsx:232-245.
Scenario 1 (gallery → blank screen): the gallery button now flows through the new ScannerControlsBar (onPicked → validateFiles) at index.native.tsx:324-333, and the readings screen it returns to was changed in the same PR from a View to a ScrollView in IOURequestStepDistanceOdometer.tsx — matching "Odometer page becomes blank after adding photo."
Confidence that #98654 is the offending PR: High (sole release PR rewriting this screen + both paths; symptom is Android-app-only, staging-not-production — consistent with a just-merged native refactor). Confidence on the precise camera throw: Medium-High (depends on device behavior on the Samsung S25 FE).
Note: I could not verify this live — it's an Android-native-only flow (the affected code is in .native.tsx files using native camera/gallery), so it does not exist on web and can't be reproduced in a browser.
Revert Fix landscape mode on Odometer photo screen #98654, or (if rolling forward) restore the capture orientation arg at index.native.tsx:212 and make the crop pipeline robust to the reworked orientation sizing, then confirm the gallery return no longer renders a blank readings screen.
Next Steps: Reply with @MelvinBot implement this to open a revert/fix PR, or @MelvinBot <your feedback> to refine this analysis.
changed the title [-]Android - Odometer - Blank screen/error after adding odometer photo from gallery/camera[/-][+][Due for payment 2026-10-02] Android - Odometer - Blank screen/error after adding odometer photo from gallery/camera[/+]on Sep 25, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.93-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-02. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Aug 21, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/1a2e11a05eeaf1a5e29ab71acca54632c42265f6e862fc3aff1773b533b280f1
https://platform.applause.com/services/links/v1/external/05bd543a5bd0675737c709eced267b515f624816cba3a57a8e1241a283dc5e70
melvin-bot commentedon Aug 21, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #98528
melvin-bot commentedon Aug 21, 2026
@iwiznia @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #98528
melvin-bot commentedon Aug 21, 2026
@hungvu193 you have been assigned to this deploy blocker because you authored the offending PR: #98528
melvin-bot commentedon Aug 21, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Aug 21, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Aug 21, 2026
Deploy Blocker Investigation
The auto-assigned PR #98528 is a false positive. The actual offending PR is #98654 — "Fix landscape mode on Odometer photo screen" (
GCyganek, merged 2026-08-20, merge commitdf900357fd04193a99eb90ef6f773b9e2af2848d). It's the only PR in this release that rewrote the odometer photo screen and both broken code paths.Recommended resolution: Revert #98654. It cleanly restores the previously-working capture screen; the only thing lost is a landscape-mode cosmetic fix, which is far less severe than the odometer photo flow being entirely broken on Android.
Why \#98528 is not the cause
#98528 changed exactly one file —
useAttachmentPicker.ts— whose only consumers are the chat composer (ComposerActionMenu,ComposerInput,ComposerDropZone,ReportAddAttachmentModalContent). The odometer photo screen does not use that hook at all — it uses theAttachmentPickercomponent (viaScannerControlsBar) anduseFilesValidationdirectly. #98528 got auto-assigned only because the reporter pasted its link into the issue's "regression testing" field.Root cause in \#98654 (file:line evidence)
#98654 rewrote
IOURequestStepOdometerImage/index.native.tsx— the exact screen in both scenarios — plus the crop/orientation helpers.cropImageToAspectRatio(imageObject, width, height, undefined, photo.orientation)to dropping theorientationargument atindex.native.tsx:212, and the Android orientation-aware sizing was reworked atgetDeviceOrientationAwareImageSize/index.android.ts:7-16. When the resulting crop pipeline rejects, the screen's.catchfiresshowCameraAlert()atindex.native.tsx:232-245.ScannerControlsBar(onPicked→validateFiles) atindex.native.tsx:324-333, and the readings screen it returns to was changed in the same PR from aViewto aScrollViewinIOURequestStepDistanceOdometer.tsx— matching "Odometer page becomes blank after adding photo."Confidence that #98654 is the offending PR: High (sole release PR rewriting this screen + both paths; symptom is Android-app-only, staging-not-production — consistent with a just-merged native refactor). Confidence on the precise camera throw: Medium-High (depends on device behavior on the Samsung S25 FE).
Note: I could not verify this live — it's an Android-native-only flow (the affected code is in
.native.tsxfiles using native camera/gallery), so it does not exist on web and can't be reproduced in a browser.Suggested next steps for the assignees:
GCyganek, reviewersJulesssss,truph01.index.native.tsx:212and make the crop pipeline robust to the reworked orientation sizing, then confirm the gallery return no longer renders a blank readings screen.Next Steps: Reply with
@MelvinBot implement thisto open a revert/fix PR, or@MelvinBot <your feedback>to refine this analysis.view run
3 remaining items
Beamanator commentedon Aug 21, 2026
Asking for retest since we did CP'd some reverts that fixed related issues. Reverts were:
IuliiaHerets commentedon Aug 21, 2026
XIaomi Redmi Note 10 / Android 12
App 9.4.58-2
Scenario 1: Passed
Scenario 2: reproduced
Screenrecorder-2026-08-21-22-36-09-433.mp4
IuliiaHerets commentedon Aug 21, 2026
Scenario 2: passed on prod
Screenrecorder-2026-08-21-23-24-21-76.mp4
Beamanator commentedon Aug 21, 2026
Hmm dang ok so something is still funky on the latest staging 🤔
m-natarajan commentedon Aug 21, 2026
Not repro in Pixel 4/13, v9.4.58-3
az_recorder_20260821_184138.mp4
Beamanator commentedon Aug 22, 2026
Woohoo! Closing!
[-]Android - Odometer - Blank screen/error after adding odometer photo from gallery/camera[/-][+][Due for payment 2026-10-02] Android - Odometer - Blank screen/error after adding odometer photo from gallery/camera[/+]melvin-bot commentedon Sep 25, 2026
@daledah
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.93-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-02. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]