Skip to content

[Due for payment 2026-10-02] Android - Odometer - Blank screen/error after adding odometer photo from gallery/camera #99137

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.58-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #98528
Email or phone of affected tester (no customers): sdsiodjnosdjiodsj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Money Requests

Action Performed:

Scenario 1:

  1. Launch Expensify app.
  2. Open FAB > Track distance > Odometer.
  3. Tap add odometer photo button.
  4. Add a photo from gallery.

Scenario 2:

  1. Launch Expensify app.
  2. Open FAB > Track distance > Odometer.
  3. Tap add odometer photo button.
  4. Take a photo.

Expected Result:

Scenario 1: Odometer page will not become blank.
Scenario 2: No error will show up.

Actual Result:

Scenario 1: Odometer page becomes blank after adding photo.
Scenario 2: Error shows up after taking a photo.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7238817_1787275921591.1.mp4
Bug7238817_1787275921590.2.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7238817

Issue OwnerCurrent Issue Owner: @daledah

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Aug 21, 2026
  2. melvin-bot commented on Aug 21, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #98528

  3. melvin-bot commented on Aug 21, 2026

    @melvin-bot

    @iwiznia @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #98528

  4. melvin-bot commented on Aug 21, 2026

    @melvin-bot

    @hungvu193 you have been assigned to this deploy blocker because you authored the offending PR: #98528

  5. melvin-bot commented on Aug 21, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Aug 21, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. MelvinBot commented on Aug 21, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Investigation

    The auto-assigned PR #98528 is a false positive. The actual offending PR is #98654 — "Fix landscape mode on Odometer photo screen" (GCyganek, merged 2026-08-20, merge commit df900357fd04193a99eb90ef6f773b9e2af2848d). It's the only PR in this release that rewrote the odometer photo screen and both broken code paths.

    Recommended resolution: Revert #98654. It cleanly restores the previously-working capture screen; the only thing lost is a landscape-mode cosmetic fix, which is far less severe than the odometer photo flow being entirely broken on Android.

    Why \#98528 is not the cause

    #98528 changed exactly one file — useAttachmentPicker.ts — whose only consumers are the chat composer (ComposerActionMenu, ComposerInput, ComposerDropZone, ReportAddAttachmentModalContent). The odometer photo screen does not use that hook at all — it uses the AttachmentPicker component (via ScannerControlsBar) and useFilesValidation directly. #98528 got auto-assigned only because the reporter pasted its link into the issue's "regression testing" field.

    Root cause in \#98654 (file:line evidence)

    #98654 rewrote IOURequestStepOdometerImage/index.native.tsx — the exact screen in both scenarios — plus the crop/orientation helpers.

    • Scenario 2 (camera → error): the capture call was changed from cropImageToAspectRatio(imageObject, width, height, undefined, photo.orientation) to dropping the orientation argument at index.native.tsx:212, and the Android orientation-aware sizing was reworked at getDeviceOrientationAwareImageSize/index.android.ts:7-16. When the resulting crop pipeline rejects, the screen's .catch fires showCameraAlert() at index.native.tsx:232-245.
    • Scenario 1 (gallery → blank screen): the gallery button now flows through the new ScannerControlsBar (onPicked → validateFiles) at index.native.tsx:324-333, and the readings screen it returns to was changed in the same PR from a View to a ScrollView in IOURequestStepDistanceOdometer.tsx — matching "Odometer page becomes blank after adding photo."

    Confidence that #98654 is the offending PR: High (sole release PR rewriting this screen + both paths; symptom is Android-app-only, staging-not-production — consistent with a just-merged native refactor). Confidence on the precise camera throw: Medium-High (depends on device behavior on the Samsung S25 FE).

    Note: I could not verify this live — it's an Android-native-only flow (the affected code is in .native.tsx files using native camera/gallery), so it does not exist on web and can't be reproduced in a browser.

    Suggested next steps for the assignees:


    Next Steps: Reply with @MelvinBot implement this to open a revert/fix PR, or @MelvinBot <your feedback> to refine this analysis.


    view run

  8. 3 remaining items

  9. Beamanator commented on Aug 21, 2026

    @Beamanator
    Contributor
  10. IuliiaHerets commented on Aug 21, 2026

    @IuliiaHerets

    XIaomi Redmi Note 10 / Android 12
    App 9.4.58-2
    Scenario 1: Passed
    Scenario 2: reproduced

    Screenrecorder-2026-08-21-22-36-09-433.mp4
  11. IuliiaHerets commented on Aug 21, 2026

    @IuliiaHerets

    Scenario 2: passed on prod

    Screenrecorder-2026-08-21-23-24-21-76.mp4
  12. Beamanator commented on Aug 21, 2026

    @Beamanator
    Contributor

    Hmm dang ok so something is still funky on the latest staging 🤔

  13. m-natarajan commented on Aug 21, 2026

    @m-natarajan

    Not repro in Pixel 4/13, v9.4.58-3

    az_recorder_20260821_184138.mp4
  14. Beamanator commented on Aug 22, 2026

    @Beamanator
    Contributor

    Woohoo! Closing!

  15. changed the title [-]Android - Odometer - Blank screen/error after adding odometer photo from gallery/camera[/-] [+][Due for payment 2026-10-02] Android - Odometer - Blank screen/error after adding odometer photo from gallery/camera[/+] on Sep 25, 2026
  16. melvin-bot commented on Sep 25, 2026

    @melvin-bot

    @daledah

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.93-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-02. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions