Repository navigation
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@codex review please |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49bfbaf484
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
garrettmknight
left a comment
There was a problem hiding this comment.
Looks good from a product perspective.
|
🚧 dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-08-19.at.14.44.36.movScreen.Recording.2026-08-19.at.14.48.57.movAndroid: mWeb ChromeScreen.Recording.2026-08-19.at.14.54.03.moviOS: HybridAppScreen.Recording.2026-08-19.at.14.49.22.movScreen.Recording.2026-08-19.at.14.49.49.moviOS: mWeb SafariScreen.Recording.2026-08-19.at.14.54.47.mov |
| * So we need react-native-vision-camera `orientation` to know if the image is rotated | ||
| */ | ||
| const getDeviceOrientationAwareImageSize: GetDeviceOrientationAwareImageSize = ({imageSize, orientation, aspectRatioWidth, aspectRatioHeight}) => { | ||
| const isRotated = orientation === 'portrait' || orientation === 'portrait-upside-down'; |
There was a problem hiding this comment.
Now that neither platform reads orientation, could we drop it from GetDeviceOrientationAwareImageSizeParams and stop threading it through cropImageToAspectRatio() (and photo.orientation at the call site) so the unused path doesn't linger?
There was a problem hiding this comment.
Yes, good catch! I also deleted index.ios.ts as it had the same implementation as index.ts
| forceInactive={isAttachmentPickerActive} | ||
| )} | ||
| {cameraPermissionStatus === RESULTS.GRANTED && device != null && ( | ||
| <CameraViewport |
There was a problem hiding this comment.
Would it make sense to pass didCapturePhoto here like the scan screen does, so the viewfinder goes inactive while the photo is being cropped and saved?
| </PressableWithFeedback> | ||
| ) : ( | ||
| )} | ||
| {!canUseMultiScan && shouldShowFlashButton && ( |
There was a problem hiding this comment.
Since setFlash is now optional but shouldShowFlashButton defaults to true, a consumer could render a flash button that silently does nothing — should the button only show when setFlash is provided?
There was a problem hiding this comment.
Makes sense, applied
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.58-0 🚀
|
|
🤖 No help site changes required. This PR fixes landscape-mode layout on the Odometer photo screen — camera controls/preview orientation, captured-photo dimensions matching the preview, and adding a The relevant article — Distance-Expenses.md — already documents the odometer flow accurately, including attaching a photo of your odometer, Save for later, and merging two odometer images. Nothing there is contradicted by this PR, so no draft PR was created. How I verified
@GCyganek — no help site PR was created since no documentation changes are needed. If you believe an article should be updated to cover something here, let me know and I'll draft it. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.58-4 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixes landscape mode on the odometer photo screen + issues with photo size when taken in landscape mode. Reusing components from IOURequestStepScan to make sure future changes to layout will be applied to both as they share the same layout. Also adds a
ScrollViewto the odometer reading step to make sure that theNextbutton is not cut off in landscape modeFixed Issues
$ #98623
PROPOSAL: N/A
Tests
Android & iOS:
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
screen-20260817-115404-1786960403114.mp4
Android: mWeb Chrome
iOS: Native
ScreenRecording_08-17-2026.11-40-00_1.MP4
iOS: mWeb Safari
MacOS: Chrome / Safari