Repository navigation
Trim search term before deriving the phone/email search value in useSearchSelector - #100031
Conversation
…earchSelector Co-authored-by: Eric Han <eh2077@users.noreply.github.com>
|
🤖 Android test steps verification results: ✅ pass PR #100031's search-term trim fix verified end-to-end on Android: leading/trailing-space email and phone searches still surface the invite row in both Start Chat and the Submit Expense participant picker, and selecting the padded row always yields a trimmed login.
No console errors were observed. |
|
🤖 Web test steps verification results: ✅ pass Verified on dev NewDot web: leading/trailing spaces no longer hide the email/phone invite row in Start chat and in the Submit-expense participant picker, and selecting a space-padded invite correctly opens/confirms with the trimmed value. Confirms the
No console errors were observed. |
|
@MelvinBot workspace invite new member search input has same issue, please fix it as well |
Co-authored-by: Eric Han <eh2077@users.noreply.github.com>
|
No fix needed here — The only real failure is A fix is already open: #100314 ("[No QA] Fix live Onyx hook references" by Why this is a broken
|
|
Fixed and pushed — Root cause: workspace Invite member goes through a different hook, Fix: trim once in the hook and pass the trimmed value as I also updated the PR description with the second root cause and added test steps 8-14 for the Invite member flow. Evidence chain and testsThe chain
Space-padded phone numbers were broken here too, for a second reason: this hook never called Also covered by this one change (all consumers of the hook): Tests 4 new unit tests in
|
|
Update — still nothing to fix on this branch. I re-checked; Since my earlier comment, Those are all downstream of the same undefined Current state:
To unblock this PR: get #100314 reviewed and merged, then re-run Root cause recapA semantic merge conflict between two PRs that merged cleanly at the text level:
Git saw no textual overlap, so both landed. |
|
Still nothing to fix on this branch —
The ESLint errors are downstream of the typecheck ones — when Fix is still open, not merged: #100314 ("[No QA] Fix live Onyx hook references" by Why this is a broken
|
|
@MelvinBot pull main |
Co-authored-by: Eric Han <eh2077@users.noreply.github.com>
|
🤖 Pulled Merge commit: |
Fixed Issues$ #99419 TestsSame as QA steps
Offline testsSame as QA steps QA Steps
PR Author Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / Safari |
|
@MelvinBot apply #100031 (comment) to update PR description, and then mark PR as ready for review |
|
🤖 Done.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-07.at.10.15.14.PM.movAndroid: mWeb ChromeScreen.Recording.2026-09-07.at.10.14.00.PM.moviOS: HybridAppScreen.Recording.2026-09-07.at.10.12.21.PM.moviOS: mWeb SafariScreen.Recording.2026-09-07.at.10.10.30.PM.movMacOS: Chrome / SafariScreen.Recording.2026-09-07.at.9.47.30.PM.mov |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product.
|
@mountiny it's your call, thx! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.75-0 🚀
|
|
🤖 No help site changes are required for this PR. This is an internal bug fix, not a behavior or copy change. It trims leading/trailing whitespace from the search term before The help site already documents the intended behavior this PR restores:
— Why no article needs editingWhat changed (source only, plus tests):
Docs criteria checked:
I also checked the other articles that reference Start chat — Because no changes are required, I did not create a draft help site PR, so there is nothing to label @eh2077, please confirm you agree that no help site update is needed here. If you'd rather I document something specific (for example, an FAQ entry about pasting an email with extra spaces), reply with |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.75-3 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.75-3 🚀
Bundle Size Analysis (Sentry): |




















Fixed Issues
$ #99419
PROPOSAL: #99419 (comment)
Tests
Same as QA steps
Offline tests
Same as QA steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari