[Payment due @ahmedGaber93] [No QA] Rename originalUseOnyx to useOnyxWithoutSnapshots by MelvinBot · Pull Request #100200 · Expensify/App

MelvinBot · 2026-09-02T16:15:22Z

Explanation of Change

Pure identifier rename: originalUseOnyx → useOnyxWithoutSnapshots, everywhere it appears in the app. No behavior change.

tgolen raised this in a review comment on #99279: "'Original Onyx' doesn't really make sense, how about renaming it to useOnyxWithoutSnapshots?" That PR renamed the one occurrence it introduced, and ahmedGaber93 asked for the rest of the app to follow in a separate PR — this one.

Why the new name is better: the alias exists to distinguish the raw react-native-onyx useOnyx from our snapshot-aware wrapper at src/hooks/useOnyx.ts. "Original" says nothing about that distinction; "without snapshots" names exactly what the caller is opting out of.

Scope: 13 files, 55 occurrences, all of them the import alias import {useOnyx as originalUseOnyx} and its call sites.

Two spots needed more than a find-and-replace:

src/hooks/useOnyx.ts — the type alias OriginalUseOnyx (which is just typeof originalUseOnyx) was renamed to UseOnyxWithoutSnapshots to stay consistent. It still annotates the exported snapshot-aware useOnyx, exactly as OriginalUseOnyx did before.
tests/ui/CategoryPickerTest.tsx — the local mockedOriginalUseOnyx variable and the comment that names the alias in backticks were updated too, since both are direct references to the old name.

Deliberately left alone — please confirm this is what you want. Several files carry a prose comment above the import reading // Use the original useOnyx hook to get the real-time data from Onyx and not from the snapshot. I did not touch those, because ahmedGaber93 asked for that exact wording word-for-word only hours ago. The word "original" therefore still appears in comments even though the identifier is gone. Say the word and I'll reword them in a follow-up commit.

Automated checks run locally

npm run typecheck — passed
npm run lint-changed — passed
npm run react-compiler-compliance-check check on the 12 changed source files — passed
npm run spell-changed — 13/13 files, 0 issues
npm test tests/ui/CategoryPickerTest.tsx — 3/3 passed
npm test tests/unit/inlineEditing — 43/43 passed

Fixed Issues

$
PROPOSAL:

Tests

N/A.

Offline tests

N/A.

QA Steps

N/A.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>

MelvinBot · 2026-09-02T16:15:56Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-renameOriginalUseOnyx
git checkout -b claude-renameOriginalUseOnyx upstream/claude-renameOriginalUseOnyx
git push -u origin claude-renameOriginalUseOnyx

Then you can close this PR and open a new one from your fork.

codecov · 2026-09-02T16:20:09Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/CategoryPicker/index.tsx	`97.29% <100.00%> (ø)`
...c/components/ReportActionItem/MoneyRequestView.tsx	`78.95% <100.00%> (ø)`
...ponents/Search/SearchList/ListItem/GroupHeader.tsx	`76.85% <100.00%> (ø)`
...earch/SearchList/ListItem/ReportListItemHeader.tsx	`91.13% <100.00%> (ø)`
...h/SearchList/ListItem/TransactionGroupListItem.tsx	`75.73% <100.00%> (ø)`
...arch/SearchList/ListItem/useLiveRowCapabilities.ts	`100.00% <100.00%> (ø)`
...nents/Search/hooks/useLiveFilteredReportActions.ts	`100.00% <100.00%> (ø)`
src/hooks/useOnyx.ts	`100.00% <100.00%> (ø)`
src/hooks/useShortMentionsList.ts	`100.00% <100.00%> (ø)`
src/hooks/useTransactionInlineEdit.ts	`0.00% <0.00%> (ø)`
... and 2 more
... and 12 files with indirect coverage changes

Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>

MelvinBot · 2026-09-02T16:31:37Z

🤖 Android test steps verification results: ✅ pass

All 6 checks passed on standalone Android NewDot. The PR's Tests section is still a TODO placeholder, so its only documented step is the JS-console check — I ran that plus smoke coverage of every surface the rename touches (Search list items, MoneyRequestView, CategoryPicker, mentions). The test account had no seeded data, so I created one cash expense ($42.00, "Test Merchant", category "Car") to exercise them.

Step	Status
No errors appear in the JS console (the PR's only documented test step) adb logcat (full buffer, ~13k ReactNativeJS lines from app launch through end of test) contains zero `[error]`-tagged ReactNativeJS lines and no FATAL EXCEPTION / AndroidRuntime crashes. Only warnings seen were pre-existing "Reanimated: Writing to `value` during component render" notices, unrelated to this rename.	✅
App launches and the signed-in inbox/LHN renders without a crash or error screen Home screen rendered normally with bottom nav (Home/Inbox/Spend/Workspaces/Account), Getting Started card, and Concierge prompt box.	✅
Search renders its list of results Search > Expenses tab showed tab headers (Expenses/Reports/Spend over time/Top categories), filter chips, and a populated row: "Melvin Bot, Test Merchant, $42.00, Sep 2 • Car, Cash".	✅
Opening an expense shows the expense details view with its fields populated MoneyRequestView opened showing Amount • Cash • Reimbursable = $42.00, Merchant = Test Merchant, Date = 2026-09-02, Category = Car.	✅
The category picker opens from the expense details and lists categories Category picker listed Advertising, Benefits, Car, Equipment, Fees, Home Office, Insurance, Interest, Labor, Maintenance, Materials, with a working search field.	✅
Typing @ in a report composer shows the mention suggestion list Typing "@" in the expense-report composer opened a mention list with "@here – Notify everyone in this conversation", Concierge, Melvin Bot, and qa.guide@team.expensify.com.	✅

Scope note: verified on standalone Android NewDot (developmentDebug APK), not the HybridApp shell. useTransactionInlineEdit was exercised only indirectly through the expense details view.

view run · view recording

MelvinBot · 2026-09-02T16:33:27Z

Fixed the Oxfmt check failure — pushed in 424cba8.

The rename made two lines longer than the 190-char printWidth in .oxfmtrc.json, so oxfmt wanted to re-wrap them. useOnyxWithoutSnapshots is 9 characters longer than originalUseOnyx, which pushed both over the limit:

src/components/Search/SearchList/ListItem/ExpenseReportListItem.tsx:237 — was 192 chars
src/components/Search/hooks/useLiveFilteredReportActions.ts:23 — was 191 chars

The fix is npm run fmt output only — the trailing options object is now hugged onto its own lines. No code changed, 6 insertions / 2 deletions of pure re-wrapping. Oxfmt check now passes.

Two remaining red checks, neither actionable here:

test (job 3) — tests/unit/NextStepUtilsTest.ts › monthly on the 2nd is a calendar-dependent flake that fails only on the 2nd of the month, which today is. It expected 2026-10-02 and got 2026-09-02. Already tracked as #100134 ("fails on the 2nd of every month, blocking all PR CI"). Neither that test nor DateUtils is touched by this PR, and the job passed on the previous commit before the calendar rolled over. Left it alone rather than papering over it.

Check independent approval — needs a human reviewer, nothing to fix in the code.

Verification run locally

Reproduced the exact CI step (npm run fmt then git diff --exit-code) — fails before the commit, passes after
npm run typecheck — passed
npx eslint on both changed files — 0 errors (5 pre-existing eslint-seatbelt warnings, unchanged)
npm run react-compiler-compliance-check check on both files — passed
npm run spell on both files — clean
npm test tests/ui/components/Search/ExpenseReportListItemAvatarTest.tsx — 7/7 passed

npm run lint-changed couldn't run — the checkout is shallow and git merge-base against origin/main fails, so I ran eslint directly on the two files instead.

view run

MelvinBot · 2026-09-02T16:41:10Z

Nothing new to fix on this PR — the one check I could fix is green, and the other red check isn't this PR's.

Oxfmt check was the real failure and it's passing since 424cba8. typecheck, ESLint check, Bun tests, React Compiler Compliance, spellcheck and test jobs 1–2 and 4–8 are all green too.

test (job 3) is an org-wide calendar flake, not a regression here. I reproduced it locally on this branch just now and traced the exact mechanism:

src/libs/DateUtils.ts:1291 guards with if (day < nth). Today is the 2nd and the test uses nth = 2, so 2 < 2 is false and the helper rolls forward to 2026-10-02, while the production code correctly returns today, 2026-09-02. The test's expectation is built from that helper at tests/unit/NextStepUtilsTest.ts:290 off a live new Date(), so it disagrees with production exactly once a month.

Neither file is in this PR's 13-file diff, and both are byte-identical to main — so merging main in would not help. Per the rule against fixing unrelated flakes, I left it alone rather than patching an unrelated test into a pure rename PR.

To unblock, one of:

Reopen [No QA] Make the monthly automatic-submit eta deterministic on the offset day #100145 — the fix for this, closed unmerged today at 12:29 UTC. Its branch claude-nextStepMonthlyEtaFlakyTest is intact at dba210d, test-only, and was verified green on the 2nd. I don't have permission to reopen it.
Re-run test (job 3) after 00:00 UTC (about 7 hours from now). It passes on its own on the 3rd — and breaks again on 2026-10-02. Tracked in NextStepUtilsTest 'monthly on the 2nd' fails on the 2nd of every month, blocking all PR CI #100134.

Check independent approval just needs a human reviewer; there's nothing to fix in the code.

Local reproduction

Run on this branch at 424cba8, working tree clean:

npm test -- tests/unit/NextStepUtilsTest.ts -t "monthly on the 2nd"

  ● buildNextStep › scheduled submit enabled › monthly on the 2nd
    - Expected  "dateTime": "2026-10-02"
    + Received  "dateTime": "2026-09-02"

Tests: 1 failed, 45 skipped, 46 total

Confirmed main still contains the same assertion and the same day < nth helper, so the failure is reproducible on any PR branch today.

view run

MelvinBot · 2026-09-02T16:45:18Z

🤖 Web test steps verification results: ⚠️ partial

Four of six checks passed cleanly on web — the app loads, Search renders result rows, the expense details view (MoneyRequestView) shows populated fields, and @ opens the mention suggestion list. Two checks came back short of proof, both for environment reasons rather than PR behavior: the browser JS console isn't directly inspectable through the web test tooling, and the test account's free personal workspace gates categories behind an upgrade prompt, so the category list itself never rendered. The PR's Tests section is still a TODO placeholder, so its only documented step is the JS-console check — I ran that plus smoke coverage of every surface the rename touches.

Step	Status
No errors appear in the JS console (the PR's only documented test step) Not directly verified — the web test tooling has no supported console/devtools command, so the browser console was never read. As a proxy, a 60s network dump across the whole drive showed zero 4xx/5xx responses, and no error banners, error boundaries, or crash screens appeared in any snapshot. That is weaker evidence than an actual console read, so treat this step as unproven.	⚠️
App loads and the signed-in inbox/LHN renders without a crash or error screen Home and then Inbox rendered normally: LHN list showing the Expensify Concierge conversation, chat pane with welcome message and composer, no error UI.	✅
Search renders its list of results The fresh test account had no seeded expenses, so Expenses/Reports showed a normal "no results yet" empty state. Switching the Search type to Chat returned a real row ("In Concierge" / Concierge welcome message) under a Chats heading, confirming the list view renders rows and headers rather than a blank or error state.	✅
Opening an expense shows the expense details view with its fields populated Created a manual expense ($25.00, "Test Merchant") and opened it. MoneyRequestView rendered with Amount • Cash $25.00, Description, Merchant = Test Merchant, Date = 2026-09-02, Category, and Report.	✅
The category picker opens from the expense details and lists categories Not verified — tapping Category navigated cleanly (no crash or error) but landed on an Upgrade prompt, because this account's free personal workspace has Categories gated behind a paid plan. The category list itself was never rendered, so this surface is untested on web. It did render a full category list on the Android run of the same PR.	⚠️
Typing @ in a report composer shows the mention suggestion list Typing "@" in the expense report composer opened the suggestion list with "Notify everyone in this conversation" (@here), Expensify Concierge, and the test user's own mention.	✅

Scope note: useTransactionInlineEdit was exercised only indirectly through the expense details view. To close the two gaps, the JS console needs a manual check and the category picker needs an account on a workspace with Categories enabled.

view run · no recording available

ahmedGaber93 · 2026-09-02T16:47:48Z

@MelvinBot rename this PR title to

[No QA] Rename originalUseOnyx to useOnyxWithoutSnapshots

ahmedGaber93 · 2026-09-02T16:49:06Z

@MelvinBot Please update