Repository navigation
[No QA] Docs updates for E/A#99992 document Paid by column and filter - #100057
Conversation
Follow-up to #99992. Documents the Paid by column and the paid-by search operator, corrects the column customization steps to Display > Edit columns, and removes a duplicated Paid status bullet. Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>
MelvinBot
added
the
HelpDot
github-actions
Bot
changed the title
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot check all boxes of the checklist and mark the PR as ready for review. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@kadiealexander Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Done — all 40 checklist boxes are checked and the PR is out of draft and ready for review. Two things worth flagging:
I also removed the now-satisfied handoff note at the bottom of the description that asked you to reply with The only failing check is |
|
➤ HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1db2ab5303
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| 1. Go to the **Spend** tab on the left (web only). | ||
| 2. Run a search or apply filters if needed. | ||
| 3. Click the **Columns** icon (next to **Filters**). | ||
| 3. Click **Display**, then select **Edit columns**. |
There was a problem hiding this comment.
The embedded Filter-reports.png still shows the obsolete Columns control beside Filters, has no Display control, and omits the newly documented Paid by filter. When readers use the screenshot to locate these controls, it directly contradicts the corrected navigation in this step, so the screenshot should be updated or removed.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Confirmed and fixed in bf59135.
The screenshot was genuinely stale. Opening the asset shows a Columns control sitting next to Filters in the toolbar, and a filter panel with only Type, From, Keywords, Status, To, Workspace, Action, and Approved — no Paid status, no Paid by. That contradicts both the corrected step 3 and the new Paid by filter bullet.
What I changed:
- Removed the
Filter-reports.pngembed and replaced it with a non-rendered<!-- SCREENSHOT: -->request at Using-Reports-in-New-Expensify.md:50, describing the exact UI state to capture.docs/HELP_AUTHORING_GUIDELINES.mdSection 8 has authors suggest screenshots this way rather than embed self-captured ones, and a capture from a Melvin test account on a dev build isn't a publishable help-site asset. - Found two more stale Columns references the original commit missed, both in the FAQ: line 214 and line 217. Both now point at Display → Edit columns.
I left docs/assets/images/Filter-reports.png in the repo so a refreshed capture can drop in at the same path without touching the article's asset URL. cspell passes on the changed file.
…s references The embedded Filter-reports.png showed a Columns control that no longer exists and a filter list without Paid status or Paid by, contradicting the corrected navigation in this article. Replace it with a SCREENSHOT request per the authoring guidelines, and correct the two FAQ answers that still pointed at the Columns icon and panel. Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://bc32bd87.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Help site follow-up to #99992, which fixed the Paid by column so it resolves the payer from live report actions (the column previously stayed blank after paying from Spend until the search was re-run) and moved the Paid by filter down next to Paid status.
Neither the Paid by column nor the
paid-by:search operator was documented anywhere on the help site, and the one article that covers Spend columns had stale navigation. This PR closes those gaps.docs/articles/new-expensify/reports-and-expenses/Using-Reports-in-New-Expensify.mddocs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.mdpaid-by:operator in both the expenses and the reports operator lists. It is a real, shipped operator (CONST.SEARCH.SYNTAX_FILTER_KEYS.PAID_BY→paid-by) backed by a user picker, and it was missing from both lists.How the UI labels were verified
Every label in this PR was read off the live NewDot web UI rather than inferred from code, per
docs/HELPSITE_NAMING_CONVENTIONS.md:There is no Paid date filter in the Reports view — only a generic Date filter — so the article does not mention one.
Not changed: this article predates the current authoring spec and uses several top-level
#headings, whichdocs/HELP_AUTHORING_GUIDELINES.mdSection 4 disallows. Restructuring it is out of scope for a fix follow-up and would bury these corrections in a rewrite.Fixed Issues
$
PROPOSAL:
Documentation follow-up to #99992. No separate issue to link.
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — help site content only. No app code is changed.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari