Repository navigation
[No QA] Docs updates for E/A#98326 Document Paid by search filter - #99963
Conversation
Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Bump on this @c3024! |
|
🤖 Web test steps verification results: While we wait on Code check of each claim in the diff
view run · no recording available |
|
@MelvinBot please merge main and resolve the conflicts. Drop the change to Using-Reports-in-New-Expensify.md, because PR 100057 already documents the Paid by column there. In Use-Search-Operators-to-Filter-and-Analyze.md, the report operators are now a table, so add paid-by: as a table row directly after paid-status:, keeping the same content. |
Resolve conflicts in the two help articles: - Using-Reports-in-New-Expensify.md: drop this PR's Paid by column change entirely and take main, since PR 100057 already documents the Paid by column and filter there. - Use-Search-Operators-to-Filter-and-Analyze.md: main converted the report operator list into a table, so re-add paid-by: as a table row directly after paid-status:, keeping the same content. Keywords keep both main's additions and this PR's.
|
Merged What I did:
The full remaining diff is the two lines below: -keywords: [..., transaction status filter, pending card expenses, posted card expenses]
+keywords: [..., transaction status filter, pending card expenses, posted card expenses, paid by filter, paid-by]
| `paid-status:` | Filter by how the report was paid (`markedAsPaid`, `withdrawing`, `confirmed`). Combine multiple values with commas | `paid-status:markedAsPaid,confirmed` |
+| `paid-by:` | Filter by the member who paid the report (email, phone, display name, or `me`). Combine multiple members with commas. Reports that have not been paid never match. This operator also works on expense, invoice, and trip searches | `paid-by:me,alice@acme.com` |
| `action:` | Filter by blocking report action | `action:approve` |Merge and test detailsMerge commit I could not run No docs were added or removed, so The Tests and QA Steps sections in the PR body are still the human-only TODOs — I did not fill those in.
|
|
@MelvinBot mark the PR as ready for review. |
|
A preview of your ExpensifyHelp changes have been deployed to https://37929090.helpdot.pages.dev ⚡️ Updated articles: |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@Kel-Expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Marked as ready for review. ✅ I also corrected two things that went stale after the
Checks: everything passes except I did not run an app test — this PR only changes a markdown help article, so there's no app behavior to verify. The Current state
I left the Tests and QA Steps sections alone — those are yours to fill in, and both still carry the |
|
HelpDot Documentation Review test placeholder |
|
@stephanieelliott, I verified the changes. Please have a look. |
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.95-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.95-4 🚀
|





Explanation of Change
Help site follow-up for #98326, which added a
paid-by:search filter. It was undocumented, so members had no way to discover the operator from the help site.One article changes:
docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md— adds apaid-by:row to the report operator table, including that values can be combined with commas, that unpaid reports never match, and that the operator also works on expense, invoice, and trip searches. Placed directly afterpaid-status:so the payment-related operators stay together. Keywords were extended so searches for "paid by" reach the article.This PR originally also documented the Paid by column in
Using-Reports-in-New-Expensify.md. That change was dropped whenmainwas merged, because #100057 already documents the Paid by column and filter in that article.Labels were verified against the live app on web:
paid-by:is accepted in the search bar and the Filters row is labeled exactly Paid by.No new article was created — the change extends an existing table, so the one-workflow-per-article rule in
docs/HELP_AUTHORING_GUIDELINES.mdis unaffected. No headings were added or changed, and no screenshots are needed.Fixed Issues
$ #98326
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari