Skip to content

[No QA] Docs updates for E/A#99754 Wallet and Workflows connection status badges - #100232

Closed
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-wallet-connection-status
Closed

MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-wallet-connection-status

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

#99754 removed the walletConnectionStatus beta gate, so bank account and card connection statuses are now shown to everyone on Settings > Wallet and on Workspaces > [Workspace name] > Workflows. That PR also deleted the common.actionRequired copy from every language file, so the Action required badge no longer exists anywhere in the product.

Three help articles still told members to look for that retired badge, and nothing documented the statuses that replaced it. This PR fixes the stale copy and documents the new behavior.

New article

  • docs/articles/new-expensify/wallet-and-payments/Check-Bank-Account-and-Card-Connection-Status.md — explains every bank account badge (Active, Incomplete, Pending, Verifying, Locked) and card badge (Active, Inactive), the message and action button that appears under each row, and the Synced [time] / Never synced line on card rows.

Corrected stale copy

  • Validate-a-Business-Bank-Account.md — the account awaiting test transactions now shows a Pending badge with Please confirm test transactions and a Confirm button, not Action required. Also corrected the locked-account text to the actual Unlock button, and flagged that the two ExpensifyHelp-BetterBusinessBankAccount images still show the retired badge.
  • Connect-a-Business-Bank-Account.md — partially set-up accounts now show Incomplete with Finish adding bank account and a Finish button.
  • Share-a-Business-Bank-Account.md — a shared US account now shows Pending with Please confirm test transactions.

Documented the now-GA behavior

  • Workspace-Workflows.md — added a section covering the payment account status badge under Payments, and corrected the button label to Add bank account (verified against the live UI; the article said Connect Bank Account).
  • Manage-Personal-Cards.md — added the Active / Inactive badge, the sync line, and the Please fix this connection / Your bank connection needs to be re-authenticated messages.
  • Fix-a-Broken-Company-Card-Feed-Connection.md — added what card assignees see in Wallet when a feed breaks (Please fix this connection in company cards for admins, Please ask an admin to fix this connection for everyone else).
  • Set-up-your-wallet.md — replaced the vague "error badge" wording with the real badge names.

Every label was taken from src/languages/en.ts on the merged commit. Section and button names (Bank accounts, Cards, Payments, Add bank account) were confirmed against the live web UI.

AI Tests

Ran on this branch (markdown-only changes):

  • npm run createDocsRoutes — passed, no route changes needed.
  • npm run spell-changed — passed, 8 files checked, 0 issues.
  • npm run lint-changed — no lintable files changed.

Not applicable to markdown-only changes: npm run typecheck, npm test, npm run storybook --smoke-test, npm run react-compiler-compliance-check.

Fixed Issues

$ #91300
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@marufsharifi, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

… all users

Co-authored-by: Maruf Sharifi <marufsharifi@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 2, 2026 23:03
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 2, 2026
@MelvinBot MelvinBot mentioned this pull request Sep 2, 2026
40 tasks done
@github-actions github-actions Bot changed the title Docs updates for E/A#99754 Wallet and Workflows connection status badges [No QA] Docs updates for E/A#99754 Wallet and Workflows connection status badges Sep 2, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

Handling in #101954

hungvu193 pushed a commit to hungvu193/App that referenced this pull request Sep 25, 2026
truph01 pushed a commit to truph01/App that referenced this pull request Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants