Repository navigation
Conversation
… all users Co-authored-by: Maruf Sharifi <marufsharifi@users.noreply.github.com>
40 tasks done
Contributor
This was referenced Sep 23, 2026
Contributor
|
Handling in #101954 |
hungvu193
pushed a commit
to hungvu193/App
that referenced
this pull request
Sep 25, 2026
…nsify/wallet-and-payments
truph01
pushed a commit
to truph01/App
that referenced
this pull request
Sep 28, 2026
…nsify/workspaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
#99754 removed the
walletConnectionStatusbeta gate, so bank account and card connection statuses are now shown to everyone on Settings > Wallet and on Workspaces > [Workspace name] > Workflows. That PR also deleted thecommon.actionRequiredcopy from every language file, so the Action required badge no longer exists anywhere in the product.Three help articles still told members to look for that retired badge, and nothing documented the statuses that replaced it. This PR fixes the stale copy and documents the new behavior.
New article
docs/articles/new-expensify/wallet-and-payments/Check-Bank-Account-and-Card-Connection-Status.md— explains every bank account badge (Active, Incomplete, Pending, Verifying, Locked) and card badge (Active, Inactive), the message and action button that appears under each row, and the Synced [time] / Never synced line on card rows.Corrected stale copy
Validate-a-Business-Bank-Account.md— the account awaiting test transactions now shows a Pending badge with Please confirm test transactions and a Confirm button, not Action required. Also corrected the locked-account text to the actual Unlock button, and flagged that the twoExpensifyHelp-BetterBusinessBankAccountimages still show the retired badge.Connect-a-Business-Bank-Account.md— partially set-up accounts now show Incomplete with Finish adding bank account and a Finish button.Share-a-Business-Bank-Account.md— a shared US account now shows Pending with Please confirm test transactions.Documented the now-GA behavior
Workspace-Workflows.md— added a section covering the payment account status badge under Payments, and corrected the button label to Add bank account (verified against the live UI; the article said Connect Bank Account).Manage-Personal-Cards.md— added the Active / Inactive badge, the sync line, and the Please fix this connection / Your bank connection needs to be re-authenticated messages.Fix-a-Broken-Company-Card-Feed-Connection.md— added what card assignees see in Wallet when a feed breaks (Please fix this connection in company cards for admins, Please ask an admin to fix this connection for everyone else).Set-up-your-wallet.md— replaced the vague "error badge" wording with the real badge names.Every label was taken from
src/languages/en.tson the merged commit. Section and button names (Bank accounts, Cards, Payments, Add bank account) were confirmed against the live web UI.AI Tests
Ran on this branch (markdown-only changes):
npm run createDocsRoutes— passed, no route changes needed.npm run spell-changed— passed, 8 files checked, 0 issues.npm run lint-changed— no lintable files changed.Not applicable to markdown-only changes:
npm run typecheck,npm test,npm run storybook --smoke-test,npm run react-compiler-compliance-check.Fixed Issues
$ #91300
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@marufsharifi, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.