Repository navigation
[No QA] Consolidated help docs: new-expensify/wallet-and-payments - #101954
VictoriaExpensify merged 12 commits into
Conversation
…et-and-payments
…let-and-payments
…let-and-payments
…let-and-payments
…let-and-payments
…let-and-payments
…let-and-payments
…let-and-payments
…let-and-payments
HelpDot Documentation ReviewOverall AssessmentThis PR consolidates 9 help doc updates for Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9617ec553c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| | Badge | What it means | What appears below the row | | ||
| |-------|---------------|-----------------------------| | ||
| | **Active** | The card is connected and importing transactions. | Nothing. | | ||
| | **Inactive** | The connection is broken, so transactions have stopped importing. | A message that depends on the card, described below. | |
There was a problem hiding this comment.
An Expensify Card can show Inactive because it is suspended, even though it has no bank connection to break; getCardConnectionStatusDisplay() deliberately emits that badge without a connection message in this case. Describing every Inactive card as a broken import connection with a message sends suspended-card users toward irrelevant feed troubleshooting and also contradicts the later explanation that Expensify Cards do not connect to a bank.
Useful? React with 👍 / 👎.
| - **Please fix this connection in company cards** — a company card on a workspace you administer. The link opens **Company cards** for that workspace. | ||
| - **Please ask an admin to fix this connection** — a company card on a workspace you do not administer. | ||
|
|
||
| To reconnect a company card feed, [learn how to fix a broken company card feed connection](/articles/new-expensify/connect-credit-cards/Fix-a-Broken-Company-Card-Feed-Connection). |
There was a problem hiding this comment.
This route has no corresponding article anywhere under docs/articles; the relevant pages are under connect-credit-cards/fix-card-connection-issues/, such as Fix-a-Card-Connection-Error.md. As written, users following the new troubleshooting link reach a missing page rather than the company-card recovery guidance.
Useful? React with 👍 / 👎.
| 1. In the navigation tabs (on the left on web, on the bottom on mobile), click **Workspaces > [Workspace name]**. | ||
| 2. Select **Invoices**. | ||
| 3. In the **Bank accounts** section, select **Add bank account**. |
There was a problem hiding this comment.
A Payments Admin—the audience declared for this article—cannot complete this step: the Invoices page and add-account handler require write access to MORE_FEATURES, while the Payments Admin role only has write access to WORKFLOWS_PAYMENTS; selecting Add bank account therefore opens the read-only fallback. State that this invoice-specific flow requires a Workspace Admin, or direct Payments Admins to the Workflows flow instead.
Useful? React with 👍 / 👎.
…ount-and-Card-Connection-Status.md
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stephanieelliott
added
the
HelpDot
|
🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.4.94-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |
Summary
Consolidates 9 help doc PRs for
new-expensify/wallet-and-paymentsinto a single reviewable PR.Included PRs
Test plan