Repository navigation
Conversation
Co-authored-by: Eugene Voloshchak <eVoloshchak@users.noreply.github.com>
44 tasks done
3 tasks
Contributor
|
Handling in #101954 |
hungvu193
pushed a commit
to hungvu193/App
that referenced
this pull request
Sep 25, 2026
…nsify/wallet-and-payments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for #94075, which changed bulk Pay behavior in the Reports view.
Three behaviors in that PR were either undocumented or contradicted the existing help site copy, so
docs/articles/new-expensify/wallet-and-payments/Reimbursement-Payment-Methods.mdis updated:1. Paying every report matching a search (new
##section). The PR adds aQueueBulkPayReportscommand and now offers Pay when Select all is used, where previously only Export appeared. The backend pages through every matching report, so this can pay reports that were never on screen. When Select all is used the code forcesonlyShowPayElsewhere, so Mark as paid is the only payment option — that constraint is documented, along with the distinction between Select all and Select all on this page.2. Partial selections (new
##section).getPayOptionno longer requires every selected report to be payable; Pay now shows when at least one is, and only the payable reports are paid. The held-expense gate also narrowed — a held expense now blocks Pay only when it belongs to a report being paid. Neither was documented.3. Corrected button labels in the existing bulk section. The article told admins to select Selected (the button renders as
<count> selected) and to choose Pay elsewhere in the Pay dropdown, but that option is labeled Mark as paid in New Expensify. Labels were verified againstsrc/languages/en.ts(iou.payElsewhere,workspace.common.selected,search.exportAll.selectAllOnThisPage,workspace.people.selectAll) and theMark as paidwording matches the existing Pay-Expenses article.Applied
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: both new headings are task-based and searchable (How to pay every report matching a search in bulk,What happens when some selected reports cannot be paid), only##is used with no###, button and tab names are bolded in sentence case matching the UI, navigation uses the unified web/mobile sentence, no Liquid includes or collapsible FAQ sections were added, no full URLs were added inside the article, and the one screenshot suggestion is a non-rendered<!-- SCREENSHOT: -->comment with a stated purpose.keywordsandinternalScopewere extended to cover bulk pay.Note for the reviewer: the single-report section of the same article still says Pay elsewhere where the New Expensify dropdown reads Mark as paid. That predates #94075, so it was left alone rather than widening this PR — flagging it in case you want it fixed here.
Verification limits: the labels above come from the source strings, not the running app. The web tester confirmed the left nav (Spend with Expenses and Reports sub-tabs) but could not reach the bulk-pay UI — the test account has no workspaces and Reports is behind a Collect-plan upgrade wall, so no report rows exist to select. Please confirm the Select all / Mark as paid strings and the partial-selection behavior against a real workspace.
Fixed Issues
$ #93699
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
Not applicable — this PR only changes help site markdown.
QA Steps
[No QA] — documentation-only change to
docs/articles.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@eVoloshchak, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.