Skip to content

Docs updates for E/A#94075 bulk pay select-all and partial report selections - #100748

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsBulkPaySelectAllReports
Closed

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsBulkPaySelectAllReports

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for #94075, which changed bulk Pay behavior in the Reports view.

Three behaviors in that PR were either undocumented or contradicted the existing help site copy, so docs/articles/new-expensify/wallet-and-payments/Reimbursement-Payment-Methods.md is updated:

1. Paying every report matching a search (new ## section). The PR adds a QueueBulkPayReports command and now offers Pay when Select all is used, where previously only Export appeared. The backend pages through every matching report, so this can pay reports that were never on screen. When Select all is used the code forces onlyShowPayElsewhere, so Mark as paid is the only payment option — that constraint is documented, along with the distinction between Select all and Select all on this page.

2. Partial selections (new ## section). getPayOption no longer requires every selected report to be payable; Pay now shows when at least one is, and only the payable reports are paid. The held-expense gate also narrowed — a held expense now blocks Pay only when it belongs to a report being paid. Neither was documented.

3. Corrected button labels in the existing bulk section. The article told admins to select Selected (the button renders as <count> selected) and to choose Pay elsewhere in the Pay dropdown, but that option is labeled Mark as paid in New Expensify. Labels were verified against src/languages/en.ts (iou.payElsewhere, workspace.common.selected, search.exportAll.selectAllOnThisPage, workspace.people.selectAll) and the Mark as paid wording matches the existing Pay-Expenses article.

Applied docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: both new headings are task-based and searchable (How to pay every report matching a search in bulk, What happens when some selected reports cannot be paid), only ## is used with no ###, button and tab names are bolded in sentence case matching the UI, navigation uses the unified web/mobile sentence, no Liquid includes or collapsible FAQ sections were added, no full URLs were added inside the article, and the one screenshot suggestion is a non-rendered <!-- SCREENSHOT: --> comment with a stated purpose. keywords and internalScope were extended to cover bulk pay.

Note for the reviewer: the single-report section of the same article still says Pay elsewhere where the New Expensify dropdown reads Mark as paid. That predates #94075, so it was left alone rather than widening this PR — flagging it in case you want it fixed here.

Verification limits: the labels above come from the source strings, not the running app. The web tester confirmed the left nav (Spend with Expenses and Reports sub-tabs) but could not reach the bulk-pay UI — the test account has no workspaces and Reports is behind a Collect-plan upgrade wall, so no report rows exist to select. Please confirm the Select all / Mark as paid strings and the partial-selection behavior against a real workspace.

Fixed Issues

$ #93699
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable — this PR only changes help site markdown.

QA Steps

[No QA] — documentation-only change to docs/articles.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@eVoloshchak, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Eugene Voloshchak <eVoloshchak@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 9, 2026 19:56
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 9, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

Handling in #101954

hungvu193 pushed a commit to hungvu193/App that referenced this pull request Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants