Repository navigation
Conversation
…t flow Co-authored-by: Jan Musiał <jmusial@users.noreply.github.com>
The Check validateCode terminology CI job requires user-facing copy to say 'security code'. The Validate your account screen renders contacts.enterSecurityCode, which says 'security code', so this also matches what members actually see. Co-authored-by: Jan Musiał <jmusial@users.noreply.github.com>
|
Fixed and pushed — What broke: the new copy in Fix: replaced "magic code" with "security code" in four places (keywords, US step 3, and the FAQ heading and body). This also matches what members actually see: the Validate your account screen renders Ran
Evidence (1)Recordings- [▶ Session recording of the verification run](https://melvinbot-assets.exops.io/session-33428915515-1-f2881b6c-1577-41bc-a18e-690b2795286f.webm) |
|
A preview of your ExpensifyHelp changes have been deployed to https://bd80232a.helpdot.pages.dev ⚡️ Updated articles: |
@jmusial bump on this! |
|
🤖 Web test steps verification results:
One thing to know before you flip it ready: the About the sign-out during testingAfter clicking Add bank account, the test session fired |
|
Handling in #101954 |
…sify/wallet-and-payments


Explanation of Change
Help site follow-up to #99431, which fixed the international deposit account US flow so an unvalidated user who validates mid-flow lands on the Log into your bank / Connect manually choice instead of dropping straight into Plaid.
docs/articles/new-expensify/wallet-and-payments/Connect-a-Personal-Bank-Account.mdalready described that choice, so the fix brings the app back in line with the docs. What the article never covered is the account validation step itself, which is a real, working part of the US flow now that its destination is correct. Clicking Add bank account in the Wallet routes an unvalidated member to a Validate your account magic code screen before the flow continues.Changes:
Why am I asked for a magic code when I add a bank account?, so the question is retrievable on its own.docs/HELPSITE_NAMING_CONVENTIONS.md: Add Bank Account → Add bank account, and Bank Accounts → Bank accounts in three places.validate your account,magic code,log into your bank, andconnect manuallyto the article keywords.All labels were verified against
src/languages/en.tsand the components that render them, not from memory:Add bank account— src/languages/en.ts:3888Bank accounts— src/languages/en.ts:424Log into your bank/Connect manually— src/languages/en.ts:3890-3891, rendered by AccountFlowEntryPoint.tsx:115-123Where's your bank account located?— src/languages/en.ts:3957Next— CountrySelectionList.tsx:77Validate your account— src/languages/en.ts:2276, rendered by VerifyAccountPageBase.tsx:109The non-US deposit account flow is unaffected by #99431, so
Global-Reimbursement-Add-a-Deposit-Account.mdwas left alone.Fixed Issues
$ #98067
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — documentation only.
Android: mWeb Chrome
N/A — documentation only.
iOS: Native
N/A — documentation only.
iOS: mWeb Safari
N/A — documentation only.
MacOS: Chrome / Safari
N/A — documentation only.
@jmusial, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.