Skip to content

Docs updates for E/A#99097 clarify how canceled payments are reported - #100487

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsCanceledPaymentStatus
Closed

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsCanceledPaymentStatus

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up to #99097, which stopped showing the Canceled status on expense previews, on the report preview header, and next to the amount on the expense detail page. After that PR, iou.canceled is no longer used on any expense surface — a canceled payment is recorded only by its system message in the report chat.

No existing article claimed a Canceled label appeared, so nothing on the help site became wrong. What was missing is where a canceled payment actually shows up, which is now the whole story for the member. This PR documents that, and fixes a UI label that did not match the product.

Changes

  1. Expense-and-Report-Actions.md — added Cancel payment to What happens after you take a report action, and added an FAQ entry, How can I tell that a payment was canceled?, explaining that the report chat message is the only record and that the report returns to Approved or Done rather than showing a separate canceled label.
  2. Managing-Expenses-in-a-Report.md and Attach-and-edit-receipts-on-expenses.md — corrected Cancel Payment to Cancel payment to match the product. The UI uses sentence case, so the old capitalization violated the naming conventions.

Verified against the live UI before writing, rather than from the code:

  • The report overflow menu is labeled More and its item is Cancel payment.
  • The confirmation modal is titled Cancel payment, reads Are you sure that you want to cancel this payment?, and offers Cancel payment and Dismiss.
  • After canceling, the report chat shows a system message recording the cancellation.
  • The report preview header reads 1 expense beside the status badge, with no Canceled anywhere on the preview or the expense's supporting line.
  • The report reverted to the Approved badge, and the expense detail amount line read Amount • Cash • Approved • Reimbursable with no • Canceled.

Written against docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md. Both edited articles keep a single # title plus # FAQ, use only ## sections, and the new FAQ heading starts with a question word. npm run spell-changed passes on all three files.

@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…nt label

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@stephanieelliott

Copy link
Copy Markdown
Contributor

No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Please comment or reopen if you disagree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants