Repository navigation
Conversation
…nt label Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
54 tasks done
This was referenced Sep 23, 2026
Contributor
|
No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Please comment or reopen if you disagree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to #99097, which stopped showing the
Canceledstatus on expense previews, on the report preview header, and next to the amount on the expense detail page. After that PR,iou.canceledis no longer used on any expense surface — a canceled payment is recorded only by its system message in the report chat.No existing article claimed a
Canceledlabel appeared, so nothing on the help site became wrong. What was missing is where a canceled payment actually shows up, which is now the whole story for the member. This PR documents that, and fixes a UI label that did not match the product.Changes
Expense-and-Report-Actions.md— added Cancel payment to What happens after you take a report action, and added an FAQ entry, How can I tell that a payment was canceled?, explaining that the report chat message is the only record and that the report returns to Approved or Done rather than showing a separate canceled label.Managing-Expenses-in-a-Report.mdandAttach-and-edit-receipts-on-expenses.md— corrected Cancel Payment to Cancel payment to match the product. The UI uses sentence case, so the old capitalization violated the naming conventions.Verified against the live UI before writing, rather than from the code:
Are you sure that you want to cancel this payment?, and offers Cancel payment and Dismiss.1 expensebeside the status badge, with noCanceledanywhere on the preview or the expense's supporting line.Amount • Cash • Approved • Reimbursablewith no• Canceled.Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md. Both edited articles keep a single#title plus# FAQ, use only##sections, and the new FAQ heading starts with a question word.npm run spell-changedpasses on all three files.@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari