[CP Staging] Fix Unable to scroll down to Save button when prompt field focused in landscape by GCyganek · Pull Request #100685 · Expensify/App

GCyganek · 2026-09-09T07:41:19Z

Explanation of Change

In landscape mode the agent prompt form rendered without a scroll view, so the Save button was unreachable once the keyboard opened. EditPromptPage now enables the form's scroll view in landscape, gives the prompt input a fixed height there instead of flex1, and scrolls the focused input into view on iOS via the existing scrollToMultilineInput helper.

Fixed Issues

$ #100640
PROPOSAL: N/A

Tests

Launch Expensify app.
Go to Account > Agents.
Create an agent.
Open agent.
Tap Write custom instructions.
Switch to landscape mode.
Tap on the input field.
Try to scroll down to Save button.
Verify User can scroll down to Save button when custom instructions field is focused in landscape mode.

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-09-09.at.09.35.58.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-09-09.at.09.34.26.mov

iOS: mWeb Safari

Screen.Recording.2026-09-09.at.09.38.09.mov

MacOS: Chrome / Safari

… landscape

melvin-bot · 2026-09-09T07:41:36Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

truph01 · 2026-09-09T07:59:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-09-09.at.14.48.44.mov

Screen.Recording.2026-09-09.at.14.49.40.mov

iOS: HybridApp

Screen.Recording.2026-09-09.at.14.51.09.mov

Screen.Recording.2026-09-09.at.14.57.05.mov

MacOS: Chrome / Safari

Screen.Recording.2026-09-09.at.14.57.41.mov

mountiny

Gonna move this ahead to fix the blocker sooner than later

github-actions · 2026-09-09T10:37:35Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-09-09T10:40:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-09-09T10:42:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #100685.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-147ce28-57708e6-cf3e978c44dc834d23c525bd21b0d0a80a832fee/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-147ce28-57708e6-f18141dddde2c57b3ba8f9a52e9b3c16916d07c2/index.html

Web 🕸️
https://100685.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…cape-mode/fix-edit-prompt-page-scroll-view [CP Staging] Fix Unable to scroll down to Save button when prompt field focused in landscape (cherry picked from commit 147ce28) (cherry-picked to staging by mountiny)

os-botify · 2026-09-09T11:08:02Z

🔁 Filed a Staging retest request for deploy blockers #100640 after this PR was cherry-picked to staging.

OSBotify · 2026-09-09T19:45:54Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.75-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-09-09T19:49:55Z

🤖 No help site changes are required for this PR — I did not create a docs PR.

This is a layout-only fix. It enables the form's scroll view in landscape, gives the prompt input a fixed height there, and scrolls the focused input into view. No feature, flow, label, or copy changed.

Why no docs update is needed

Diff scope: one file, src/pages/settings/Agents/Fields/EditPromptPage.tsx (+32/−19). Changes are shouldUseScrollView, container styles, an onLayout offset, and an onFocus handler. No src/languages/* edits, so every user-facing string is unchanged.

Article checked: docs/articles/new-expensify/ai-agents/Create-and-Use-Custom-Agents.md. Its "How to edit an agent's instructions" section already documents the exact flow this PR touches — Account > Agents > Edit > Write custom instructions > Save. Those labels and that sequence are untouched by this PR, so the article stays accurate as written.

Why nothing should be added: the bug made the Save button unreachable in landscape. The fix restores the behavior the article already describes, rather than introducing new behavior. Per HELP_AUTHORING_GUIDELINES.md, help articles document what users can do — not device-orientation or keyboard-layout mechanics. No existing article mentions landscape mode, and adding a note about it would document an implementation detail and a bug that no longer exists.

@GCyganek, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

view run · view recording

OSBotify · 2026-09-09T20:15:35Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.74-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-09-10T22:32:11Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.75-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

OSBotify · 2026-09-11T09:20:08Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.75-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Fix Unable to scroll down to Save button when prompt field focused in…

682baa5

… landscape

melvin-bot Bot assigned GCyganek Sep 9, 2026

GCyganek marked this pull request as ready for review September 9, 2026 07:41

GCyganek requested review from a team as code owners September 9, 2026 07:41

melvin-bot Bot requested review from truph01 and removed request for a team September 9, 2026 07:41

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team September 9, 2026 07:41

GCyganek mentioned this pull request Sep 9, 2026

Fix Save button unreachable behind keyboard on EditPromptPage in landscape #100643

Closed

40 tasks done

truph01 approved these changes Sep 9, 2026

View reviewed changes

melvin-bot Bot requested a review from NicolasBonet September 9, 2026 08:25

mountiny changed the title ~~Fix Unable to scroll down to Save button when prompt field focused in landscape~~ [CP Staging] Fix Unable to scroll down to Save button when prompt field focused in landscape Sep 9, 2026

mountiny approved these changes Sep 9, 2026

View reviewed changes

mountiny merged commit 147ce28 into Expensify:main Sep 9, 2026
41 of 43 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Sep 9, 2026

OSBotify mentioned this pull request Sep 9, 2026

Deploy Checklist: New Expensify 2026-09-08 #100624

Closed

69 tasks done

melvin-bot Bot mentioned this pull request Sep 9, 2026

[Due for payment 2026-09-16] Unable to scroll down to Save button when custom instructions field is focused in landscape #100640

Closed

2 of 7 tasks

Navigation Menu

Repository navigation

[CP Staging] Fix Unable to scroll down to Save button when prompt field focused in landscape - #100685

[CP Staging] Fix Unable to scroll down to Save button when prompt field focused in landscape#100685
mountiny merged 1 commit into
Expensify:mainfrom
software-mansion-labs:@GCyganek/landscape-mode/fix-edit-prompt-page-scroll-view

GCyganek commented Sep 9, 2026

Uh oh!

melvin-bot Bot commented Sep 9, 2026

Uh oh!

truph01 commented Sep 9, 2026

Uh oh!

mountiny left a comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

OSBotify commented Sep 9, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

os-botify Bot commented Sep 9, 2026

Uh oh!

OSBotify commented Sep 9, 2026

Uh oh!

MelvinBot commented Sep 9, 2026 •

edited

Loading

Uh oh!

OSBotify commented Sep 9, 2026

Uh oh!

OSBotify commented Sep 10, 2026

Uh oh!

OSBotify commented Sep 11, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

GCyganek commented Sep 9, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 9, 2026

Uh oh!

truph01 commented Sep 9, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

OSBotify commented Sep 9, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

os-botify Bot commented Sep 9, 2026

Uh oh!

OSBotify commented Sep 9, 2026

Uh oh!

MelvinBot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Sep 9, 2026

Uh oh!

OSBotify commented Sep 10, 2026

Uh oh!

OSBotify commented Sep 11, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MelvinBot commented Sep 9, 2026 •

edited

Loading