Repository navigation
[No QA] Docs updates for E/A#93317 document Invoice fields on workspace Invoices page - #100753
Conversation
Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
MelvinBot
added
the
HelpDot
|
@MelvinBot mark this PR as ready for review |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @lschurr |
|
Done — this PR is now Ready for review. PullerBear assigned One thing to fix before review starts: the Tests and QA Steps sections still contain the Check status at the time of marking readyAll checks pass except
Files changed — all help site markdown, no app code:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| 1. Go to **Workspaces > [Workspace Name] > Invoices**. | ||
| 2. Under **Invoice fields**, click **Add field**. | ||
| 3. Click **Name** and enter a name for the field. |
There was a problem hiding this comment.
Navigation phrasing violation (HELPSITE_NAMING_CONVENTIONS.md, Navigation Instruction Standards): The unified web/mobile sentence must not be paraphrased. Use the exact form In the navigation tabs (on the left on web, on the bottom on mobile), click **Workspaces**. — remove "and" and change "at the bottom" to "on the bottom".
There was a problem hiding this comment.
this is consistent with the rest of the article, so let's leave it for now.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8cdfed0de0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| 1. Go to **Workspaces > [Workspace Name] > Invoices**. | ||
| 2. Under **Invoice fields**, click the field you want to change. | ||
| 3. Update the **Name**, **Type**, **Initial value**, or **List values**, or click **Delete** to remove the field. |
There was a problem hiding this comment.
For an existing invoice field, FieldsSettingsPage.tsx renders both Name and Type with interactive={false}, so neither property can be updated from this screen. Users following this section will only see read-only values; document the editable initial/list values and tell users to delete and recreate a field when its name or type must change.
Useful? React with 👍 / 👎.
|
|
||
| - Invoice fields appear on the invoices sent from the workspace, where you can set each field's value. | ||
| - Invoice fields and report fields are kept separate. Report fields don't appear on invoices, and invoice fields don't appear on expense reports. | ||
| - Turning off the **Invoice fields** toggle disables invoice fields on invoices. |
There was a problem hiding this comment.
Turning this toggle off is destructive rather than merely hiding the fields: WorkspaceInvoiceFieldsSection.tsx deliberately uses the confirmation stating that text and date fields are deleted while lists are disabled. Without that distinction, an admin may expect all configured fields to return after re-enabling the feature; describe the deletion/disable behavior explicitly.
Useful? React with 👍 / 👎.
HelpDot Documentation ReviewOverall AssessmentThis PR documents the new Invoice fields feature (#93317). It adds a well-structured new article ( Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
It looks like we need the PR auth list to be checked off and I don't see a preview of this on the site. Not totally sure if I can review yet? cc @stephanieelliott |
|
OhI I was able to get it, thanks @lschurr! |
|
🤖 No failing checks on this PR — nothing to fix. Every completed check is I did not push anything, since there is no failure to fix. What I checkedPR check rollup — 20 entries, zero failures:
Merge commit checks — also clean. No Files deployed:
One possible source of the report: the only non-green run in this branch's whole history is a Deploy ExpensifyHelp run from Sep 9 with conclusion If you were looking at a different check or a different PR, reply with |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.82-0 🚀
|
|
@stephanieelliott do we have to test anything here? |
stephanieelliott
changed the title
|
Oop, no @kavimuru -- no QA here! |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.86-0 🚀
|
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.89-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.89-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Documents the Invoice fields feature shipped in #93317, which added an Invoice fields section to Workspaces > [Workspace Name] > Invoices and split invoice-level fields out from report fields.
Nothing on the help site covered invoice fields, and the existing Report Fields article implied report fields cover every report type — which is no longer true, since #93317 filters invoice-target fields out of the Reports page and report-target fields off invoices.
Changes:
docs/articles/new-expensify/workspaces/Enable-Invoice-Fields.md— who can use Invoice fields, how to enable the toggle (including the Control-plan upgrade prompt), how to add, edit, and delete a field, what happens after enabling, and an FAQ.docs/articles/new-expensify/workspaces/Enable-Report-Fields.md— states that Report Fields apply to expense reports and don't appear on invoices, links to the new article, and corrects the field-creation steps to the current UI labels (Add field, Type, List values, Add value) plus the Formula type, which the type selector offers but the article never listed.docs/articles/new-expensify/reports-and-expenses/Send-an-Invoice.md— one FAQ entry pointing invoice senders at the new article.Every feature name, section header, toggle, field label, type option, and button label was verified against the running app rather than taken from the diff:
Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: the new article has exactly one#heading plus# FAQ, every##heading is task-based, it carriesinternalScopemetadata, it covers a single workflow, cross-links are relative and sit outside numbered steps, and the one screenshot suggestion uses the non-rendered<!-- SCREENSHOT: -->format.Two notes for the reviewer:
#headings and Title Case feature names. I deliberately kept the change minimal there — only the invoices relationship and the UI-label corrections — rather than restructuring an article this PR didn't cause to be wrong. Say the word if you'd rather it be brought fully into compliance here.docs/articles/new-expensify/workspaces/Duplicate-Workspace.mdandCopy-Workspace-Settings.mdneeded no change: invoice fields ride along with the existing Invoices selection rather than becoming a new selectable item, and Copy Workspace Settings already covers the Control-plan upgrade prompt generically. The new article's FAQ documents that carry-over behavior.Fixed Issues
$ #72584
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.