Repository navigation
Implement invoice fields feature - #93317
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
ShridharGoel
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02d9d2a73b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
joekaufmanexpensify
left a comment
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
good for product 👍
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@rojiphil Can you have a look? |
# Conflicts: # src/components/AvatarWithDisplayName.tsx # src/components/MoneyRequestReportView/MoneyRequestViewReportFields.tsx # src/components/ReportActionItem/MoneyReportView.tsx # src/libs/ReportUtils.ts # src/pages/ShareCodePage.tsx # src/pages/workspace/reports/CreateReportFieldsPage.tsx # src/pages/workspace/reports/InitialListValueSelector/DynamicReportFieldsInitialListValuePage.tsx # src/pages/workspace/reports/InitialListValueSelector/index.tsx # src/pages/workspace/reports/ReportFieldsAddListValuePage.tsx # src/pages/workspace/reports/ReportFieldsEditValuePage.tsx # src/pages/workspace/reports/ReportFieldsInitialValuePage.tsx # src/pages/workspace/reports/ReportFieldsListValuesPage.tsx # src/pages/workspace/reports/ReportFieldsSettingsPage.tsx # src/pages/workspace/reports/ReportFieldsValueSettingsPage.tsx # src/pages/workspace/reports/TypeSelector/TypeSelectorPage.tsx # src/pages/workspace/reports/WorkspaceReportsPage.tsx # tests/unit/ReportUtilsTest.ts
|
@ShridharGoel Quite a lot of code to process here and additional issues as mentioned here to resolve. Let us start nibbling from one corner. Starting with #93224, I can still reproduce the issue as the receiver does not see the invoice field. What do you think is the root cause for this? 93224-issue-001.mp4 |
Invoice receivers lack the invoice-fields flag in their reduced policy. Use report data for invoice visibility while preserving the expense field gate.
|
@rojiphil Can you check now? |
|
🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@ShridharGoel @rojiphil I just noticed that this PR has changes on |
|
Not an |
|
Looks like that happened during merging main / conflict resolution some days back. But reverting in #100684 |
…ctions [No QA] Revert accidental .github changes from #93317
|
Thanks @ShridharGoel! |
|
🚀 Deployed to staging by https://github.com/mollfpr in version: 9.4.75-0 🚀
|
|
Yes — help site changes are required. Nothing under Draft PR: #100753 What this PR changed that the docs missed
Docs changes
UI verificationEvery label came from the running app, not the diff — an Verified labels
Two calls I made, in case you disagree
One thing I could not run: @ShridharGoel, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker #100756 was identified to be related to this PR. |
|
Deploy Blocker #100772 was identified to be related to this PR. |
|
Deploy Blocker #100790 was identified to be related to this PR. |
|
Deploy Blocker #100878 was identified to be related to this PR. |
|
Deploy Blocker #100879 was identified to be related to this PR |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.75-3 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.75-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Implement invoice fields feature.
Fixed Issues
$ #72584
PROPOSAL: #72584 (comment)
Tests
Precondition:
Enable Invoices in workspace settings.
Enable Invoice fields and create any field.
Offline tests
QA Steps
Same.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-02-02.at.1.01.56.AM.mov
Android: mWeb Chrome
Screen.Recording.2026-02-02.at.1.00.25.AM.mov
iOS: Native
Screen.Recording.2026-02-02.at.12.55.40.AM.mov
iOS: mWeb Safari
Screen.Recording.2026-02-02.at.12.58.09.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-02.at.12.09.10.AM.mov
Screen.Recording.2026-02-02.at.12.12.09.AM.mov