Repository navigation
Conversation
Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
Contributor
Author
|
I created this PR from an upstream branch since I don't have push access to your fork. If you want to push updates to this branch yourself, run: That gives you the branch on your fork. If you'd rather own the PR outright, close this one and open a new one from your fork. Otherwise, review the change here and comment |
54 tasks done
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://e154414b.helpdot.pages.dev ⚡️ Updated articles: |
3 tasks
Contributor
|
this was handled elsewhere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to #100570, which standardized the in-line delete experience for workspace rules.
That PR moved each rule editor's delete from a labelled Delete rule button at the bottom of the page to a trashcan icon in the top-right of the header. For most rule types the trashcan is gated behind the
rulesRevampbeta and the labelled button still shows without it, so those help articles still describe what admins see today and are left alone. Agent rules are the exception:EditAgentRulePagedropped the footer button unconditionally, so every admin with the Custom agent beta now deletes an Agent rule from the header trashcan.Create-Agent-Rules.mdis the only article that documents that flow, so it is the only one updated here:canDeletegating.docs/HELPSITE_NAMING_CONVENTIONS.md.Articles reviewed and deliberately not changed:
Expensify-Card-Spend-Rules.md,Workspace-Rules.md,Workspace-Merchant-Rules.md, andPersonal-Expense-Rules.md.Fixed Issues
$ #100568
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
This PR only changes a Markdown file under
docs/articles. Suggested check: with the Custom agent beta enabled, open Workspaces > [Workspace name] > Rules, select a saved rule in the Agent rules section, and confirm the article's steps match what you see — a trashcan icon in the top-right corner, and a Delete rule confirmation with a Delete button.Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.