Repository navigation
Conversation
|
@codex review |
|
@MelvinBot review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13701e65bc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
🤖 Review: the fix is correct and minimal. Why the fix is rightWithout the flag, The Verification that "Settings > Troubleshoot is unchanged" holdsConfirmed, though not for the reason the guard suggests. On the Troubleshoot page the top route is Precedent checked: Two notes1. The tests assert the argument, not the behavior. 2. Missing platform evidence. The checklist has all five platforms ticked, but the Screenshots section only has videos for iOS: Native and MacOS: Chrome — Android: Native, Android: mWeb Chrome and iOS: mWeb Safari are empty. #100769 reproduced on Android: App specifically, so an Android Native recording is the one that matters most here. Not a defect, just so it's on the record: after a browser refresh directly on Web verification:
|
| Step | Status |
|---|---|
Signed in and on the Home page (Inbox)Snapshot showed heading "Home" with tabs Home/Inbox/Spend/Workspaces/Account and Home page content. |
✅ |
Open the Test Tools modal with Ctrl+D and confirm the "Beta overrides" rowNot executable: the web harness exposes no keyboard-modifier command, so Ctrl+D could not be sent. Tooling gap, not a product observation. |
|
Beta overrides opens in the RHP over Home, not over Settings > TroubleshootBlocked by the same Ctrl+D limitation; not exercised. |
|
Back arrow returns to Home, not Settings > TroubleshootBlocked by the same Ctrl+D limitation; not exercised. |
|
| ✅ | |
| ✅ |
No blank or broken layout on any reachable screen. CI is green on d7222c4 — the only failing check is Check independent approval, which is just the missing review.
view run · no recording available
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@MelvinBot fair point about the test, addressed. Please re-review |
|
🤖 Addressed — this is exactly the test I was asking for. No further changes needed from me.
What makes it convincing is that it pairs with Coverage of the bug is now complete across two links, which is the right way to split it given
The The red CI is not yours
#100068 merged to Nothing for you to do here — the counts need bumping to 16 on Leftover nitAndroid: Native now has a recording, which was the one that mattered — the issue reproduced there. Android: mWeb Chrome and iOS: mWeb Safari are still empty boxes with all five platforms ticked. Low stakes, since mWeb runs the same navigation code as the macOS Chrome recording you already attached, but the checklist and the body still disagree. I did not re-run the web check: |
|
Tests failing on main |
|
@DylanDylann all yours |
|
@JakubKorytko I see a similar problem
Screen.Recording.2026-09-11.at.11.15.39.mov |
|
@DylanDylann fair, fixed, please re-test |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-14.at.16.54.29.movAndroid: mWeb ChromeScreen.Recording.2026-09-14.at.16.32.18.moviOS: HybridAppScreen.Recording.2026-09-14.at.16.52.34.moviOS: mWeb SafariScreen.Recording.2026-09-14.at.16.29.45.movMacOS: Chrome / SafariScreen.Recording.2026-09-14.at.16.25.35.mov |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.78-0 🚀
|
|
No help site changes are required for this PR, so I did not create a draft PR. This change only affects how the Beta overrides page is routed when opened from the Test Tools modal. That is a developer/QA tool, not a customer-facing feature:
The only troubleshooting article on the help site, General Product Troubleshooting, covers browser-level steps and the JavaScript console. It never references the in-app Troubleshoot page or any route this PR changes, so it stays accurate as written. Because no docs PR was needed, I also skipped the view run · no recording available |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.78-3 🚀
Bundle Size Analysis (Sentry): |


Explanation of Change
The "Beta overrides" page was a static route under Settings > Troubleshoot, so opening it from the Test Tools modal mounted the Troubleshoot page under the RHP, and reloading the page always landed there as well. The page is now a dynamic route (
<current-path>/beta-overrides) that can be opened from any screen. The URL carries the screen the Test Tools modal was opened from, so both the back arrow and a page reload keep that screen underneath. Opening from Settings > Troubleshoot is unchanged.Fixed Issues
$ #100769
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.mov
Android: mWeb Chrome
iOS: Native
iOS.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Web.mov