Repository navigation
Conversation
Co-authored-by: Gandalf <allgandalf@users.noreply.github.com>
40 tasks done
3 tasks
Contributor
|
Covering this in: #101951 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Documents the SAML re-authentication behavior changed by #100475 in the New Expensify SAML troubleshooting article.
On a domain with Require SAML login enabled, a session expires periodically and the app sends the member back through their Identity Provider. Members experience this as the screen flashing to the sign-in page mid-session, and they used to lose the page and filters they were working with. #100475 makes the forced re-auth return them to the page they were on. The help site never described this behavior at all, so members who hit it have no article that explains it is expected rather than a login failure.
Changes to
docs/articles/new-expensify/domains/Troubleshoot-SAML-SSO-Login.md:keywordsextended withsession expired,signed out while working, andre-authenticationso the article is retrievable for the phrasing members actually use.No other article needed a change. #100475 adds no new setting, screen, or button, so the existing SAML setup and troubleshooting steps stay accurate.
Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: task-based headings only,#/##levels only, no Liquid includes or collapsible sections. UI labels verified against the live app — Home is the tab the app lands on after sign-in, and Require SAML login matches the exact string insrc/languages/en.ts.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/674363
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@allgandalf, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.