Repository navigation
[No QA] Consolidated help docs: new-expensify/domains - #101951
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@mollfpr @Kel-Expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR consolidates 5 help doc PRs for the Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c32d974d11
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ## What Strictly enforce expense workspace rules does | ||
|
|
||
| --- | ||
| Use this to ensure workspace-level rules are followed before a report is submitted. Enabling Strictly enforce expense workspace rules ensures workspace rule compliance and prevents incomplete submissions. | ||
|
|
||
| ## What Domain Group permission settings control | ||
| ## What Restrict primary contact method selection does |
There was a problem hiding this comment.
Use the labels shown in the Domain Group form
When a Domain Admin follows this section, neither named control exists in the UI: the strings rendered by DomainGroupCreatePage.tsx are Strictly enforce workspace rules and Restrict default login selection (src/languages/en.ts lines 11630 and 11644). Renaming both only in the help article makes the settings difficult to identify and search for, so these headings and descriptions should retain the actual product labels.
Useful? React with 👍 / 👎.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 685cd4ea74
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
HelpDot Documentation ReviewOverall AssessmentThis PR consolidates five help-doc PRs for new-expensify/domains. Most edits move in the right direction: adding proper H1 titles, converting intros to benefit-focused summaries, tightening internalScope, adding task-based headings, and folding noisy sub-headings into bold labels. However, one file has a broken YAML frontmatter block and a duplicate H1, and there is a cross-link to an article that does not exist in the repo. These must be fixed before merge. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
A preview of your ExpensifyHelp changes have been deployed to https://4881334a.helpdot.pages.dev ⚡️ Updated articles: |
|
@VictoriaExpensify looks like this was merged without a test passing. These checks had not passed on e88e389 when it was merged:
Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.4.94-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀
Bundle Size Analysis (Sentry): |
Summary
Consolidates 5 help doc PRs for
new-expensify/domainsinto a single reviewable PR.Included PRs
Test plan