Skip to content

[No QA] Consolidated help docs: new-expensify/domains - #101951

Merged
VictoriaExpensify merged 18 commits into
mainfrom
helpsite-consolidated-new-expensify-domains
Sep 25, 2026
Merged

VictoriaExpensify merged 18 commits into
mainfrom
helpsite-consolidated-new-expensify-domains

Conversation

@stephanieelliott

Copy link
Copy Markdown
Contributor

@melvin-bot

melvin-bot Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @Kel-Expensify

@melvin-bot

melvin-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

@mollfpr @Kel-Expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 23, 2026 01:45
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR consolidates 5 help doc PRs for the new-expensify/domains folder. It removes the now-defunct "Access restricted" flow from Claim-and-Verify-a-Domain, reworks Domain Group permission descriptions and adds Card preferred workspace guidance, standardizes the Domain admins label, adds a new Review-Domain-Admin-Requests article, and documents SAML re-authentication behavior. The new Review-Domain-Admin-Requests article is the strongest addition. Most changes improve accuracy and consolidation, but a few structural and navigation-language issues were introduced in the diff.

Scores Summary

  • Readability: 8/10 - New content is clear, scannable, and uses well-formed numbered steps. The empty heading in Domain Groups and one vague navigation phrase slightly reduce the flow.
  • AI Readiness: 7/10 - Strong task-based headings, full feature names, and good keyword/internalScope metadata. Penalized because the SAML diff adds another top-level # heading and Domain Groups introduces a heading with no body content.
  • Style Compliance: 7/10 - UI labels are mostly exact and bolded, and Domain admins casing is now consistent. Penalized for a prohibited vague navigation phrase and a raw quoted UI string.

Key Findings

  • Positive: The new Review-Domain-Admin-Requests.md follows the template closely: single # title plus # FAQ, task/question-based ## headings, complete YAML including internalScope, purposeful screenshot placeholders, and descriptive cross-link anchor text.
  • Positive: Consolidation correctly removes the retired "Access restricted" content and its FAQs from Claim-and-Verify-a-Domain, and updates the cross-reference in Domain-Admins.md, keeping scope to one workflow per article.
  • Positive: Domain Admins to Domain admins casing was standardized to match the UI across steps and FAQs.
  • Issue (Domain Groups, structure): The diff adds ## What Domain Group permission settings control immediately followed by ## What the Default group setting does, leaving the first heading with no body content. Add an intro sentence under it or remove it.
  • Issue (Domain Groups, navigation): Step 3 "Scroll below your workspaces list to find Domains" uses prohibited vague phrasing. Use an exact, deterministic instruction.
  • Issue (Domain Groups, style): The lock error is embedded as a raw curly-quoted prose string. Present exact UI/error text consistently with the naming conventions.
  • Issue (SAML, headings): The diff adds a new top-level heading # Why SAML SSO sign-in restarts while you are working. Per Section 4, only one # title plus # FAQ is allowed; this should be a ## section. (Pre-existing multiple # headings are outside this PRs scope, but the diff extends the pattern.)

Recommendations

  • Priority: Fix the empty ## What Domain Group permission settings control heading (add a lead-in sentence or remove it).
  • Priority: Replace "Scroll below your workspaces list to find Domains" with a deterministic navigation instruction.
  • Priority: Demote the newly added SAML # heading to ## so the article keeps a single # title plus # FAQ.
  • Suggestion: Render the Card preferred workspace lock message using the exact-UI-text convention rather than an inline quoted sentence.

Files Reviewed

  • Claim-and-Verify-a-Domain.md - Good; scope correctly trimmed, metadata updated.
  • Create-and-Manage-Domain-Groups.md - Needs work; empty heading, vague navigation, raw quoted error string.
  • Domain-Admins.md - Good; label casing standardized, cross-link added.
  • Review-Domain-Admin-Requests.md - Excellent; new article is template-compliant.
  • Troubleshoot-SAML-SSO-Login.md - Minor; strong content but adds a new # heading that should be ##.
  • Web-Expensify - Non-doc submodule pointer; not reviewed.

Note: Detailed line-by-line feedback has been provided as inline comments.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c32d974d11

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread Web-Expensify Resolved
Comment on lines +52 to +56
## What Strictly enforce expense workspace rules does

---
Use this to ensure workspace-level rules are followed before a report is submitted. Enabling Strictly enforce expense workspace rules ensures workspace rule compliance and prevents incomplete submissions.

## What Domain Group permission settings control
## What Restrict primary contact method selection does

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the labels shown in the Domain Group form

When a Domain Admin follows this section, neither named control exists in the UI: the strings rendered by DomainGroupCreatePage.tsx are Strictly enforce workspace rules and Restrict default login selection (src/languages/en.ts lines 11630 and 11644). Renaming both only in the help article makes the settings difficult to identify and search for, so these headings and descriptions should retain the actual product labels.

Useful? React with 👍 / 👎.

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@melvin-bot
melvin-bot Bot removed the request for review from a team September 23, 2026 04:37
@stephanieelliott
stephanieelliott marked this pull request as draft September 23, 2026 04:39
@stephanieelliott
stephanieelliott marked this pull request as ready for review September 23, 2026 04:39
@OSBotify

This comment has been minimized.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 685cd4ea74

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR consolidates five help-doc PRs for new-expensify/domains. Most edits move in the right direction: adding proper H1 titles, converting intros to benefit-focused summaries, tightening internalScope, adding task-based headings, and folding noisy sub-headings into bold labels. However, one file has a broken YAML frontmatter block and a duplicate H1, and there is a cross-link to an article that does not exist in the repo. These must be fixed before merge.

Scores Summary

  • Readability: 8/10 - Summaries and steps are clear and scannable; permission descriptions in the domain groups article read well. Minor typo ("AML SSO") and one run-together sentence.
  • AI Readiness: 5/10 - Task-based headings and full feature names are strong, but Troubleshoot-SAML-SSO-Login.md has corrupted frontmatter (keywords + internalScope collapsed into the description value) and two # headings, which breaks metadata parsing and the single-H1 rule.
  • Style Compliance: 6/10 - Good UI-exact button/tab bolding and unified web/mobile navigation phrasing. Deductions for inconsistent step targets ("New" vs "New group"), a dead cross-link, and inconsistent Domain terminology casing.

Key Findings

  • CRITICAL - Troubleshoot-SAML-SSO-Login.md: description, keywords, and internalScope are merged onto a single description: line. Split them into three separate valid YAML keys.
  • CRITICAL - Troubleshoot-SAML-SSO-Login.md: contains a second # heading (# Where to find SAML SSO settings in New Expensify) alongside the title H1. Governance allows only one # (plus # FAQ). Demote to ##.
  • CRITICAL - Domain-Admins.md and Manage-Domain-Members.md reference "Review Domain Admin requests," but Domain-Admins.md links to /articles/new-expensify/domains/Review-Domain-Admin-Requests, which does not exist in the repo. Fix the link target or add the article.
  • Troubleshoot-SAML-SSO-Login.md: typo "AML SSO" (should be "SAML SSO"); title H1 uses Title Case ("SAML SSO Login") while the YAML title is sentence case ("SAML SSO login") - align them.
  • Create-and-Manage-Domain-Groups.md: "How to create a domain group" steps end at "Select New", but the create button is referenced elsewhere as "New group" and the configure/find flows repeat the same four navigation steps verbatim - consolidate and confirm the exact UI label.
  • Positive: converting per-permission ## headings to bold labels under one task-based section reduces heading clutter and improves retrieval focus.
  • Positive: navigation phrasing standardized to "In the navigation tabs (on the left on web, on the bottom on mobile)" per conventions; three-dots menu correctly formatted.

Recommendations

  • Priority 1: Repair the Troubleshoot-SAML-SSO-Login.md YAML frontmatter into three distinct keys and demote its second # heading to ##.
  • Priority 2: Resolve the Review-Domain-Admin-Requests cross-link (create the target article or point to the correct existing one).
  • Priority 3: Fix the "AML SSO" typo, align the SAML title casing, and confirm the exact "New" vs "New group" button label in the domain groups create flow.
  • Consider whether downcasing "Domain Groups" to "domain groups" matches the actual product UI; keep casing consistent with what members see on screen.

Files Reviewed

  • Claim-and-Verify-a-Domain.md - Good: added H1, "Who can" section, screenshot; scope trimmed. No blocking issues.
  • Create-and-Manage-Domain-Groups.md - Mostly good; check create-step button label and repeated navigation steps.
  • Domain-Admins.md - Minor casing fix ("Domain admins"); dead cross-link must be fixed.
  • Manage-Domain-Members.md - Clean addition of "How to review a Domain Admin request"; well structured.
  • Troubleshoot-SAML-SSO-Login.md - Needs work: broken frontmatter, duplicate H1, typo, title casing.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott removed request for a team and heyjennahay September 23, 2026 18:34
@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@VictoriaExpensify
VictoriaExpensify merged commit 4902c41 into main Sep 25, 2026
14 of 16 checks passed
@VictoriaExpensify
VictoriaExpensify deleted the helpsite-consolidated-new-expensify-domains branch September 25, 2026 01:58
@melvin-bot melvin-bot Bot added the Emergency label Sep 25, 2026
@melvin-bot

melvin-bot Bot commented Sep 25, 2026

Copy link
Copy Markdown

@VictoriaExpensify looks like this was merged without a test passing. These checks had not passed on e88e389 when it was merged:

  • checklist (no successful run)

Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.94-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Emergency HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants