Repository navigation
Conversation
Co-authored-by: Jakub Steć <jakubstec@users.noreply.github.com>
|
@MelvinBot mark this PR as ready for review |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
🤖 Done — this PR is out of draft and ready for review.
One thing left for you: the Tests and QA Steps sections still hold the view run · no recording available |
|
@brianlee-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4afee2763c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ## What happens after you approve or deny a Domain Admin request | ||
|
|
||
| - If you approve the request, the person moves out of the **Requests** section and into the **Admins** section with full Domain Admin access. | ||
| - If you deny the request, the row disappears from the **Requests** section and the person is not added as a Domain Admin. |
There was a problem hiding this comment.
Document the pending row for offline denials
When an admin selects Deny while offline, the row does not disappear as stated here: declineDomainAdminshipRequest deliberately retains the requester with a pending DELETE, and shouldShowPendingRow keeps that row visible while offline until the queued request succeeds after reconnection. Since the FAQ explicitly tells users that offline actions are queued, qualify this outcome so they do not interpret the still-visible, disabled row as a failed denial.
Useful? React with 👍 / 👎.
|
Covering this in: #101951 |
Explanation of Change
Help site follow-up to #100161, which added a Requests section to the domain Admins page so a Domain Admin can approve or deny someone who asked for admin access, and added a green dot on the Workspaces tab, the domain's row on the Domains tab, and the Domain admins menu item while a request is waiting.
The help site already documented the requester side of this flow (Ask for admin access on the Domain exists page) but had nothing on the admin side, so an admin who saw a green dot had no article explaining it.
New article —
docs/articles/new-expensify/domains/Review-Domain-Admin-Requests.mdUpdated —
docs/articles/new-expensify/domains/Claim-and-Verify-a-Domain.mdUpdated —
docs/articles/new-expensify/domains/Domain-Admins.mdWritten against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md. UI labels were taken fromsrc/languages/en.tson the merged branch: Requests, Approve, Deny, Admins, Add admin, Domain admins. The Domains tab label and its empty state were confirmed against the live web app; the Domain admins page itself could not be opened because the test account has no domain, so please confirm the on-screen labels there.Fixed Issues
$ #99383
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@jakubstec, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.