Repository navigation
Conversation
… bank accounts Co-authored-by: mkhutornyi <mkhutornyi@users.noreply.github.com>
|
@MelvinBot mark this PR as ready for review |
|
🤖 Done — this PR is now marked Ready for review. One thing left for you: the |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@mkhutornyi @Kel-Expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
||
| Chase does not share a usable account number and routing number when you log into your bank, so a Chase account has to be entered by hand the first time you add it. | ||
|
|
||
| Start from **Add bank account** in **Wallet** or in a Workspace, then: |
There was a problem hiding this comment.
Navigation instruction consistency: The rest of this article gives explicit navigation for Add bank account (e.g., "In the navigation tabs (on the left on web, on the bottom on mobile), click Account > Wallet"), but this section only says "Start from Add bank account in Wallet or in a Workspace." Per HELPSITE_NAMING_CONVENTIONS.md (Navigation Instruction Standards), give the exact path or cross-reference the two existing sections above so readers know how to reach Add bank account on web and mobile.
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 010ae4c696
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Start from **Add bank account** in **Wallet** or in a Workspace, then: | ||
|
|
||
| 1. Select **Log into your bank** and sign in to Chase. |
There was a problem hiding this comment.
Include the required Wallet setup screens
When a reader starts this procedure from Wallet, Add bank account does not lead directly to Log into your bank: the app first requires selecting Make payments and then choosing the bank's country, as the Wallet procedure above also documents. The new standalone Chase procedure therefore leaves Wallet users unable to follow step 1; include those two screens or explicitly direct Wallet users to complete the preceding Wallet steps first.
Useful? React with 👍 / 👎.
|
@stephanieelliott where is the preview of the changes? |
|
@MelvinBot run |
|
🤖 I can't trigger that workflow — my GitHub token has no Why the check is missing: the To run it, open run 35039585366 and click Re-run all jobs, or push any commit to Two side effects of that job never running, for what it's worth:
I did not push an empty commit to re-trigger it, since I only make code changes on this PR when directed by its author or assignee ( |
|
A preview of your ExpensifyHelp changes have been deployed to https://1fffac51.helpdot.pages.dev ⚡️ Updated articles: |
|
@MelvinBot please complete the task again, but referencing the files under App/docs/articles. on the branch claude-fixCardConnectionIssuesDocs`. Specifically:
|
|
🤖 No — nothing on Read the picked file name from the URI when the native picker returns no metadata is a pure iOS bug fix. It touches three files only — The relevant article, What I checked
A bug fix that restores already-documented behavior doesn't need a docs update. Adding one would mean documenting a bug that no longer exists. Push access wasn't the blocker — I'm author and assignee on [No QA] [Docs] Fix card connection issues: reauthenticate vs. broken connection troubleshooting and you're an assignee, so I would have committed had there been a change to make. There just isn't one. |
Explanation of Change
Help site follow-up for Only arm deferred VBBA navigation when a bank account request was started.
That PR makes the new-Chase Plaid path stay on the bank information step and show the manual account/routing form, instead of pushing the user to Personal Information with no bank account. The help site never described that behavior, so a user who logs into Chase while adding a US business bank account has no article explaining why they are suddenly asked to type in their account and routing numbers.
This adds that to
Connect a US Business Bank Account:How to connect a Chase business bank accountsection covering the login flow, the switch to the Manually add your bank account form, and the Connect manually alternative.Chase,account number,routing number, andconnect manuallyadded to the article keywords.UI labels used in the article were checked against the current App: Add bank account, Log into your bank, Connect manually, Manually add your bank account, Account number, Routing number.
No other help site article documents the Plaid bank-connection flow for US business bank accounts, so no other file needed changes.
Fixed Issues
$ #101128
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Docs-only change. Review the rendered article and confirm the Chase steps match current App behavior.
Offline tests
N/A — help site content only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@mkhutornyi, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.