Repository navigation
Conversation
Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://a70b3751.helpdot.pages.dev ⚡️ Updated articles: |
|
Hold on #101265 |
|
@MelvinBot please complete the task again, but referencing the files under App/docs/articles. on the branch claude-fixCardConnectionIssuesDocs`. Specifically:
|
|
🤖 Yes — one article on [No QA] [Docs] Fix card connection issues: reauthenticate vs. broken connection troubleshooting relocates it:
On that branch the article is still the pre-101356 text: it lists only The problem to fix: merge orderThis PR edits a path that PR 99299 deletes. Either order loses work:
Proposed changeRepoint this PR at the restructured branch: base --- a/docs/articles/new-expensify/connect-credit-cards/connect-and-manage-personal-cards/Import-Personal-Card-Transactions-From-a-Spreadsheet.md
+++ b/docs/articles/new-expensify/connect-credit-cards/connect-and-manage-personal-cards/Import-Personal-Card-Transactions-From-a-Spreadsheet.md
@@ frontmatter @@
internalScope: Audience is all members. Covers how to import, update, and delete personal card transactions from a spreadsheet or an .ofx/.qfx bank statement file. Does not cover company cards or Plaid connections.
+order: 3
---
@@ intro @@
-[Learn how to manage personal cards](/articles/new-expensify/connect-credit-cards/Manage-Personal-Cards).
+[Learn how to manage personal cards](/articles/new-expensify/connect-credit-cards/connect-and-manage-personal-cards/Manage-Personal-Cards).
No redirect work needed — 99299 already maps the old URL to the new one in One question before I port itThis PR retitled the article to sentence case (Import personal card transactions from a spreadsheet). Every sibling article on 99299's branch uses Title Case. Keep sentence case, or match the siblings? Nothing else on the branch needs changingWhat I checked and why it's unaffected
Optional second fix, if you want it in scope
That's now imprecise rather than wrong. A statement-imported card is created with I haven't pushed any of this. I can only make code changes to a PR when directed by that PR's author, an assignee, or an existing co-author, and on this PR that's Two ways to unblock, whichever you prefer:
|
|
@MelvinBot land this content directly on claude-fixCardConnectionIssuesDocs |
|
🤖 Done — landed on The
Two judgment calls I made, since you didn't specify:
This PR is now superseded — its only change is the same content at a path PR 99299 deletes, so leaving it open reinstates the conflict. I didn't close it, since What landed
The optional |
|
Will be handling this in: #99299 |
Explanation of Change
Help site follow-up to Read the picked file name from the URI when the native picker returns no metadata, which fixed
.ofx/.qfxstatement uploads failing with "Invalid file type" on iOS native.That PR made the statement-upload path in Wallet > Import transactions work on native, but
docs/articles/new-expensify/connect-credit-cards/Import-Personal-Card-Transactions-From-a-Spreadsheet.mdnever documented that path at all. The article listed only.CSV,.TXT,.XLS, and.XLSX, and its only procedure ended in the column mapping step — so a member following it would not know statement files are accepted, and would be surprised when the mapping step is skipped.The live UI on the upload screen reads: "Drag and drop your spreadsheet or bank statement here, or choose a file below. Supported formats: .csv, .txt, .xls, .xlsx, .ofx, and .qfx." This PR brings the article in line with that:
.OFXand.QFXto the accepted file types in the FAQ.## How to import personal card transactions from a bank statement filesection covering the statement path, which has no mapping step.shouldAllowBankStatements={!hasImportedSpreadsheet}inImportTransactionsSpreadsheetPage).internalScopeto cover statement files.No change is needed for
Import-Company-Card-Transactions-From-a-Spreadsheet.md— statement uploads are enabled only on the Wallet personal card page, so.CSV/.TXT/.XLS/.XLSXremains correct there.All UI labels in this article were verified against the live NewDot web UI: the Wallet tab, the Cards section, Import transactions, Card display name, Next, Choose file, and the supported-formats line.
Applied
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: one#title plus# FAQ, only##section headings, every heading task-based and feature-specific, bolded Sentence case UI labels, unified navigation sentence, relative cross-links, and a screenshot suggestion in the non-rendered<!-- SCREENSHOT: -->comment format.Fixed Issues
$ #101356
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.
Offline tests
Not applicable — this PR changes help site markdown only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@aimane-chnaif, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.