Repository navigation
Conversation
Co-authored-by: huult <huult@users.noreply.github.com>
38 of 40 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://1e03ead3.helpdot.pages.dev ⚡️ Updated articles: |
This was referenced Sep 23, 2026
Contributor
|
No update needed on this, per tightened Melvinbot criteria (see https://github.com/Expensify/Expensify/issues/685679). Feel free to reopen if you disagree! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up to Reuse the submitter's outstanding report when the workspace chat has no iouReportID.
That PR changed which report a new workspace expense lands on. The submit path now falls back to the submitter's newest open report when the workspace chat's
iouReportIDcan't be resolved, and the confirmation page's Report field was re-sorted newest-first so it names the report the expense actually joins.The help site never documented that rule.
Create-an-Expense.mdsaid only "Expenses are automatically added to a report," which does not tell a member whether their expense joins an existing report or starts a new one — the exact confusion behind the linked issue, where an extra report appeared after an admin moved an expense and the member deleted the emptied report.Changes, all in
docs/articles/new-expensify/reports-and-expenses/Create-an-Expense.md:## How Expensify chooses the report your workspace expense is added tosection stating the rule: your most recently created Draft report on that workspace is reused; a new report is created only when you have none; a report owned by another member is never reused; and submitting a report moves it out of Draft, so the next expense starts a new one.Reportfield on the expense confirmation page as the place to see and change the destination before selecting Create expense.Understanding-Report-Statuses-and-Actionsfor what Draft means, and updatedkeywords/internalScope.<!-- SCREENSHOT: -->placeholder for the confirmation page with the Report field visible.Authoring compliance
Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md. The new headings are task-based and start with a question word, only##is used, no new#heading was added, and the screenshot placeholder uses the required HTML-comment format with a specific purpose.UI label verification
Labels were checked against the live web UI rather than taken from the code, per the request:
New reporton a fresh account.One check could not be completed: on a brand-new account with no Draft report, the Report row is not interactive, so the report-selection screen could not be opened and its header could not be captured. The article therefore refers only to selecting Report and does not name that screen or any control on it.
cspellcould not be run in this environment (the sandbox blocked the invocation). The added text uses only ordinary English words and terms already present in the article.Fixed Issues
$
PROPOSAL:
Documentation follow-up only — the behavior change itself shipped in #100672, which links the originating issue.
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — this PR only changes help site markdown.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@huult, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.