Repository navigation
Conversation
Co-authored-by: MelvinBot <MelvinBot@users.noreply.github.com>
40 tasks done
Contributor
|
this isn't needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for Add search this user/agent to ProfilePage, which added a View user history / View agent history action to profiles and to the Edit agent screen. Nothing on the help site described that action, so members had no documented way to find it.
New article —
docs/articles/new-expensify/chat/View-User-History.mdCovers the single workflow of opening someone's message history from their profile: who can use it, how to reach it on a person's profile and on an agent's profile, what the results are, and an FAQ. It makes the access boundary explicit — the results only cover chats you already belong to, and the person is not notified.
Updated article —
docs/articles/new-expensify/ai-agents/Create-and-Use-Custom-Agents.mdAdds a
## How to view an agent's historysection for the Edit agent path, refreshes the metadata, and notes the new capability in the list of what you can do with an agent after you create it.How the copy was verified
Every label below was checked against the running app on web rather than taken from the diff.
en.tssupplies the strings; the UI confirms where they appear.Clicking the avatar, the display name, the chevron, or the subtitle in the chat header all open the Profile page directly — there is no visible Details button, so the article says to click the name or avatar.
One thing I left alone. The Agents list row buttons now read Chat with agent, Copilot into account, and Edit, but the existing article still calls them "Edit, Chat, and Copilot buttons" and tells members to "click the chat icon on the agent's row". That is a pre-existing drift unrelated to #99295, so I did not fold it into this PR. Worth a separate fix.
AI Tests run
npm run spell-changed— passed, 0 issues across both files../.github/scripts/createDocsRoutes.sh— passed; the new article is picked up automatically (docs/_data/routes.ymlis generated and gitignored, so no routing file needed committing).npx prettier --checkcould not run in this environment: the shared Prettier config failed to load@trivago/prettier-plugin-sort-imports. Markdown underdocs/is not a Prettier merge gate, and cspell — which is the gate — passed.Fixed Issues
$ #98076
$ #99073
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
UI evidence the article copy was checked against (captured on web, not part of a human test pass):
@MelvinBot, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.