Skip to content

[no QA] Docs updates for E/A#99295 document View user history profile action - #101794

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsViewUserHistory
Closed

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsViewUserHistory

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for Add search this user/agent to ProfilePage, which added a View user history / View agent history action to profiles and to the Edit agent screen. Nothing on the help site described that action, so members had no documented way to find it.

New article — docs/articles/new-expensify/chat/View-User-History.md

Covers the single workflow of opening someone's message history from their profile: who can use it, how to reach it on a person's profile and on an agent's profile, what the results are, and an FAQ. It makes the access boundary explicit — the results only cover chats you already belong to, and the person is not notified.

Updated article — docs/articles/new-expensify/ai-agents/Create-and-Use-Custom-Agents.md

Adds a ## How to view an agent's history section for the Edit agent path, refreshes the metadata, and notes the new capability in the list of what you can do with an agent after you create it.

How the copy was verified

Every label below was checked against the running app on web rather than taken from the diff. en.ts supplies the strings; the UI confirms where they appear.

Where Exact label Result
Person's Profile page View user history Sits between Local time and Notify me about new messages
Agent's Profile page View agent history Sits between Copilot into account and Notify me about new messages
Edit agent screen View agent history Sits between the instructions field and Chat with agent
Destination — Chats search, empty input, From: [Name] filter chip plus a Reset link

Clicking the avatar, the display name, the chevron, or the subtitle in the chat header all open the Profile page directly — there is no visible Details button, so the article says to click the name or avatar.

One thing I left alone. The Agents list row buttons now read Chat with agent, Copilot into account, and Edit, but the existing article still calls them "Edit, Chat, and Copilot buttons" and tells members to "click the chat icon on the agent's row". That is a pre-existing drift unrelated to #99295, so I did not fold it into this PR. Worth a separate fix.

AI Tests run

  • npm run spell-changed — passed, 0 issues across both files.
  • ./.github/scripts/createDocsRoutes.sh — passed; the new article is picked up automatically (docs/_data/routes.yml is generated and gitignored, so no routing file needed committing).
  • npx prettier --check could not run in this environment: the shared Prettier config failed to load @trivago/prettier-plugin-sort-imports. Markdown under docs/ is not a Prettier merge gate, and cspell — which is the gate — passed.

Fixed Issues

$ #98076
$ #99073
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation only.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

UI evidence the article copy was checked against (captured on web, not part of a human test pass):

Profile page showing the View user history menu item Chats search filtered by From Expensify Concierge Edit agent screen showing View agent history Agent profile page showing View agent history

@MelvinBot, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: MelvinBot <MelvinBot@users.noreply.github.com>
@MelvinBot MelvinBot self-assigned this Sep 21, 2026
@MelvinBot
MelvinBot requested a review from a team September 21, 2026 19:28
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 21, 2026
@MelvinBot MelvinBot mentioned this pull request Sep 21, 2026
40 tasks done
@stephanieelliott stephanieelliott changed the title Docs updates for E/A#99295 document View user history profile action [no QA] Docs updates for E/A#99295 document View user history profile action Sep 22, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

this isn't needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants