Repository navigation
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@MelvinBot We have this regression: Can you propose the solution? |
Proposed fixSwap the direct - Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query, rawQuery: query}));
+ Navigation.revealRouteBeforeDismissingModal(ROUTES.SEARCH_ROOT.getRoute({query, rawQuery: query}));Why:
Evidence & mechanism
Alternative (only if the above doesn't unwind cleanly enough back to Agents): dismiss first, navigate in the callback — Navigation.dismissModal({
afterTransition: () => Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query, rawQuery: query})),
});but Worth verifying after the change: the exact Agents flow on a narrow/mobile layout — that pressing "View agent history" opens Search and swiping back returns to Agents, not the Home/validate screen — since |
|
@MelvinBot We should use
|
|
You're right — Why swipe-back can't work when the destination is SearchSearch isn't a card on a stack — it's a bottom-tab root inside the single shared So the real question is which "back" you want: Option A — keep results on the Search tab, fix system/tab-bar back (small, recommended)Dismiss the RHP first, then navigate. After the dismiss the top route is the Navigation.dismissModal();
setNavigationActionToMicrotaskQueue(() => {
Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query, rawQuery: query}));
});This mirrors the app's own "leave an RHP and land in a tab" convention in Option B — you truly need edge-swipe back to the reportThen the results can't live on the Search tab at all; they'd have to render in a pushed, non-tab-root route (an RHP or a pushed search-results screen over the originating tab) so there's a real previous card to swipe back to. That's a larger routing change, beyond a hotfix. Mechanism & evidence
Which behavior are you after — Option A (back returns to Agents via system/tab-bar back, no edge-swipe) or Option B (literal edge-swipe, bigger change)? Worth confirming Option A on iOS/Android/web, since "swipe" means a different gesture on each. |
|
@MelvinBot Let's go with A then |
|
Done — implemented Option A and pushed to this branch ( Change: dismiss the RHP first, then navigate to Search on the microtask queue so it's an in-place tab switch that preserves tab history — Navigation.dismissModal();
setNavigationActionToMicrotaskQueue(() => {
Navigation.navigate(ROUTES.SEARCH_ROOT.getRoute({query, rawQuery: query}));
});This mirrors the app's existing "leave an RHP and land in a tab" convention in I also updated Checks run locally
I tried a web smoke test of the flow but the test session rendered a blank page (a CI session bring-up issue, unrelated to this change), so I couldn't exercise it in-browser. Please verify the reported flow on iOS/Android — Account > Agents > agent > Chat with agent > chat header > View agent history, then back — returns to Agents rather than the Home/validate screen, since "swipe/back" behaves differently per platform. |
|
I can verify it fixed our previous issue: Screen.Recording.2026-08-24.at.18.32.55.mov |
|
@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-01.at.7.17.38.PM.movScreen.Recording.2026-09-01.at.7.18.39.PM.movAndroid: mWeb ChromeRecording_20260901_192919.mp4Recording_20260901_193045.mp4iOS: HybridAppScreen.Recording.2026-09-01.at.7.40.11.PM.movScreen.Recording.2026-09-01.at.7.41.04.PM.moviOS: mWeb SafariScreen.Recording.2026-09-01.at.7.45.20.PM.movScreen.Recording.2026-09-01.at.7.47.18.PM.movMacOS: Chrome / SafariScreen.Recording.2026-09-01.at.6.58.21.PM.movScreen.Recording.2026-09-01.at.7.01.01.PM.mov |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89d8ec6e6c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product.
|
@hungvu193, could you please update the QA steps based on latest updates. thanks. |
Cool. Updated |
|
@hungvu193, could you please merge the main. thanks. |
…feat-98076-add-search-user
Sure. |
|
@Julesssss, Could you please take a look at this when you get a chance. thanks. |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.91-0 🚀
|
|
Yes — help site changes are required, and I opened a draft PR for them: Docs updates for E/A#99295 document View user history profile action Why. This PR adds a View user history / View agent history action to profiles and to the Edit agent screen. Nothing under What the docs PR does.
Copy verified against the running app on web, not read off the diff:
Two details that changed how I wrote the stepsThere is no visible Details button. Clicking the avatar, display name, chevron, or subtitle in the chat header all open the Profile page directly in one click. The search box stays empty. The From filter lands as a chip next to the search field rather than as typed text. That reads like a bug on first use, so the article calls it out and there's an FAQ entry for it. One pre-existing drift I did not fold in. The Agents list row buttons now read Chat with agent, Copilot into account, and Edit, but Checks run on the docs branch: @MelvinBot, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker #101825 was identified to be related to this PR. |
|
Deploy Blocker #101826 was identified to be related to this PR. |
|
Deploy Blocker #101843 was identified to be related to this PR. |
|
Deploy Blocker #101888 was identified to be related to this PR. |
|
This PR test 2 failing because of the issue #101888 Bug7266337_1790086302625.ios-repro.mp4 |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.91-3 🚀
Bundle Size Analysis (Sentry): |
| {!!accountID && !isAnonymousUserSession() && !!login && ( | ||
| <MenuItem | ||
| shouldShowRightIcon | ||
| title={translate(isAgentEmail(login) ? 'profilePage.viewAgentHistory' : 'profilePage.viewUserHistory')} |
There was a problem hiding this comment.
We replaced the MagnifyingGlass icon to History icon and also changed the title text to more relevant See chat history in #102270
Explanation of Change
Add "🔍 Search this user" (or "Search this agent") to all profiles to view all report actions of that user/agent.
Fixed Issues
$ #98076
$ #99073
PROPOSAL: N/A
Tests
Same as QA steps.
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Test 1:
View agent historybutton > Click on itView user historyTest 2:
Precondition:
Test 3:
View agent historyPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-09.at.14.37.48.mov
Android: mWeb Chrome
Screen.Recording.2026-08-09.at.14.37.48.mov
iOS: Native
Screen.Recording.2026-08-09.at.14.33.53.mov
iOS: mWeb Safari
Screen.Recording.2026-08-09.at.13.33.44.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-10.at.10.06.23.mov