Repository navigation
[CP Staging] Prefill personal detail for user created via public room - #101889
Conversation
|
@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
There was a problem hiding this comment.
Did this label "View user history" go through @jamesdeanexpensify for copy review?
We typically avoid referring to people as "user"/"users" in the product. We use the term "Member/Members" instead. Could we update that to View member history instead or something?
No I missed that, thanks.
Lets continue with this PR, it's still better than reverting other blocker fixes. |
|
Agreed that |
|
@hungvu193 I followed the test steps, but after signing in as User B and opening User A’s profile from the public room, I don’t see the Screen.Recording.2026-09-22.at.11.40.34.PM.mov |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
On it 👀 |
Yeah, there was a merge conflicts. I fixed it btw |
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
Ready for you again @marufsharifi |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
[CP Staging] Prefill personal detail for user created via public room (cherry picked from commit 072eeff) (cherry-picked to staging by Julesssss)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
CP'd deploying here. I will ping QA for a retest once complete |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🔁 Filed a Staging retest request for deploy blockers #101884 after this PR was cherry-picked to staging. |
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.91-3 🚀
|
|
No help site changes are required for this PR, so I did not create a draft PR. WhyThis PR makes two user-facing changes, and neither is documented in
Searches I ran across App/docs/articlesNo article mentions the renamed menu item or its siblings:
The One note: I could not verify the new label in a running browser — web bring-up failed in this run, so this is based on the diff and a static search of the help site files. The rename is a direct @hungvu193, if you'd like the help site to start documenting the View member history entry on a member's profile (it isn't covered today), reply with |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.91-3 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.92-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
Includes a preselected public-profile user when their login is unavailable, without adding login-less users to normal suggestions for our UserSelector (Filter).
Fixed Issues
$ #101884
PROPOSAL: N/A
Tests
Precondition:
Offline tests
N/A
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A. We can't reproduce it on native
Android: mWeb Chrome
iOS: Native
N/A. We can't reproduce it on native
iOS: mWeb Safari
Screen.Recording.2026-09-22.at.22.11.41.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-22.at.21.43.36.mov