Repository navigation
Conversation
…mobile Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
Merged
54 tasks done
Contributor
|
No update needed on this, see https://github.com/Expensify/Expensify/issues/685679 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Docs-only follow-up to [CP Staging] fix: always show the selection checkboxes in the add existing expense list.
That PR makes the Add existing expense list always show its selection checkboxes, on every screen size. On mobile the list previously behaved like the other tables: checkboxes were hidden until you long-pressed a row and tapped Select, and the header swapped to Select multiple. Now the checkboxes are there as soon as the list opens, a tap selects and deselects, and the selection is no longer cleared by the app-wide selection mode.
Managing-Expenses-in-a-Report.mdis the only help article that documents this flow. Its Add existing unreported expenses steps were written for web ("Click one or more expenses") and said nothing about mobile, so a reader coming from How to Duplicate an Expense or Duplicate a Report — both of which document long-press → Select — would reasonably expect the same pattern here. This PR makes the selection step explicit for both platforms.Changes:
add existing expenseandselect expenses on mobileto the article keywords for retrieval.All UI labels were verified against the live app rather than taken from the existing article: the header is Add existing expense, the filter panel is Filters with a Status section offering Unreported and Draft plus Reset / Apply, and the confirm button reads Add to report (it does not change to an "N selected" label).
Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: UI labels are bold and match the UI exactly, the new FAQ heading starts with a question word, and only##headings were added.npm run spell-changedpasses.Fixed Issues
$ #102003
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
This is a documentation-only change — no app code is touched. Reviewing it means confirming the rendered article matches the shipped behavior of the Add existing expense list on mobile and web.
Offline tests
Not applicable — documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.