Skip to content

Docs updates for E/A#102011 Add existing expense selection on mobile - #102164

Closed
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-102011-add-existing-expense-selection
Closed

MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-102011-add-existing-expense-selection

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Docs-only follow-up to [CP Staging] fix: always show the selection checkboxes in the add existing expense list.

That PR makes the Add existing expense list always show its selection checkboxes, on every screen size. On mobile the list previously behaved like the other tables: checkboxes were hidden until you long-pressed a row and tapped Select, and the header swapped to Select multiple. Now the checkboxes are there as soon as the list opens, a tap selects and deselects, and the selection is no longer cleared by the app-wide selection mode.

Managing-Expenses-in-a-Report.md is the only help article that documents this flow. Its Add existing unreported expenses steps were written for web ("Click one or more expenses") and said nothing about mobile, so a reader coming from How to Duplicate an Expense or Duplicate a Report — both of which document long-press → Select — would reasonably expect the same pattern here. This PR makes the selection step explicit for both platforms.

Changes:

  • Rewrote the selection step to name the checkboxes and state that they are visible as soon as the list opens on web and mobile, with no long press.
  • Expanded the filter step to match the live UI: Filters → Status (Unreported / Draft) → Apply.
  • Fixed the duplicated step number in that list (it had two step 3s).
  • Added an FAQ entry explaining why this list has no long-press selection mode, and that other mobile lists still do.
  • Added add existing expense and select expenses on mobile to the article keywords for retrieval.

All UI labels were verified against the live app rather than taken from the existing article: the header is Add existing expense, the filter panel is Filters with a Status section offering Unreported and Draft plus Reset / Apply, and the confirm button reads Add to report (it does not change to an "N selected" label).

Written against docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: UI labels are bold and match the UI exactly, the new FAQ heading starts with a question word, and only ## headings were added. npm run spell-changed passes.

Fixed Issues

$ #102003
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

This is a documentation-only change — no app code is touched. Reviewing it means confirming the rendered article matches the shipped behavior of the Add existing expense list on mobile and web.

  • Verify that no errors appear in the JS console

Offline tests

Not applicable — documentation-only change.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

…mobile

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 24, 2026 13:04
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 24, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants