Repository navigation
[CP Staging] fix: always show the selection checkboxes in the add existing expense list - #102011
Conversation
… list Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@Expensify/design @JS00001 Root cause of the issue: The old page used Fix: Added android_hybrid.mp4 |
|
That looks good to me 👍 |
ok so this is what I reported here |
|
Side effect: android device back button not working at all. It just clears selection mode Screen.Recording.2026-09-23.at.10.24.16.AM.mov |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-23.at.10.38.41.AM.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-09-23.at.10.41.51.AM.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
🤖 Code review — the approach is sound and I found no correctness bug. The blast radius is limited to the one table that opts in, which is what you want on a Locally on What I'd change1. Add a unit test for the new prop. 2. The mobile header now grows a select-all checkbox, and the test plan doesn't cover it. 3. Minor: say why both selection props are set. 4. Minor: the What I traced and confirmed
Reply with |
|
🤖 No functional regression found. Every behavior change lands on small screens only, on the one table that opts in. Wide and medium layouts are behaviourally unchanged, and no other Caveats on method: I could not drive this in a browser (web prep failed in this run), and the Jest suites weren't runnable in this environment — so this is static analysis plus The one thing I'd add to the test planSelect-all with an active search wipes the selections that the search is hiding — and this PR makes it much easier to reach on mobile.
This is pre-existing — it already happens on desktop RHP — so it isn't a regression from your diff. But before this PR the mobile header checkbox was behind a long press, and now it's on screen the moment the page opens, right next to the search field this table added. Worth one QA step, and worth deciding whether Two smaller items, both carried over from my earlier review since they're still open: there's no unit test for One thing to confirm with Regression surfaces I checked and clearedWide screens — no behavior change at all. Other tables. Both edits in shared code are gated on the new optional prop, and Mobile header layout. The header does gain a select-all checkbox, and its padding flips No effect loop, no stale global flag. Android back. No duplicate checkbox. Route is always an RHP.
Existing tests. Reply with |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…ing-expense-selection-102003 [CP Staging] fix: always show the selection checkboxes in the add existing expense list (cherry picked from commit be8c9e6) (cherry-picked to staging by lakchote)
|
🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🔁 Filed a Staging retest request for deploy blockers #102003 after this PR was cherry-picked to staging. |
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.4.92-2 🚀
|
|
🤖 Yes — one help site article needed an update. Draft PR: Docs updates for E/A#102011 Add existing expense mobile checkbox selection (
The docs edit names the checkbox, covers click and tap, adds a Note flagging the exception, and fixes a pre-existing duplicated What I checked, and what I deliberately left outScope of the search. Label verification. Every UI label in the edited block was checked against Left out on purpose: the new mobile select-all checkbox. Two judgment calls to check on the docs PR.
Not run: @Krishna2323, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.4.93-0 🚀
|
|
Yes — one help article needed an update. Draft PR: Docs updates for E/A#102011 Add existing expense selection on mobile What changed and why This PR makes the Add existing expense list always show its checkboxes. On mobile that list previously required a long press → Select to enter selection mode, and the header swapped to Select multiple. Now checkboxes appear as soon as the list opens and a tap selects or deselects. Managing-Expenses-in-a-Report.md is the only article documenting this flow. Its Add existing unreported expenses steps were web-only ("Click one or more expenses") and said nothing about mobile — so a reader coming from How to Duplicate an Expense or Duplicate a Report, which both document long-press → Select, would expect the same pattern here. The docs weren't wrong before, but they left the mobile behavior undefined, and now there's a real platform difference worth stating. What the docs PR does
UI verification and guidelines appliedEvery label was checked against the live app rather than copied from the existing article:
Written against No other article under @Krishna2323, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.93-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #102003
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_hybrid.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web_chrome.mp4