Skip to content

feat: use Table component for Add existing expense flow - #100886

Merged
JS00001 merged 20 commits into
Expensify:mainfrom
Krishna2323:krishna2323/table-add-existing-expense-100589
Sep 22, 2026
Merged

JS00001 merged 20 commits into
Expensify:mainfrom
Krishna2323:krishna2323/table-add-existing-expense-100589

Conversation

@Krishna2323

@Krishna2323 Krishna2323 commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #100589
PROPOSAL:

Tests

  1. Open a report/IOU with eligible unreported/draft expenses.
  2. Go to Add expense > Add existing expense and verify expenses load, sorted by date descending.
  3. Click Confirm with nothing selected → verify "Select at least one expense" appears.
  4. Select expenses → click Confirm → verify no error and the flow proceeds.
  5. Select 2-3 expenses, search, then clear the search → verify selections are preserved.
  6. Apply Status filter → verify results filter correctly and selection clears as expected.
  7. Sort by Date and Amount → verify asc/desc toggling works.
  8. Scroll to paginate → verify more expenses load and skeleton appears while loading.
  9. Resize to narrow/RHP width → verify no layout overflow/clipping.
  10. Test offline → verify pending-action feedback renders correctly.
  11. Confirm selected expenses are successfully added to the report.
  • Verify that no errors appear in the JS console

Offline tests

  • Same as tests

QA Steps

  • Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
web_chrome.mp4
MacOS: Chrome / Safari
Monosnap.screencast.2026-09-11.16-30-33.1.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@codecov

codecov Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/MoneyReportHeader.tsx 100.00% <100.00%> (ø)
...onents/Search/FilterDropdowns/MultiSelectPopup.tsx 100.00% <ø> (ø)
src/components/Table/TableContext.tsx 70.00% <ø> (ø)
...FilterBar/TableDisplaySettingsPopoverComponent.tsx 1.63% <ø> (ø)
src/components/Table/TableRow.tsx 86.11% <100.00%> (+0.12%) ⬆️
src/components/Table/middlewares/sorting.ts 96.15% <100.00%> (+0.15%) ⬆️
src/components/Table/middlewares/selection.ts 85.71% <75.00%> (-1.33%) ⬇️
src/components/AddExistingExpenseFooter.tsx 0.00% <0.00%> (ø)
src/components/Table/Table.tsx 92.48% <50.00%> (-1.32%) ⬇️
...omponents/Skeletons/UnreportedExpensesSkeleton.tsx 0.00% <0.00%> (ø)
... and 3 more
... and 321 files with indirect coverage changes

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…ation

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Krishna2323 marked this pull request as ready for review September 14, 2026 08:13
@Krishna2323
Krishna2323 requested review from a team as code owners September 14, 2026 08:13
@melvin-bot
melvin-bot Bot requested review from dylanexpensify and situchan and removed request for a team September 14, 2026 08:13
@melvin-bot

melvin-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 14, 2026 08:13
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@situchan

Copy link
Copy Markdown
Contributor

Bug: on mobile, row is selectable using single tap

bug2.mov

Comment thread src/components/Table/TableRow.tsx Resolved
@situchan

Copy link
Copy Markdown
Contributor

Bug: Applying the Status filter now wipes the selection

bug4.mov

@situchan

situchan commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Bug: default sort order is inconsistent between web and mobile

bug5.mov

Please also check this potential bug on mobile: sort popover "Reset" drops the declared desc order

  1. Open Add existing expense - rows are newest-first.
  2. Open the display-settings (sort) popover → Reset.
  3. Rows become oldest-first, which is not the table's declared default.

dylanexpensify
dylanexpensify previously approved these changes Sep 16, 2026

@dylanexpensify dylanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a product perspective

…en focused

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…er test

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Krishna2323 requested a review from JS00001 September 22, 2026 14:49
@JS00001
JS00001 merged commit d0993cf into Expensify:main Sep 22, 2026
35 of 37 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.92-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Yes, help site changes are required. I opened a draft PR: Docs updates for E/A#100886 Add existing expense search, sort, and selection (Expensify/App#101982).

What changed for members

Rebuilding the pane on the Table component changes what people see in Add expense > Add existing expense, and the current article does not describe any of it:

No src/languages/* strings were added or renamed, so no existing help site wording is now wrong — the article is just incomplete.

What the docs PR does

Updates the Add existing unreported expenses steps in docs/articles/new-expensify/reports-and-expenses/Managing-Expenses-in-a-Report.md:32 to cover search, the Status filter, sorting, and preserved selections. It also documents the "Select at least one expense to add to the report." message, fixes the duplicated step number in that list, and adds the new search and sort phrases to the article keywords.

One caveat: I could not drive NewDot in a browser in this run, so the UI labels come from src/languages/en.ts and the components in this PR, not from a live screen. Please check them when you review.

@Krishna2323, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@mitarachim

Copy link
Copy Markdown

Deploy Blocker https://github.com/Expensify/App/issues/102004was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #102003 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #102021 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants