Repository navigation
Conversation
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…ation Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Bug: on mobile, row is selectable using single tap bug2.mov |
|
Bug: Applying the Status filter now wipes the selection bug4.mov |
|
Bug: default sort order is inconsistent between web and mobile bug5.movPlease also check this potential bug on mobile: sort popover "Reset" drops the declared
|
dylanexpensify
left a comment
There was a problem hiding this comment.
Looks good from a product perspective
…en focused Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…er test Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.92-0 🚀
|
|
Yes, help site changes are required. I opened a draft PR: Docs updates for E/A#100886 Add existing expense search, sort, and selection ( What changed for members Rebuilding the pane on the
No What the docs PR does Updates the Add existing unreported expenses steps in One caveat: I could not drive NewDot in a browser in this run, so the UI labels come from @Krishna2323, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker https://github.com/Expensify/App/issues/102004was identified to be related to this PR. |
|
Deploy Blocker #102003 was identified to be related to this PR. |
|
Deploy Blocker #102021 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #100589
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
web_chrome.mp4
MacOS: Chrome / Safari
Monosnap.screencast.2026-09-11.16-30-33.1.mp4