Skip to content

[Due for payment 2026-10-01] Expense - Status modal is scrollable #102004

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.4.92-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #100886
Email or phone of affected tester (no customers): jsdoijnodsdisojo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Create an expense.
  4. Go to workspace chat.
  5. Create a report.
  6. Click Add expense > Add existing expense.
  7. Click Status button.
  8. Scroll Status modal.

Expected Result:

Status modal should not be scrollable.

Actual Result:

Status modal is scrollable.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7266924_1790146841730.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7266924

Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 23, 2026
  2. applause-bot commented on Sep 23, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/fec1f9e2ec900ac18ab5f52732c0b29005786bc671ff7a4fb76ac764fd66bbea

  3. melvin-bot commented on Sep 23, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #100886

  4. github-actions commented on Sep 23, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Sep 23, 2026

    @melvin-bot

    @JS00001 @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #100886

  6. melvin-bot commented on Sep 23, 2026

    @melvin-bot

    @Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #100886

  7. melvin-bot commented on Sep 23, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Sep 23, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: [Payment due @Krishna2323] Add paginated tag filters with server-side search - by @ShridharGoel (High confidence)
    Related Issues: Reports - Add existing expense to report doesn't work (same flow, different cause — that one does come from #100886)

    Recommendation: ROLL FORWARD

    The auto-assigned PR feat: use Table component for Add existing expense flow is not the cause — its only change to MultiSelectPopup.tsx is deleting a type-only re-export, which has zero runtime effect. The real regression is a 1-line change in MultiSelect.tsx from #99831 that makes every multi-select filter popover render an empty FixedFooter, stealing 20px from the fixed-height list. Reverting #99831 (a large server-side-search feature) is far riskier than the ~3-line targeted patch below.

    Proposed patch in src/components/Search/FilterComponents/MultiSelect.tsx#L173-L185 — only build the footer node when there is actually something to render, so the footerContent prop stays undefined in the common case (restoring production behaviour):

    const footerContent =
        isLoadingMore || footer ? (
            <>
                {!!isLoadingMore && (
                    <View style={[styles.alignItemsCenter, styles.pv4]}>
                        <ActivityIndicator
                            size={CONST.ACTIVITY_INDICATOR_SIZE.SMALL}
                            color={theme.spinner}
                        />
                    </View>
                )}
                {footer}
            </>
        ) : undefined;

    Assigned: @ShridharGoel (PR author), @Krishna2323 (approving reviewer), @JS00001 (approving reviewer) from highest-confidence causing PR only
    Labels: No changes. DeployBlockerCash is kept (App-side fix, App deploy stays blocked). DeployBlocker was not present, so nothing was removed.

    📋 Detailed Analysis

    Evidence

    • Staging-only, not on production — so the cause is in the 9.4.92-0 checklist. Both #99831 (merged 2026-09-22 13:49 UTC) and #100886 (merged 2026-09-22 16:28 UTC) are in it.
    • git diff origin/production origin/staging -- src/components/Search/FilterComponents/MultiSelect.tsx shows exactly one behavioural change relevant to popover height: footerContent={footer} became footerContent={footerContent}, where footerContent is now an unconditionally constructed JSX fragment. That change landed in [Payment due @Krishna2323] Add paginated tag filters with server-side search #99831's merge commit e635f2636430651e145a553b43aa5336fd998748.
    • The Status popup content is unchanged by feat: use Table component for Add existing expense flow #100886: pre-PR, AddExistingExpense.tsx already rendered the very same MultiSelectPopup with the same two options (Unreported / Draft). The only delta feat: use Table component for Add existing expense flow #100886 made to MultiSelectPopup.tsx was removing export type {MultiSelectItem}; — a TypeScript type re-export, erased at compile time. It cannot affect layout or scrolling.
    • Sibling SingleSelect.tsx was not changed the same way (it still passes footerContent={footer}), which is why single-select dropdowns (e.g. Sort by / Sort order) are unaffected — matching the report, which is specific to the multi-select Status popup.

    Verification

    Affected files (all on Expensify/App, permalinks at staging d11856cc123fe882eb39c75b935850480a53f80b):

    Confirmation that #99831 touches these files and #100886 does not (beyond the type export):

    $ git diff e635f2636^1 e635f2636 -- src/components/Search/FilterComponents/MultiSelect.tsx
    -                    footerContent={footer}
    +                    footerContent={footerContent}
    
    $ git diff d0993cfed^1 d0993cfed -- src/components/Search/FilterDropdowns/MultiSelectPopup.tsx
    -export type {MultiSelectItem};
    

    Root Cause

    The Status dropdown is rendered by TableFilterPopoverComponent → MultiSelectPopup → ListFilterHeightContextProvider + MultiSelect. Because the height context is active, ListFilterView gives the list a fixed height from getSelectionListPopoverHeight:

    • itemCount = 2, itemHeight = variables.optionRowHeightCompact = 52
    • ESTIMATED_LIST_HEIGHT = 2 × 52 = 104 → container height = 104px

    Inside that 104px box, BaseSelectionList renders FlashList (flex: 1) followed by <Footer footerContent={footerContent}>. Footer gates on if (footerContent) and FixedFooter gates on if (!children). A JSX fragment — <>{false}{undefined}</> — is a truthy object even when it renders nothing, so both guards pass and FixedFooter mounts a real View with flexShrink: 0 and paddingBottom: 20 (additionalPaddingBottom: styles.pb5.paddingBottom).

    Result: the list viewport shrinks to 104 − 20 = 84px while its content is still 104px, so the two-row list overflows by exactly the phantom footer's padding and becomes scrollable. Before #99831, footer was undefined for MultiSelectPopup, Footer returned null, and the list got the full 104px — hence production is fine. The math is screen-size independent (ESTIMATED_LIST_HEIGHT doesn't change on narrow layouts), which matches the bug reproducing on Android, iOS and macOS Chrome alike.

    Because MultiSelect is only consumed by MultiSelectPopup/TableFilterPopoverComponent, the blast radius is every table filter popover; it just became obvious here because the Status filter has only two options, where any scrolling at all is clearly wrong. Filters with many options were already scrollable, hiding the regression.

    Latent, separate nit (not the cause, no need to fix for this blocker): TableFilterPopoverComponent passes showLabel to MultiSelectPopup, so BasePopup renders the label on all widths, while ListFilterView only subtracts TITLE_HEIGHT when isSmallScreenWidth. For a long filter list on a wide screen the popover can therefore overshoot POPOVER_DROPDOWN_MAX_HEIGHT by ~34px.

    💡 Suggested AI code review rule

    This bug looks like a recurring, mechanically detectable pattern, so it may be worth a coding-standards rule so the AI reviewer catches the next one. Proposed for Expensify/App:

    • Rule: UI-4 Do not build unconditional fragments for optional render slots
    • Condition: When a value passed to an optional render-slot prop (footerContent, header, children, ListFooterComponent, listEmptyContent, …) is built as an unconditional <>…</> whose children are all conditional, return undefined instead when nothing will render — a fragment is truthy even when empty, so consumer guards like if (footerContent) / if (!children) return null mount an empty wrapper with real padding.
    • Why: The empty wrapper still occupies layout space. Here it added a 20px FixedFooter inside a fixed-height filter popover, shrinking the list viewport below its content so a 2-item dropdown became scrollable (#102004).
    • Search pattern: rg -U 'const \w+ = \(\s*\n\s*<>' src then check whether the result is passed to an optional slot prop whose consumer truthiness-checks it; conversely rg 'if \(!children\)|if \(footerContent\)' src/components to find the guards that this defeats.
    • Offending code (❌): MultiSelect.tsx#L173-L185 (guards it defeats: Footer.tsx#L27, FixedFooter.tsx#L39)
    • Fix (✅): the isLoadingMore || footer ? (…) : undefined patch in the Recommendation section above.

    The full rule file, with the ❌/✅ code inline in Expensify/App's app-coding-standards format, would go in Expensify/App itself. If it's worth adding, a maintainer can open it there as a draft PR.

  9. melvin-bot commented on Sep 23, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. melvin-bot commented on Sep 23, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. m-natarajan commented on Sep 23, 2026

    @m-natarajan

    Not repro, Chrome / Xiaomi Redmi Note 10 / Android 12, v9.4.92-2

    Screenrecorder-2026-09-23-15-25-06-383.mp4
    bandicam.2026-09-23.15-18-48-121.mp4
  12. self-assigned this
    on Sep 23, 2026
  13. changed the title [-]Expense - Status modal is scrollable[/-] [+][Due for payment 2026-10-01] Expense - Status modal is scrollable[/+] on Sep 24, 2026
  14. melvin-bot commented on Sep 24, 2026

    @melvin-bot

    @Krishna2323 / @situchan

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.92-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-01. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions